From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7027 invoked by alias); 12 Dec 2016 15:45:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 5163 invoked by uid 89); 12 Dec 2016 15:45:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*c:sk:001a113, U*$ X-HELO: mail-ua0-f173.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+EK0jw/QaFHy+z9a8aQX/k3ghEWaeV2bN0y35asvI9A=; b=S8CfdvVvmPA5jn/D+GK3Nv5XWRmyvr1K8z8unfCY3P/bRzIwZ7YoFUIjT74l08+K0M LR6B5f0N8/+lzxVU+PhjvtVuV5OM8ZDgGHWLesNGOiAgMxMoOObq9lKfLlnIdYmFJudo twsFTe00euYage1xwropHpagVHtwSgOtvWSP1X6OMu/WTNonysQU0H5NmahyPPNlufcq d8QPNYiXutvGkQFOKdcXAJwrISEyQIGW7klbImtcFbNcGXXdWNGv1BW3vlhIBRi2N9/z G0un0jayWmqycojdztrroNOWYU576v0fc/ulvYbYD7ZJubBU3pMxVf8gRTvg95FxnjHc WdCA== X-Gm-Message-State: AKaTC00GBALIJLtvCrCaSPKHkBWXk3uQfvMut1T6vmswHlR48Mlbw2A7LRA3q/FV1sKbJj5X/BNBKgo2xs+gfg== X-Received: by 10.159.33.207 with SMTP id 73mr74321136uac.150.1481557500222; Mon, 12 Dec 2016 07:45:00 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <87d1h1rmfm.fsf@linux-m68k.org> References: <87h96dru2a.fsf@linux-m68k.org> <87d1h1rmfm.fsf@linux-m68k.org> From: Andrew Senkevich Date: Mon, 12 Dec 2016 15:45:00 -0000 Message-ID: Subject: Re: [PATCH] Install libm.a as linker script [BZ #20539] To: Andreas Schwab Cc: "H.J. Lu" , libc-alpha Content-Type: multipart/mixed; boundary=001a113cd7a283fe6e054377fc63 X-SW-Source: 2016-12/txt/msg00405.txt.bz2 --001a113cd7a283fe6e054377fc63 Content-Type: text/plain; charset=UTF-8 Content-length: 2110 2016-12-09 21:23 GMT+03:00 Andreas Schwab : > On Dez 09 2016, Andrew Senkevich wrote: > >> 2016-12-09 18:38 GMT+03:00 Andreas Schwab : >>> On Dez 07 2016, Andrew Senkevich wrote: >>> >>>> +$(inst_libdir)/libm.a: $(common-objpfx)format.lds \ >>>> + $(libm) \ >>>> + $(libmvec) \ >>>> + $(+force) >>>> + (echo '/* GNU ld script'; echo '*/';\ >>>> + cat $<; \ >>>> + echo 'GROUP ( $(libdir)/libm-$(lib-version).a $(libdir)/libmvec.a )' \ >>>> + ) > $@.new >>>> + cp $(objpfx)libm.a $(inst_libdir)/libm-$(lib-version).a >>> >>> A rule should only create the target, nothing else. >> >> Is the following update Ok? > > There is no neeed to go through a stamp file, just depend on > $(inst_libdir)/libm-$(lib-version).a, and add a rule which copies > $(objpfx)libm.a there. I see. Is it ok: diff --git a/ChangeLog b/ChangeLog index 4d31f4f..a5336d3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2016-12-12 Andrew Senkevich + + * math/Makefile ($(inst_libdir)/libm-$(lib-version).a): New target. + ($(inst_libdir)/libm.a): Correct rule to create the target only. + 2016-12-10 Florian Weimer [BZ #20956] diff --git a/math/Makefile b/math/Makefile index 49556f6..38ce4ab 100644 --- a/math/Makefile +++ b/math/Makefile @@ -143,15 +143,17 @@ $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ ) > $@.new mv -f $@.new $@ +$(inst_libdir)/libm-$(lib-version).a: $(objpfx)libm.a + cp $(objpfx)libm.a $(inst_libdir)/libm-$(lib-version).a + $(inst_libdir)/libm.a: $(common-objpfx)format.lds \ - $(libm) \ - $(libmvec) \ + $(inst_libdir)/libm-$(lib-version).a \ + $(objpfx)../mathvec/libmvec.a \ $(+force) (echo '/* GNU ld script'; echo '*/';\ cat $<; \ echo 'GROUP ( $(libdir)/libm-$(lib-version).a $(libdir)/libmvec.a )' \ ) > $@.new - cp $(objpfx)libm.a $(inst_libdir)/libm-$(lib-version).a mv -f $@.new $@ endif -- WBR, Andrew --001a113cd7a283fe6e054377fc63 Content-Type: application/octet-stream; name="bz20539_followup.patch" Content-Disposition: attachment; filename="bz20539_followup.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iwm91qxc0 Content-length: 1558 ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA0ZDMx ZjRmLi5hNTMzNmQzIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsOCBAQAorMjAxNi0xMi0xMiAgQW5kcmV3IFNl bmtldmljaCAgPGFuZHJldy5zZW5rZXZpY2hAaW50ZWwuY29tPgorCisJKiBt YXRoL01ha2VmaWxlICgkKGluc3RfbGliZGlyKS9saWJtLSQobGliLXZlcnNp b24pLmEpOiBOZXcgdGFyZ2V0LgorCSgkKGluc3RfbGliZGlyKS9saWJtLmEp OiBDb3JyZWN0IHJ1bGUgdG8gY3JlYXRlIHRoZSB0YXJnZXQgb25seS4KKwog MjAxNi0xMi0xMCAgRmxvcmlhbiBXZWltZXIgIDxmd2VpbWVyQHJlZGhhdC5j b20+CiAKIAlbQlogIzIwOTU2XQpkaWZmIC0tZ2l0IGEvbWF0aC9NYWtlZmls ZSBiL21hdGgvTWFrZWZpbGUKaW5kZXggNDk1NTZmNi4uMzhjZTRhYiAxMDA2 NDQKLS0tIGEvbWF0aC9NYWtlZmlsZQorKysgYi9tYXRoL01ha2VmaWxlCkBA IC0xNDMsMTUgKzE0MywxNyBAQCAkKGluc3RfbGliZGlyKS9saWJtLnNvOiAk KGNvbW1vbi1vYmpwZngpZm9ybWF0LmxkcyBcCiAJKSA+ICRALm5ldwogCW12 IC1mICRALm5ldyAkQAogCiskKGluc3RfbGliZGlyKS9saWJtLSQobGliLXZl cnNpb24pLmE6ICQob2JqcGZ4KWxpYm0uYQorCWNwICQob2JqcGZ4KWxpYm0u YSAkKGluc3RfbGliZGlyKS9saWJtLSQobGliLXZlcnNpb24pLmEKKwogJChp bnN0X2xpYmRpcikvbGlibS5hOiAkKGNvbW1vbi1vYmpwZngpZm9ybWF0Lmxk cyBcCi0JCSAgICAgICAkKGxpYm0pIFwKLQkJICAgICAgICQobGlibXZlYykg XAorCQkgICAgICAgJChpbnN0X2xpYmRpcikvbGlibS0kKGxpYi12ZXJzaW9u KS5hIFwKKwkJICAgICAgICQob2JqcGZ4KS4uL21hdGh2ZWMvbGlibXZlYy5h IFwKIAkJICAgICAgICQoK2ZvcmNlKQogCShlY2hvICcvKiBHTlUgbGQgc2Ny aXB0JzsgZWNobyAnKi8nO1wKIAkgY2F0ICQ8OyBcCiAJIGVjaG8gJ0dST1VQ ICggJChsaWJkaXIpL2xpYm0tJChsaWItdmVyc2lvbikuYSAkKGxpYmRpcikv bGlibXZlYy5hICknIFwKIAkpID4gJEAubmV3Ci0JY3AgJChvYmpwZngpbGli bS5hICQoaW5zdF9saWJkaXIpL2xpYm0tJChsaWItdmVyc2lvbikuYQogCW12 IC1mICRALm5ldyAkQAogZW5kaWYKIAo= --001a113cd7a283fe6e054377fc63--