From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by sourceware.org (Postfix) with ESMTPS id E24E1385800B for ; Thu, 28 Jul 2022 11:01:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E24E1385800B Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-10bd4812c29so1873013fac.11 for ; Thu, 28 Jul 2022 04:01:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sx8dXhWzRCLHTFr/Lnj/hvOO96cuB5U55JfjkIOpYeQ=; b=2L5KFZNH2UWNvhqSuRnLnNiiJ3X3VX1rZSlnM5DbTynImXg/nhLez5ev5CCFNF5fPz spo8WKMis7Bma6qWAA3esvrqpcVd694Cm6c6rR+BeyHJ7/lQFarmVTwcOl+PN42VRX15 HtS6U8sVAIS2X10N8Z8Tpuj2j7OKDrrQUASNh+I/PhoaoWX8O/wKqgzN+jY5DgOdR703 Xj1S+awxzv9nq0dZzt78CFswRCl6Oqsq9YogLpwiqaA/aD18Kn0IaJrh64WnBkLCwP9A WpioQSfIoeAyXmlVKRvAZXjr/9Qyms+57nVtbOs0k3ErPKkD1eCs5sK1hOneqhN9CjYA j8Xg== X-Gm-Message-State: AJIora9WnhnzhMN/zjaTANoi+/a8pTEb1oZaW/kbg1Vn2RgqL9A9nlQ1 +VzGpY+w4VM+Vq1yY1GvoF06YLGkvzBjGdTvmRNG4w== X-Google-Smtp-Source: AGRyM1vmW/Ay79hmx64TnCoDIsCNfdS2lHYKc0EOlDU1Rdgz/oYP2E3BIVF+8zhIXocGFIR4Yu001IJyKOLh1s8wtco= X-Received: by 2002:a05:6870:1686:b0:10d:9cbf:aa6f with SMTP id j6-20020a056870168600b0010d9cbfaa6fmr4241116oae.93.1659006092860; Thu, 28 Jul 2022 04:01:32 -0700 (PDT) MIME-Version: 1.0 References: <20220726190830.1189339-1-Jason@zx2c4.com> <20220726195822.1223048-1-Jason@zx2c4.com> In-Reply-To: From: Adhemerval Zanella Date: Thu, 28 Jul 2022 08:01:22 -0300 Message-ID: Subject: Re: [PATCH v6] arc4random: simplify design for better safety To: Szabolcs Nagy Cc: "Jason A. Donenfeld" , Florian Weimer , Eric Biggers , libc-alpha@sourceware.org, linux-crypto@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 11:01:37 -0000 On Thu, Jul 28, 2022 at 7:37 AM Szabolcs Nagy via Libc-alpha wrote: > > The 07/28/2022 11:29, Szabolcs Nagy via Libc-alpha wrote: > > The 07/26/2022 21:58, Jason A. Donenfeld via Libc-alpha wrote: > ... > > > > fyi, after this patch i see > > > > FAIL: stdlib/tst-arc4random-thread > > > > with > > > > $ cat stdlib/tst-arc4random-thread.out > > info: arc4random: minimum of 1750000 blob results expected > > info: arc4random: 1750777 blob results observed > > info: arc4random_buf: minimum of 1750000 blob results expected > > info: arc4random_buf: 1750000 blob results observed > > info: arc4random_uniform: minimum of 1750000 blob results expected > > Timed out: killed the child process > > Termination time: 2022-07-27T14:41:33.766791947 > > Last write to standard output: 2022-07-27T14:41:22.522497854 > > > > on an arm and aarch64 builder. > > > > running it manually it takes >30s to complete. > > note that before the patch it was <5s on the same machine. Yeap, we need to tune down the internal test parameters [1]. [1] https://patchwork.sourceware.org/project/glibc/patch/20220727131031.2016648-1-adhemerval.zanella@linaro.org/