From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 891F3385DC07 for ; Fri, 14 Jan 2022 15:07:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 891F3385DC07 Received: by mail-pj1-x102c.google.com with SMTP id pf13so13673162pjb.0 for ; Fri, 14 Jan 2022 07:07:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dwKQJJGGj05aw88YELds41pqqIRrOrC8DXKJZD6OZpU=; b=eFkL4uEcvXvwa9S21rSUiNtRt8tGQdtB1F1WBbb/BNDShBuCxy9XWgljw397yIsX02 2lKYkc+WV1JLEJMJvEmDWLs29HOW7TkYeKNxNzT6vL+7SohQIwpArYSf2UDxNHoCSwv3 k8cOHbcxdgSgerF3lwivC6LIk979P2DENGG3LNbt854T9UdGro+wubQlUlxZYtiPFwtQ xP0zB2In6Mv9pkQemZGCWHhcnhesZ3dOsCMDfcLYsojGcim/aUDTxZejMbxRM1bfvZam zNtfsDacAo+HgQSNdhddNMK7w0KMWa3NgLBTbgmth3i6suaK+8QzM+XNT34dYndtG0lT 3pPg== X-Gm-Message-State: AOAM533532UKSLw+6WhnGowmy2Us1TlOVWfoXEyFb8V8ekZ3i85WNRV+ K9tRm5xmvYJjXNPo1bLZcMzqppOd3IyIIVLM7mI= X-Google-Smtp-Source: ABdhPJyYER/egY1E/aTVmi62hHZr3CFKO8nw1GNJiclY2L/9eKRfCBaY8Ba05jiNB+CfNvbOi+iPm9Zkx+I3J9H4JlM= X-Received: by 2002:a17:902:bf09:b0:149:d2a3:ddac with SMTP id bi9-20020a170902bf0900b00149d2a3ddacmr10231871plb.4.1642172833656; Fri, 14 Jan 2022 07:07:13 -0800 (PST) MIME-Version: 1.0 References: <636c6da259e612258791a6e816bfc7bbfed97e3a.1641228666.git.fweimer@redhat.com> In-Reply-To: <636c6da259e612258791a6e816bfc7bbfed97e3a.1641228666.git.fweimer@redhat.com> From: "H.J. Lu" Date: Fri, 14 Jan 2022 07:06:37 -0800 Message-ID: Subject: Re: [PATCH 3/3] elf/tst-dl_find_object: Disable subtests for non-contiguous maps (bug 28732) To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3027.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 15:07:16 -0000 On Mon, Jan 3, 2022 at 9:13 AM Florian Weimer via Libc-alpha wrote: > > --- > elf/tst-dl_find_object.c | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/elf/tst-dl_find_object.c b/elf/tst-dl_find_object.c > index 21cdc0f848..2ad1924088 100644 > --- a/elf/tst-dl_find_object.c > +++ b/elf/tst-dl_find_object.c > @@ -71,19 +71,24 @@ check (void *address, > __FILE__, line, address, > actual.dlfo_flags, expected->dlfo_flags); > } > - if (actual.dlfo_flags != expected->dlfo_flags) > + if (expected->dlfo_link_map->l_contiguous) > { > - support_record_failure (); > - printf ("%s:%d: error: %p: map start is %p, expected %p\n", > - __FILE__, line, > - address, actual.dlfo_map_start, expected->dlfo_map_start); > - } > - if (actual.dlfo_map_end != expected->dlfo_map_end) > - { > - support_record_failure (); > - printf ("%s:%d: error: %p: map end is %p, expected %p\n", > - __FILE__, line, > - address, actual.dlfo_map_end, expected->dlfo_map_end); > + /* If the mappings are not contiguous, the actual and execpted > + mappings may differ, so this subtest will not work. */ > + if (actual.dlfo_flags != expected->dlfo_flags) > + { > + support_record_failure (); > + printf ("%s:%d: error: %p: map start is %p, expected %p\n", > + __FILE__, line, > + address, actual.dlfo_map_start, expected->dlfo_map_start); > + } > + if (actual.dlfo_map_end != expected->dlfo_map_end) > + { > + support_record_failure (); > + printf ("%s:%d: error: %p: map end is %p, expected %p\n", > + __FILE__, line, > + address, actual.dlfo_map_end, expected->dlfo_map_end); > + } > } > if (actual.dlfo_link_map != expected->dlfo_link_map) > { > -- > 2.33.1 > I still see FAIL: elf/tst-dl_find_object even when using the new linker with the fix for https://sourceware.org/bugzilla/show_bug.cgi?id=28743 to remove the 1-page gap. Which file doesn't have non-contiguous mapping? -- H.J.