From: "H.J. Lu" <hjl.tools@gmail.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
"Carlos O'Donell" <carlos@systemhalted.org>
Subject: Re: [PATCH v5] x86: Add more feature definitions to isa-level.h
Date: Tue, 28 Jun 2022 07:38:47 -0700 [thread overview]
Message-ID: <CAMe9rOo0CcDVk13ANwBK50Dr6cpiWA1m8MpmxCX6+rS=VF9RXg@mail.gmail.com> (raw)
In-Reply-To: <20220628040703.2296390-1-goldstein.w.n@gmail.com>
On Mon, Jun 27, 2022 at 9:07 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> This commit doesn't change anything in itself. It is just to add
> definitions that will be needed by future patches.
> ---
> sysdeps/x86/isa-level.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/sysdeps/x86/isa-level.h b/sysdeps/x86/isa-level.h
> index f293aea906..77f9e2c0c3 100644
> --- a/sysdeps/x86/isa-level.h
> +++ b/sysdeps/x86/isa-level.h
> @@ -67,15 +67,27 @@
> /* Depending on the minimum ISA level, a feature check result can be a
> compile-time constant.. */
>
> +
> +/* For CPU_FEATURE_USABLE_P. */
> +
> /* ISA level >= 4 guaranteed includes. */
> #define AVX512F_X86_ISA_LEVEL 4
> #define AVX512VL_X86_ISA_LEVEL 4
> #define AVX512BW_X86_ISA_LEVEL 4
> +#define AVX512DQ_X86_ISA_LEVEL 4
>
> /* ISA level >= 3 guaranteed includes. */
> #define AVX_X86_ISA_LEVEL 3
> #define AVX2_X86_ISA_LEVEL 3
> #define BMI2_X86_ISA_LEVEL 3
> +#define MOVBE_X86_ISA_LEVEL 3
> +
> +/* ISA level >= 2 guaranteed includes. */
> +#define SSE4_2_X86_ISA_LEVEL 2
> +#define SSSE3_X86_ISA_LEVEL 2
> +
> +
> +/* For X86_ISA_CPU_FEATURES_ARCH_P. */
>
> /* NB: This feature is enabled when ISA level >= 3, which was disabled
> for the following CPUs:
> @@ -89,6 +101,9 @@
> when ISA level < 3. */
> #define Prefer_No_VZEROUPPER_X86_ISA_LEVEL 3
>
> +/* Feature(s) enabled when ISA level >= 2. */
> +#define Fast_Unaligned_Load_X86_ISA_LEVEL 2
> +
> /* Both X86_ISA_CPU_FEATURE_USABLE_P and X86_ISA_CPU_FEATURES_ARCH_P
> macros are wrappers for the respective CPU_FEATURE{S}_{USABLE|ARCH}_P
> runtime checks. They differ in two ways.
> --
> 2.34.1
>
LGTM.
Thanks.
--
H.J.
prev parent reply other threads:[~2022-06-28 14:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 1:04 [PATCH v1] " Noah Goldstein
2022-06-28 1:56 ` H.J. Lu
2022-06-28 2:04 ` Noah Goldstein
2022-06-28 2:03 ` [PATCH v2] " Noah Goldstein
2022-06-28 2:29 ` H.J. Lu
2022-06-28 2:34 ` Noah Goldstein
2022-06-28 2:38 ` H.J. Lu
2022-06-28 2:41 ` Noah Goldstein
2022-06-28 3:03 ` H.J. Lu
2022-06-28 3:26 ` [PATCH v3] " Noah Goldstein
2022-06-28 3:30 ` H.J. Lu
2022-06-28 3:32 ` H.J. Lu
2022-06-28 3:35 ` Noah Goldstein
2022-06-28 3:44 ` H.J. Lu
2022-06-28 3:50 ` Noah Goldstein
2022-06-28 3:49 ` [PATCH v4] " Noah Goldstein
2022-06-28 3:58 ` H.J. Lu
2022-06-28 4:07 ` Noah Goldstein
2022-06-28 4:07 ` [PATCH v5] " Noah Goldstein
2022-06-28 14:38 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOo0CcDVk13ANwBK50Dr6cpiWA1m8MpmxCX6+rS=VF9RXg@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=carlos@systemhalted.org \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).