From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id CE647385800A for ; Thu, 30 Sep 2021 17:55:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CE647385800A Received: by mail-pj1-x1034.google.com with SMTP id na16-20020a17090b4c1000b0019f5bb661f9so1610760pjb.0 for ; Thu, 30 Sep 2021 10:55:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqCP0Kuxz6lezCQFwz5nILYEMHrgWVEV/eJukyzzKYY=; b=idLig/zWFG3UmL8lVWEiU2X+5ujsamx8Auqaz5i29035OMi9mKthIvqVQo2qXOH6ql zlEblepHGVIqZJ6F90bp4byE2/JLVlYA6kZPlMIXTjn3YmAEVA3K6TK+WHokL2ugXiI0 RUkNprEZEBIYqlqGfFc/W2/VnxZ/uFHkNLBrrr+uaudZb9HXd30NLuWBqNl2ZnhQ7vwb llxQyViTeOsTmriqZRYzeajzHUDkHhk/qASYJZgAmwMpzR4P25RMMnU0dJ0kPMNOx7NE 2KRZguyE4d9PuzJooAv5urCEbTzxLD+Je3R97lgQh1EQeDlgpbDVwOssL5QLfP2JC0X0 3O6Q== X-Gm-Message-State: AOAM530Q8Tp3QzEc0sJZMK0ULamDyFa2c6JqyVqw4r3IXqM7BQtsuZLV smqNR49+cQ5xeDOL2+TCoVdTNwrZC3fPT0yLLxWS/cw/ol4= X-Google-Smtp-Source: ABdhPJzcelZ3RI9CZqOX7+T5+jSFKcHZJQlyLN4qY1/uuyTpxV3KUzLPbk65m26QMpcCBstscL5LexEJ+UXFskedD2s= X-Received: by 2002:a17:90b:3805:: with SMTP id mq5mr14480296pjb.143.1633024516777; Thu, 30 Sep 2021 10:55:16 -0700 (PDT) MIME-Version: 1.0 References: <87czoq4a44.fsf@oldenburg.str.redhat.com> <069fcec4-d81f-3ea8-d87c-ff3b281dbe71@linaro.org> In-Reply-To: <069fcec4-d81f-3ea8-d87c-ff3b281dbe71@linaro.org> From: "H.J. Lu" Date: Thu, 30 Sep 2021 10:54:40 -0700 Message-ID: Subject: Re: [PATCH v2] Suppress -Wcast-qual warnings in bsearch To: Adhemerval Zanella Cc: GNU C Library , Jonathan Wakely , Joseph Myers Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3030.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2021 17:55:19 -0000 On Thu, Sep 30, 2021 at 7:49 AM Adhemerval Zanella via Libc-alpha wrote: > > > > On 30/09/2021 07:43, Florian Weimer via Libc-alpha wrote: > > * Jonathan Wakely via Libc-alpha: > > > >> diff --git a/bits/stdlib-bsearch.h b/bits/stdlib-bsearch.h > >> index 4132dc6af0..d688ed2e15 100644 > >> --- a/bits/stdlib-bsearch.h > >> +++ b/bits/stdlib-bsearch.h > >> @@ -29,14 +29,21 @@ bsearch (const void *__key, const void *__base, size_t __nmemb, size_t __size, > >> while (__l < __u) > >> { > >> __idx = (__l + __u) / 2; > >> - __p = (void *) (((const char *) __base) + (__idx * __size)); > >> + __p = (const void *) (((const char *) __base) + (__idx * __size)); > >> __comparison = (*__compar) (__key, __p); > >> if (__comparison < 0) > >> __u = __idx; > >> else if (__comparison > 0) > >> __l = __idx + 1; > >> else > >> +#if __GNUC_PREREQ(4, 6) > >> +# pragma GCC diagnostic push > >> +# pragma GCC diagnostic ignored "-Wcast-qual" > >> +#endif > >> return (void *) __p; > >> +#if __GNUC_PREREQ(4, 6) > >> +# pragma GCC diagnostic pop > >> +#endif > >> } > >> > >> return NULL; > > > > Patch looks okay, thanks. > > > > Reviewed-by: Florian Weimer > > > > Florian > > > > I am seeing a lot of failure on x86_64 with gcc 11.1 after this > patch landed: > > x86_64-linux-gnu$ grep ^FAIL tests.sum > FAIL: catgets/de/libc.cat > FAIL: catgets/test-gencat > FAIL: catgets/test1.cat > FAIL: catgets/tst-catgets > FAIL: debug/tst-chk1 > FAIL: debug/tst-chk2 > FAIL: debug/tst-chk3 > FAIL: debug/tst-chk4 > FAIL: debug/tst-chk5 > FAIL: debug/tst-chk6 > FAIL: debug/tst-lfschk1 > FAIL: debug/tst-lfschk2 > FAIL: debug/tst-lfschk3 > FAIL: debug/tst-lfschk4 > FAIL: debug/tst-lfschk5 > FAIL: debug/tst-lfschk6 > [...] > > For instance some math tests shows ulps failures that does not > make much sense: > > $ ./testrun.sh math/test-double-cacos > testing double (without inline functions) > Failure: Test: Imaginary part of: cacos_downward (-0x1p-52 - 0x1.0000000000001p+0 i) > Result: > is: 8.8137358701954271e-01 0x1.c34366179d424p-1 > should be: 8.8137358701954315e-01 0x1.c34366179d428p-1 > difference: 4.4408920985006261e-16 0x1.0000000000000p-51 > ulp : 4.0000 > max.ulp : 3.0000 > Failure: Test: Imaginary part of: cacos_downward (-0x1p-52 - 0x1.000002p+0 i) > Result: > is: 8.8137367131323707e-01 0x1.c34368ebb10d9p-1 > should be: 8.8137367131323751e-01 0x1.c34368ebb10ddp-1 > difference: 4.4408920985006261e-16 0x1.0000000000000p-51 > ulp : 4.0000 > max.ulp : 3.0000 > [...] > > Reverting fixes it. I opened: https://sourceware.org/bugzilla/show_bug.cgi?id=28400 I think the patch should be reverted. -- H.J.