* [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
@ 2022-07-07 23:39 H.J. Lu
2022-07-07 23:42 ` H.J. Lu
0 siblings, 1 reply; 11+ messages in thread
From: H.J. Lu @ 2022-07-07 23:39 UTC (permalink / raw)
To: libc-alpha
Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
---
sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
3 files changed, 3 deletions(-)
diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
index 8da09bd86d..516cde1145 100644
--- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
+++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
@@ -184,7 +184,6 @@
.align 16
.type STRCMP, @function
.globl STRCMP
- .hidden STRCMP
# ifndef GLABEL
# define GLABEL(...) __VA_ARGS__
diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
index 2a5b3ce037..e97d51bb26 100644
--- a/sysdeps/x86_64/multiarch/strcmp-evex.S
+++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
@@ -214,7 +214,6 @@
.align 16
.type STRCMP, @function
.globl STRCMP
- .hidden STRCMP
# ifdef USE_AS_STRCASECMP_L
ENTRY (STRCASECMP)
diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
index a9178ad25c..60313c647a 100644
--- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
+++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
@@ -77,7 +77,6 @@
.align 16
.type STRCMP_SSE42, @function
.globl STRCMP_SSE42
- .hidden STRCMP_SSE42
#ifdef USE_AS_STRCASECMP_L
ENTRY (GLABEL(__strcasecmp))
movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
--
2.36.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
2022-07-07 23:39 [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S H.J. Lu
@ 2022-07-07 23:42 ` H.J. Lu
2022-07-07 23:45 ` Noah Goldstein
0 siblings, 1 reply; 11+ messages in thread
From: H.J. Lu @ 2022-07-07 23:42 UTC (permalink / raw)
To: GNU C Library
On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> ---
> sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> index 8da09bd86d..516cde1145 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> @@ -184,7 +184,6 @@
> .align 16
> .type STRCMP, @function
> .globl STRCMP
> - .hidden STRCMP
Hi Noah,
Why aren't ENTRY/END used on STRCMP?
> # ifndef GLABEL
> # define GLABEL(...) __VA_ARGS__
> diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> index 2a5b3ce037..e97d51bb26 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> @@ -214,7 +214,6 @@
> .align 16
> .type STRCMP, @function
> .globl STRCMP
> - .hidden STRCMP
>
> # ifdef USE_AS_STRCASECMP_L
> ENTRY (STRCASECMP)
> diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> index a9178ad25c..60313c647a 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> @@ -77,7 +77,6 @@
> .align 16
> .type STRCMP_SSE42, @function
> .globl STRCMP_SSE42
> - .hidden STRCMP_SSE42
> #ifdef USE_AS_STRCASECMP_L
> ENTRY (GLABEL(__strcasecmp))
> movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> --
> 2.36.1
>
--
H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
2022-07-07 23:42 ` H.J. Lu
@ 2022-07-07 23:45 ` Noah Goldstein
2022-07-07 23:47 ` Noah Goldstein
2022-07-07 23:54 ` H.J. Lu
0 siblings, 2 replies; 11+ messages in thread
From: Noah Goldstein @ 2022-07-07 23:45 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > ---
> > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > index 8da09bd86d..516cde1145 100644
> > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > @@ -184,7 +184,6 @@
> > .align 16
> > .type STRCMP, @function
> > .globl STRCMP
> > - .hidden STRCMP
>
> Hi Noah,
>
> Why aren't ENTRY/END used on STRCMP?
>
Not sure, I copied sse42 when doing avx2/evex.
> > # ifndef GLABEL
> > # define GLABEL(...) __VA_ARGS__
> > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > index 2a5b3ce037..e97d51bb26 100644
> > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > @@ -214,7 +214,6 @@
> > .align 16
> > .type STRCMP, @function
> > .globl STRCMP
> > - .hidden STRCMP
> >
> > # ifdef USE_AS_STRCASECMP_L
> > ENTRY (STRCASECMP)
> > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > index a9178ad25c..60313c647a 100644
> > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > @@ -77,7 +77,6 @@
> > .align 16
> > .type STRCMP_SSE42, @function
> > .globl STRCMP_SSE42
> > - .hidden STRCMP_SSE42
> > #ifdef USE_AS_STRCASECMP_L
> > ENTRY (GLABEL(__strcasecmp))
> > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > --
> > 2.36.1
> >
>
>
> --
> H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
2022-07-07 23:45 ` Noah Goldstein
@ 2022-07-07 23:47 ` Noah Goldstein
2022-07-07 23:51 ` H.J. Lu
2022-07-07 23:54 ` H.J. Lu
1 sibling, 1 reply; 11+ messages in thread
From: Noah Goldstein @ 2022-07-07 23:47 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
On Thu, Jul 7, 2022 at 4:45 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > > ---
> > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> > > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> > > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > > 3 files changed, 3 deletions(-)
> > >
> > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > index 8da09bd86d..516cde1145 100644
> > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > @@ -184,7 +184,6 @@
> > > .align 16
> > > .type STRCMP, @function
> > > .globl STRCMP
> > > - .hidden STRCMP
> >
> > Hi Noah,
> >
> > Why aren't ENTRY/END used on STRCMP?
> >
>
> Not sure, I copied sse42 when doing avx2/evex.
>
> > > # ifndef GLABEL
> > > # define GLABEL(...) __VA_ARGS__
> > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > index 2a5b3ce037..e97d51bb26 100644
> > > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > @@ -214,7 +214,6 @@
> > > .align 16
> > > .type STRCMP, @function
> > > .globl STRCMP
> > > - .hidden STRCMP
> > >
> > > # ifdef USE_AS_STRCASECMP_L
> > > ENTRY (STRCASECMP)
> > > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > index a9178ad25c..60313c647a 100644
> > > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > @@ -77,7 +77,6 @@
> > > .align 16
> > > .type STRCMP_SSE42, @function
> > > .globl STRCMP_SSE42
> > > - .hidden STRCMP_SSE42
> > > #ifdef USE_AS_STRCASECMP_L
> > > ENTRY (GLABEL(__strcasecmp))
> > > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > > --
> > > 2.36.1
> > >
> >
Do you need to do strcmp-sse2.S?
> >
> > --
> > H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
2022-07-07 23:47 ` Noah Goldstein
@ 2022-07-07 23:51 ` H.J. Lu
2022-07-07 23:54 ` Noah Goldstein
0 siblings, 1 reply; 11+ messages in thread
From: H.J. Lu @ 2022-07-07 23:51 UTC (permalink / raw)
To: Noah Goldstein; +Cc: GNU C Library
On Thu, Jul 7, 2022 at 4:47 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 4:45 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > >
> > > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > > > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > > > ---
> > > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> > > > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> > > > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > > > 3 files changed, 3 deletions(-)
> > > >
> > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > index 8da09bd86d..516cde1145 100644
> > > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > @@ -184,7 +184,6 @@
> > > > .align 16
> > > > .type STRCMP, @function
> > > > .globl STRCMP
> > > > - .hidden STRCMP
> > >
> > > Hi Noah,
> > >
> > > Why aren't ENTRY/END used on STRCMP?
> > >
> >
> > Not sure, I copied sse42 when doing avx2/evex.
> >
> > > > # ifndef GLABEL
> > > > # define GLABEL(...) __VA_ARGS__
> > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > index 2a5b3ce037..e97d51bb26 100644
> > > > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > @@ -214,7 +214,6 @@
> > > > .align 16
> > > > .type STRCMP, @function
> > > > .globl STRCMP
> > > > - .hidden STRCMP
> > > >
> > > > # ifdef USE_AS_STRCASECMP_L
> > > > ENTRY (STRCASECMP)
> > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > index a9178ad25c..60313c647a 100644
> > > > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > @@ -77,7 +77,6 @@
> > > > .align 16
> > > > .type STRCMP_SSE42, @function
> > > > .globl STRCMP_SSE42
> > > > - .hidden STRCMP_SSE42
> > > > #ifdef USE_AS_STRCASECMP_L
> > > > ENTRY (GLABEL(__strcasecmp))
> > > > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > > > --
> > > > 2.36.1
> > > >
> > >
>
> Do you need to do strcmp-sse2.S?
There is no strcmp-sse2.S on master branch.
--
H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
2022-07-07 23:45 ` Noah Goldstein
2022-07-07 23:47 ` Noah Goldstein
@ 2022-07-07 23:54 ` H.J. Lu
1 sibling, 0 replies; 11+ messages in thread
From: H.J. Lu @ 2022-07-07 23:54 UTC (permalink / raw)
To: Noah Goldstein; +Cc: GNU C Library
On Thu, Jul 7, 2022 at 4:45 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > > ---
> > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> > > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> > > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > > 3 files changed, 3 deletions(-)
> > >
> > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > index 8da09bd86d..516cde1145 100644
> > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > @@ -184,7 +184,6 @@
> > > .align 16
> > > .type STRCMP, @function
> > > .globl STRCMP
> > > - .hidden STRCMP
> >
> > Hi Noah,
> >
> > Why aren't ENTRY/END used on STRCMP?
> >
>
> Not sure, I copied sse42 when doing avx2/evex.
Let's leave it asis for now. We only need to remove .hidden.
> > > # ifndef GLABEL
> > > # define GLABEL(...) __VA_ARGS__
> > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > index 2a5b3ce037..e97d51bb26 100644
> > > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > @@ -214,7 +214,6 @@
> > > .align 16
> > > .type STRCMP, @function
> > > .globl STRCMP
> > > - .hidden STRCMP
> > >
> > > # ifdef USE_AS_STRCASECMP_L
> > > ENTRY (STRCASECMP)
> > > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > index a9178ad25c..60313c647a 100644
> > > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > @@ -77,7 +77,6 @@
> > > .align 16
> > > .type STRCMP_SSE42, @function
> > > .globl STRCMP_SSE42
> > > - .hidden STRCMP_SSE42
> > > #ifdef USE_AS_STRCASECMP_L
> > > ENTRY (GLABEL(__strcasecmp))
> > > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > > --
> > > 2.36.1
> > >
> >
> >
> > --
> > H.J.
--
H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
2022-07-07 23:51 ` H.J. Lu
@ 2022-07-07 23:54 ` Noah Goldstein
2022-07-07 23:57 ` H.J. Lu
0 siblings, 1 reply; 11+ messages in thread
From: Noah Goldstein @ 2022-07-07 23:54 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
On Thu, Jul 7, 2022 at 4:52 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 4:47 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Thu, Jul 7, 2022 at 4:45 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > >
> > > > On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > >
> > > > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > > > > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > > > > ---
> > > > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> > > > > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> > > > > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > > > > 3 files changed, 3 deletions(-)
> > > > >
> > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > index 8da09bd86d..516cde1145 100644
> > > > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > @@ -184,7 +184,6 @@
> > > > > .align 16
> > > > > .type STRCMP, @function
> > > > > .globl STRCMP
> > > > > - .hidden STRCMP
> > > >
> > > > Hi Noah,
> > > >
> > > > Why aren't ENTRY/END used on STRCMP?
> > > >
> > >
> > > Not sure, I copied sse42 when doing avx2/evex.
> > >
> > > > > # ifndef GLABEL
> > > > > # define GLABEL(...) __VA_ARGS__
> > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > index 2a5b3ce037..e97d51bb26 100644
> > > > > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > @@ -214,7 +214,6 @@
> > > > > .align 16
> > > > > .type STRCMP, @function
> > > > > .globl STRCMP
> > > > > - .hidden STRCMP
> > > > >
> > > > > # ifdef USE_AS_STRCASECMP_L
> > > > > ENTRY (STRCASECMP)
> > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > index a9178ad25c..60313c647a 100644
> > > > > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > @@ -77,7 +77,6 @@
> > > > > .align 16
> > > > > .type STRCMP_SSE42, @function
> > > > > .globl STRCMP_SSE42
> > > > > - .hidden STRCMP_SSE42
> > > > > #ifdef USE_AS_STRCASECMP_L
> > > > > ENTRY (GLABEL(__strcasecmp))
> > > > > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > > > > --
> > > > > 2.36.1
> > > > >
> > > >
> >
> > Do you need to do strcmp-sse2.S?
>
> There is no strcmp-sse2.S on master branch.
Can we rebase this ontop of my patches?
Between the "move stuff" and isa raising?
>
>
> --
> H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
2022-07-07 23:54 ` Noah Goldstein
@ 2022-07-07 23:57 ` H.J. Lu
2022-07-08 0:00 ` Noah Goldstein
0 siblings, 1 reply; 11+ messages in thread
From: H.J. Lu @ 2022-07-07 23:57 UTC (permalink / raw)
To: Noah Goldstein; +Cc: GNU C Library
On Thu, Jul 7, 2022 at 4:54 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 4:52 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Thu, Jul 7, 2022 at 4:47 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > On Thu, Jul 7, 2022 at 4:45 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > > >
> > > > On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > >
> > > > > On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > > >
> > > > > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > > > > > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > > > > > ---
> > > > > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> > > > > > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> > > > > > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > > > > > 3 files changed, 3 deletions(-)
> > > > > >
> > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > index 8da09bd86d..516cde1145 100644
> > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > @@ -184,7 +184,6 @@
> > > > > > .align 16
> > > > > > .type STRCMP, @function
> > > > > > .globl STRCMP
> > > > > > - .hidden STRCMP
> > > > >
> > > > > Hi Noah,
> > > > >
> > > > > Why aren't ENTRY/END used on STRCMP?
> > > > >
> > > >
> > > > Not sure, I copied sse42 when doing avx2/evex.
> > > >
> > > > > > # ifndef GLABEL
> > > > > > # define GLABEL(...) __VA_ARGS__
> > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > index 2a5b3ce037..e97d51bb26 100644
> > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > @@ -214,7 +214,6 @@
> > > > > > .align 16
> > > > > > .type STRCMP, @function
> > > > > > .globl STRCMP
> > > > > > - .hidden STRCMP
> > > > > >
> > > > > > # ifdef USE_AS_STRCASECMP_L
> > > > > > ENTRY (STRCASECMP)
> > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > index a9178ad25c..60313c647a 100644
> > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > @@ -77,7 +77,6 @@
> > > > > > .align 16
> > > > > > .type STRCMP_SSE42, @function
> > > > > > .globl STRCMP_SSE42
> > > > > > - .hidden STRCMP_SSE42
> > > > > > #ifdef USE_AS_STRCASECMP_L
> > > > > > ENTRY (GLABEL(__strcasecmp))
> > > > > > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > > > > > --
> > > > > > 2.36.1
> > > > > >
> > > > >
> > >
> > > Do you need to do strcmp-sse2.S?
> >
> > There is no strcmp-sse2.S on master branch.
>
> Can we rebase this ontop of my patches?
> Between the "move stuff" and isa raising?
It should be fixed on master branch first. We don't need
# ifdef USE_MULTIARCH
.hidden STRCMP
# endif
It isn't necessary.
--
H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
2022-07-07 23:57 ` H.J. Lu
@ 2022-07-08 0:00 ` Noah Goldstein
2022-07-08 0:05 ` H.J. Lu
0 siblings, 1 reply; 11+ messages in thread
From: Noah Goldstein @ 2022-07-08 0:00 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
On Thu, Jul 7, 2022 at 4:58 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 4:54 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Thu, Jul 7, 2022 at 4:52 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Thu, Jul 7, 2022 at 4:47 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > > >
> > > > On Thu, Jul 7, 2022 at 4:45 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > > > >
> > > > > On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > > >
> > > > > > On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > > > >
> > > > > > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > > > > > > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > > > > > > ---
> > > > > > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> > > > > > > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> > > > > > > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > > > > > > 3 files changed, 3 deletions(-)
> > > > > > >
> > > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > > index 8da09bd86d..516cde1145 100644
> > > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > > @@ -184,7 +184,6 @@
> > > > > > > .align 16
> > > > > > > .type STRCMP, @function
> > > > > > > .globl STRCMP
> > > > > > > - .hidden STRCMP
> > > > > >
> > > > > > Hi Noah,
> > > > > >
> > > > > > Why aren't ENTRY/END used on STRCMP?
> > > > > >
> > > > >
> > > > > Not sure, I copied sse42 when doing avx2/evex.
> > > > >
> > > > > > > # ifndef GLABEL
> > > > > > > # define GLABEL(...) __VA_ARGS__
> > > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > > index 2a5b3ce037..e97d51bb26 100644
> > > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > > @@ -214,7 +214,6 @@
> > > > > > > .align 16
> > > > > > > .type STRCMP, @function
> > > > > > > .globl STRCMP
> > > > > > > - .hidden STRCMP
> > > > > > >
> > > > > > > # ifdef USE_AS_STRCASECMP_L
> > > > > > > ENTRY (STRCASECMP)
> > > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > > index a9178ad25c..60313c647a 100644
> > > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > > @@ -77,7 +77,6 @@
> > > > > > > .align 16
> > > > > > > .type STRCMP_SSE42, @function
> > > > > > > .globl STRCMP_SSE42
> > > > > > > - .hidden STRCMP_SSE42
> > > > > > > #ifdef USE_AS_STRCASECMP_L
> > > > > > > ENTRY (GLABEL(__strcasecmp))
> > > > > > > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > > > > > > --
> > > > > > > 2.36.1
> > > > > > >
> > > > > >
> > > >
> > > > Do you need to do strcmp-sse2.S?
> > >
> > > There is no strcmp-sse2.S on master branch.
> >
> > Can we rebase this ontop of my patches?
> > Between the "move stuff" and isa raising?
>
> It should be fixed on master branch first. We don't need
>
> # ifdef USE_MULTIARCH
> .hidden STRCMP
> # endif
>
> It isn't necessary.
Okay.
>
> --
> H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
2022-07-08 0:00 ` Noah Goldstein
@ 2022-07-08 0:05 ` H.J. Lu
2022-07-08 0:09 ` Noah Goldstein
0 siblings, 1 reply; 11+ messages in thread
From: H.J. Lu @ 2022-07-08 0:05 UTC (permalink / raw)
To: Noah Goldstein; +Cc: GNU C Library
On Thu, Jul 7, 2022 at 5:00 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 4:58 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Thu, Jul 7, 2022 at 4:54 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > On Thu, Jul 7, 2022 at 4:52 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > >
> > > > On Thu, Jul 7, 2022 at 4:47 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > > > >
> > > > > On Thu, Jul 7, 2022 at 4:45 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > > > > >
> > > > > > On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > > > >
> > > > > > > On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > > > > >
> > > > > > > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > > > > > > > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > > > > > > > ---
> > > > > > > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> > > > > > > > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> > > > > > > > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > > > > > > > 3 files changed, 3 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > > > index 8da09bd86d..516cde1145 100644
> > > > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > > > @@ -184,7 +184,6 @@
> > > > > > > > .align 16
> > > > > > > > .type STRCMP, @function
> > > > > > > > .globl STRCMP
> > > > > > > > - .hidden STRCMP
> > > > > > >
> > > > > > > Hi Noah,
> > > > > > >
> > > > > > > Why aren't ENTRY/END used on STRCMP?
> > > > > > >
> > > > > >
> > > > > > Not sure, I copied sse42 when doing avx2/evex.
> > > > > >
> > > > > > > > # ifndef GLABEL
> > > > > > > > # define GLABEL(...) __VA_ARGS__
> > > > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > > > index 2a5b3ce037..e97d51bb26 100644
> > > > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > > > @@ -214,7 +214,6 @@
> > > > > > > > .align 16
> > > > > > > > .type STRCMP, @function
> > > > > > > > .globl STRCMP
> > > > > > > > - .hidden STRCMP
> > > > > > > >
> > > > > > > > # ifdef USE_AS_STRCASECMP_L
> > > > > > > > ENTRY (STRCASECMP)
> > > > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > > > index a9178ad25c..60313c647a 100644
> > > > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > > > @@ -77,7 +77,6 @@
> > > > > > > > .align 16
> > > > > > > > .type STRCMP_SSE42, @function
> > > > > > > > .globl STRCMP_SSE42
> > > > > > > > - .hidden STRCMP_SSE42
> > > > > > > > #ifdef USE_AS_STRCASECMP_L
> > > > > > > > ENTRY (GLABEL(__strcasecmp))
> > > > > > > > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > > > > > > > --
> > > > > > > > 2.36.1
> > > > > > > >
> > > > > > >
> > > > >
> > > > > Do you need to do strcmp-sse2.S?
> > > >
> > > > There is no strcmp-sse2.S on master branch.
> > >
> > > Can we rebase this ontop of my patches?
> > > Between the "move stuff" and isa raising?
> >
> > It should be fixed on master branch first. We don't need
> >
> > # ifdef USE_MULTIARCH
> > .hidden STRCMP
> > # endif
> >
> > It isn't necessary.
>
> Okay.
I am checking it in.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
2022-07-08 0:05 ` H.J. Lu
@ 2022-07-08 0:09 ` Noah Goldstein
0 siblings, 0 replies; 11+ messages in thread
From: Noah Goldstein @ 2022-07-08 0:09 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
On Thu, Jul 7, 2022 at 5:06 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 5:00 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Thu, Jul 7, 2022 at 4:58 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Thu, Jul 7, 2022 at 4:54 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > > >
> > > > On Thu, Jul 7, 2022 at 4:52 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > >
> > > > > On Thu, Jul 7, 2022 at 4:47 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > > > > >
> > > > > > On Thu, Jul 7, 2022 at 4:45 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > > > > > >
> > > > > > > On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > > > > >
> > > > > > > > On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > > > > > >
> > > > > > > > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > > > > > > > > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > > > > > > > > ---
> > > > > > > > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> > > > > > > > > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> > > > > > > > > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > > > > > > > > 3 files changed, 3 deletions(-)
> > > > > > > > >
> > > > > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > > > > index 8da09bd86d..516cde1145 100644
> > > > > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > > > > > > @@ -184,7 +184,6 @@
> > > > > > > > > .align 16
> > > > > > > > > .type STRCMP, @function
> > > > > > > > > .globl STRCMP
> > > > > > > > > - .hidden STRCMP
> > > > > > > >
> > > > > > > > Hi Noah,
> > > > > > > >
> > > > > > > > Why aren't ENTRY/END used on STRCMP?
> > > > > > > >
> > > > > > >
> > > > > > > Not sure, I copied sse42 when doing avx2/evex.
> > > > > > >
> > > > > > > > > # ifndef GLABEL
> > > > > > > > > # define GLABEL(...) __VA_ARGS__
> > > > > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > > > > index 2a5b3ce037..e97d51bb26 100644
> > > > > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > > > > > > @@ -214,7 +214,6 @@
> > > > > > > > > .align 16
> > > > > > > > > .type STRCMP, @function
> > > > > > > > > .globl STRCMP
> > > > > > > > > - .hidden STRCMP
> > > > > > > > >
> > > > > > > > > # ifdef USE_AS_STRCASECMP_L
> > > > > > > > > ENTRY (STRCASECMP)
> > > > > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > > > > index a9178ad25c..60313c647a 100644
> > > > > > > > > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > > > > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > > > > > > @@ -77,7 +77,6 @@
> > > > > > > > > .align 16
> > > > > > > > > .type STRCMP_SSE42, @function
> > > > > > > > > .globl STRCMP_SSE42
> > > > > > > > > - .hidden STRCMP_SSE42
> > > > > > > > > #ifdef USE_AS_STRCASECMP_L
> > > > > > > > > ENTRY (GLABEL(__strcasecmp))
> > > > > > > > > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > > > > > > > > --
> > > > > > > > > 2.36.1
> > > > > > > > >
> > > > > > > >
> > > > > >
> > > > > > Do you need to do strcmp-sse2.S?
> > > > >
> > > > > There is no strcmp-sse2.S on master branch.
> > > >
> > > > Can we rebase this ontop of my patches?
> > > > Between the "move stuff" and isa raising?
> > >
> > > It should be fixed on master branch first. We don't need
> > >
> > > # ifdef USE_MULTIARCH
> > > .hidden STRCMP
> > > # endif
> > >
> > > It isn't necessary.
> >
> > Okay.
>
> I am checking it in.
>
Yup,
LGTM.
> Thanks.
>
> --
> H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-07-08 0:09 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-07 23:39 [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S H.J. Lu
2022-07-07 23:42 ` H.J. Lu
2022-07-07 23:45 ` Noah Goldstein
2022-07-07 23:47 ` Noah Goldstein
2022-07-07 23:51 ` H.J. Lu
2022-07-07 23:54 ` Noah Goldstein
2022-07-07 23:57 ` H.J. Lu
2022-07-08 0:00 ` Noah Goldstein
2022-07-08 0:05 ` H.J. Lu
2022-07-08 0:09 ` Noah Goldstein
2022-07-07 23:54 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).