From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] nptl: Remove set*id, set*gid files which are not built
Date: Mon, 14 Dec 2020 03:49:45 -0800 [thread overview]
Message-ID: <CAMe9rOo3kZN2RqD7Dzza-Xw69v8mvO4B5HU2yZxFt7Srcvc+MA@mail.gmail.com> (raw)
In-Reply-To: <87k0tkeqk1.fsf@oldenburg2.str.redhat.com>
On Mon, Dec 14, 2020 at 12:32 AM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> ---
> nptl/Makefile | 4 ----
> nptl/pthread_setegid.c | 3 ---
> nptl/pthread_seteuid.c | 3 ---
> nptl/pthread_setgid.c | 3 ---
> nptl/pthread_setregid.c | 3 ---
> nptl/pthread_setresgid.c | 3 ---
> nptl/pthread_setresuid.c | 3 ---
> nptl/pthread_setreuid.c | 3 ---
> nptl/pthread_setuid.c | 3 ---
> 9 files changed, 28 deletions(-)
>
> diff --git a/nptl/Makefile b/nptl/Makefile
> index ddd83dfbdd..491768ce6e 100644
> --- a/nptl/Makefile
> +++ b/nptl/Makefile
> @@ -169,10 +169,6 @@ libpthread-routines = nptl-init nptlfreeres vars events version pt-interp \
> pthread_setattr_default_np pthread_getattr_default_np \
> pthread_mutex_conf \
> libpthread-compat
> -# pthread_setuid pthread_seteuid pthread_setreuid \
> -# pthread_setresuid \
> -# pthread_setgid pthread_setegid pthread_setregid \
> -# pthread_setresgid
>
> libpthread-shared-only-routines = version pt-interp pt-allocrtsig \
> unwind-forcedunwind
> diff --git a/nptl/pthread_setegid.c b/nptl/pthread_setegid.c
> deleted file mode 100644
> index 9252dfac7d..0000000000
> --- a/nptl/pthread_setegid.c
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#define SINGLE_THREAD
> -#define setegid pthread_setegid_np
> -#include <setegid.c>
> diff --git a/nptl/pthread_seteuid.c b/nptl/pthread_seteuid.c
> deleted file mode 100644
> index 47bb698025..0000000000
> --- a/nptl/pthread_seteuid.c
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#define SINGLE_THREAD
> -#define seteuid pthread_seteuid_np
> -#include <seteuid.c>
> diff --git a/nptl/pthread_setgid.c b/nptl/pthread_setgid.c
> deleted file mode 100644
> index b06bffbf32..0000000000
> --- a/nptl/pthread_setgid.c
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#define SINGLE_THREAD
> -#define __setgid pthread_setgid_np
> -#include <setgid.c>
> diff --git a/nptl/pthread_setregid.c b/nptl/pthread_setregid.c
> deleted file mode 100644
> index 7461d2b7fd..0000000000
> --- a/nptl/pthread_setregid.c
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#define SINGLE_THREAD
> -#define __setregid pthread_setregid_np
> -#include <setregid.c>
> diff --git a/nptl/pthread_setresgid.c b/nptl/pthread_setresgid.c
> deleted file mode 100644
> index 369fae2672..0000000000
> --- a/nptl/pthread_setresgid.c
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#define SINGLE_THREAD
> -#define __setresgid pthread_setresgid_np
> -#include <setresgid.c>
> diff --git a/nptl/pthread_setresuid.c b/nptl/pthread_setresuid.c
> deleted file mode 100644
> index ac57c0fa8d..0000000000
> --- a/nptl/pthread_setresuid.c
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#define SINGLE_THREAD
> -#define __setresuid pthread_setresuid_np
> -#include <setresuid.c>
> diff --git a/nptl/pthread_setreuid.c b/nptl/pthread_setreuid.c
> deleted file mode 100644
> index aa804ab01d..0000000000
> --- a/nptl/pthread_setreuid.c
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#define SINGLE_THREAD
> -#define __setreuid pthread_setreuid_np
> -#include <setreuid.c>
> diff --git a/nptl/pthread_setuid.c b/nptl/pthread_setuid.c
> deleted file mode 100644
> index ff949c850f..0000000000
> --- a/nptl/pthread_setuid.c
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#define SINGLE_THREAD
> -#define __setuid pthread_setuid_np
> -#include <setuid.c>
LGTM.
Thanks.
--
H.J.
prev parent reply other threads:[~2020-12-14 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 8:32 Florian Weimer
2020-12-14 11:49 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOo3kZN2RqD7Dzza-Xw69v8mvO4B5HU2yZxFt7Srcvc+MA@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).