From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by sourceware.org (Postfix) with ESMTPS id 652013892009 for ; Mon, 14 Dec 2020 12:32:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 652013892009 Received: by mail-oi1-x241.google.com with SMTP id x13so9875439oic.5 for ; Mon, 14 Dec 2020 04:32:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4YP9VAqhkPMVvGlziM/TLqSqMJonEy17+4qPCYeFF9c=; b=Vo9r+B78SVEeolmf5QtLs1neAswTrcyM8942MMYep/NZ43AaP4S4VFoJW+IdGMnkpl NEWPh89LqOm5Gj01Fmm6jURlr4UDxGLpwcM1Ie0Snz3tjgiejYRdlPsZX6nbOsJcfHQI EPibADL8ByTMshfIguaYKz8mBRjijfnAWcYuCg5cxs5wopTY410wllGzv3iwS3UIGVAq xLZAidHHVzhVfXD2tGdY0ICAXJVobOsn7kb5+/ayWKJpDwshZJlbTt5rkbE3gMdbpIxe 9WCBNj+vr5xmR271xnkOPbo+TGPqkgO4D+xx/g/xFgOgjpwDGRWr6lJRLTV3nXgNAI2O 40cg== X-Gm-Message-State: AOAM533FzspTBY2ZijmUFlAueD7eXhvUkhNTS30cQomNViNmePp1JXbO uKl1zAUYjQzBLDgyw26elmtTzgJ1R7rM0+GJffx5yFUW X-Google-Smtp-Source: ABdhPJxTtVQRdCEKmiRuCSRQnKUToZp8CYuGmKVBggqN0G1yq5coKJ1c3TVss4V+CDixXu7FoegPEjjTNTBqToKjWpo= X-Received: by 2002:aca:f5d3:: with SMTP id t202mr17969195oih.25.1607949113664; Mon, 14 Dec 2020 04:31:53 -0800 (PST) MIME-Version: 1.0 References: <87k0tkeqk1.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87k0tkeqk1.fsf@oldenburg2.str.redhat.com> From: "H.J. Lu" Date: Mon, 14 Dec 2020 03:49:45 -0800 Message-ID: Subject: Re: [PATCH] nptl: Remove set*id, set*gid files which are not built To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3035.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2020 12:32:03 -0000 On Mon, Dec 14, 2020 at 12:32 AM Florian Weimer via Libc-alpha wrote: > > --- > nptl/Makefile | 4 ---- > nptl/pthread_setegid.c | 3 --- > nptl/pthread_seteuid.c | 3 --- > nptl/pthread_setgid.c | 3 --- > nptl/pthread_setregid.c | 3 --- > nptl/pthread_setresgid.c | 3 --- > nptl/pthread_setresuid.c | 3 --- > nptl/pthread_setreuid.c | 3 --- > nptl/pthread_setuid.c | 3 --- > 9 files changed, 28 deletions(-) > > diff --git a/nptl/Makefile b/nptl/Makefile > index ddd83dfbdd..491768ce6e 100644 > --- a/nptl/Makefile > +++ b/nptl/Makefile > @@ -169,10 +169,6 @@ libpthread-routines = nptl-init nptlfreeres vars events version pt-interp \ > pthread_setattr_default_np pthread_getattr_default_np \ > pthread_mutex_conf \ > libpthread-compat > -# pthread_setuid pthread_seteuid pthread_setreuid \ > -# pthread_setresuid \ > -# pthread_setgid pthread_setegid pthread_setregid \ > -# pthread_setresgid > > libpthread-shared-only-routines = version pt-interp pt-allocrtsig \ > unwind-forcedunwind > diff --git a/nptl/pthread_setegid.c b/nptl/pthread_setegid.c > deleted file mode 100644 > index 9252dfac7d..0000000000 > --- a/nptl/pthread_setegid.c > +++ /dev/null > @@ -1,3 +0,0 @@ > -#define SINGLE_THREAD > -#define setegid pthread_setegid_np > -#include > diff --git a/nptl/pthread_seteuid.c b/nptl/pthread_seteuid.c > deleted file mode 100644 > index 47bb698025..0000000000 > --- a/nptl/pthread_seteuid.c > +++ /dev/null > @@ -1,3 +0,0 @@ > -#define SINGLE_THREAD > -#define seteuid pthread_seteuid_np > -#include > diff --git a/nptl/pthread_setgid.c b/nptl/pthread_setgid.c > deleted file mode 100644 > index b06bffbf32..0000000000 > --- a/nptl/pthread_setgid.c > +++ /dev/null > @@ -1,3 +0,0 @@ > -#define SINGLE_THREAD > -#define __setgid pthread_setgid_np > -#include > diff --git a/nptl/pthread_setregid.c b/nptl/pthread_setregid.c > deleted file mode 100644 > index 7461d2b7fd..0000000000 > --- a/nptl/pthread_setregid.c > +++ /dev/null > @@ -1,3 +0,0 @@ > -#define SINGLE_THREAD > -#define __setregid pthread_setregid_np > -#include > diff --git a/nptl/pthread_setresgid.c b/nptl/pthread_setresgid.c > deleted file mode 100644 > index 369fae2672..0000000000 > --- a/nptl/pthread_setresgid.c > +++ /dev/null > @@ -1,3 +0,0 @@ > -#define SINGLE_THREAD > -#define __setresgid pthread_setresgid_np > -#include > diff --git a/nptl/pthread_setresuid.c b/nptl/pthread_setresuid.c > deleted file mode 100644 > index ac57c0fa8d..0000000000 > --- a/nptl/pthread_setresuid.c > +++ /dev/null > @@ -1,3 +0,0 @@ > -#define SINGLE_THREAD > -#define __setresuid pthread_setresuid_np > -#include > diff --git a/nptl/pthread_setreuid.c b/nptl/pthread_setreuid.c > deleted file mode 100644 > index aa804ab01d..0000000000 > --- a/nptl/pthread_setreuid.c > +++ /dev/null > @@ -1,3 +0,0 @@ > -#define SINGLE_THREAD > -#define __setreuid pthread_setreuid_np > -#include > diff --git a/nptl/pthread_setuid.c b/nptl/pthread_setuid.c > deleted file mode 100644 > index ff949c850f..0000000000 > --- a/nptl/pthread_setuid.c > +++ /dev/null > @@ -1,3 +0,0 @@ > -#define SINGLE_THREAD > -#define __setuid pthread_setuid_np > -#include LGTM. Thanks. -- H.J.