From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126959 invoked by alias); 11 Mar 2016 22:41:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 126948 invoked by uid 89); 11 Mar 2016 22:41:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_BADIPHTTP,NORMAL_HTTP_TO_IP,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=4711, rolandhackfrobcom, roland@hack.frob.com, 477 X-HELO: mail-qg0-f50.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=4VLu0/cru+DYhOM2ajaPuadWuBJtj3g2gwo5/PtI3aM=; b=DZMyBHR6Y5JD19qM1gfII50HuNTAPjloUoH6poqWpeJakSUiIJYBs+39yqO5Q2bUgn iFJ+jx0g5q3uZqZo9VR/nd5q8jcc3C3pW/XT7qzc6dvNvFi485osq1ZF3t4Q5UUAR/06 +t6Ebx0tIf2vr+YiXdzuWNBScI+wg3dM87C1qtFUvYgpblZURHuUIOaNi695wc6nFlNK omfzDORYaZLlY70toYqOEpM5+dG1I7nu/FMmVtfDruXtaWhGDoH2V0zSaw57NB6RL3hj +ucB2XPVjhz23ICklASjpCP/6uHPfESqsPcjKCgWvghBLJC3L3LJfL2vPddd7YGYryLy n26Q== X-Gm-Message-State: AD7BkJLVQB/bV95mOnaWwJzVHwGTQHDiiHy8RMirvB2IHRdhlZOhHT+uBYRbazBdYcpFNZS0qeNn+jQetqAgDg== MIME-Version: 1.0 X-Received: by 10.140.19.52 with SMTP id 49mr15049244qgg.103.1457736063813; Fri, 11 Mar 2016 14:41:03 -0800 (PST) In-Reply-To: <20160311222939.654342C3C24@topped-with-meat.com> References: <1457049161-13783-1-git-send-email-hjl.tools@gmail.com> <20160311214735.4CAE52C3C21@topped-with-meat.com> <20160311220031.3A5672C3BC5@topped-with-meat.com> <20160311222939.654342C3C24@topped-with-meat.com> Date: Fri, 11 Mar 2016 22:41:00 -0000 Message-ID: Subject: Re: [PATCH 1/2] Add _arch_/_cpu_ to index_*/bit_* in x86 cpu-features.h From: "H.J. Lu" To: Roland McGrath , Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2016-03/txt/msg00361.txt.bz2 On Fri, Mar 11, 2016 at 2:29 PM, Roland McGrath wrot= e: >> On Fri, Mar 11, 2016 at 2:00 PM, Roland McGrath w= rote: >> >> Sorry I didn't mention that I tested it on both x86-64 and i686 before >> >> commit. >> > >> > But clearly you didn't! The tree right now is broken, as I said. >> >> I double checked again with >> >> commit 6aa3e97e2530f9917f504eb4146af119a3f27229 >> Author: H.J. Lu >> Date: Thu Mar 10 05:26:46 2016 -0800 >> >> Add _arch_/_cpu_ to index_*/bit_* in x86 cpu-features.h >> >> on x86-64 and i686. I only see: >> >> [hjl@gnu-6 build-i686-linux]$ ./nptl/tst-cleanupx4 >> test 0 >> clh (1) >> clh (2) >> clh (3) >> test 1 >> clh (1) >> clh (4) >> clh (5) >> clh (6) >> test 2 >> clh (7) >> clh (8) >> global =3D 64, expected 120 >> test 3 >> clh (1) >> clh (2) >> clh (9) >> clh (10) >> [hjl@gnu-6 build-i686-linux]$ >> >> Did you remove the old build directory? > > http://130.211.48.148:8080/builders/glibc-x86_64-linux/builds/1125/steps/= check%20%28clobber%29/logs/stdio The error is ../sysdeps/x86_64/tst-audit10.c: In function =E2=80=98avx512_enabled=E2=80= =99: ../sysdeps/x86_64/tst-audit10.c:34:15: error: =E2=80=98bit_AVX512F=E2=80=99= undeclared (first use in this function) if (!(ebx & bit_AVX512F)) which is changed by ommit 3c0f7407eedb524c9114bb675cd55b903c71daaa Author: Florian Weimer Date: Mon Mar 7 16:00:25 2016 +0100 tst-audit4, tst-audit10: Compile AVX/AVX-512 code separately [BZ #19269] This ensures that GCC will not use unsupported instructions before the run-time check to ensure support. bit_AVX512F is defined in from GCC. Apparently, your GCC doesn't have it. You can try this patch. --=20 H.J. --- diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile index aa4a754..2525cc1 100644 --- a/sysdeps/x86_64/Makefile +++ b/sysdeps/x86_64/Makefile @@ -47,7 +47,11 @@ tests-pie +=3D $(quad-pie-test) $(objpfx)tst-quad1pie: $(objpfx)tst-quadmod1pie.o $(objpfx)tst-quad2pie: $(objpfx)tst-quadmod2pie.o -tests +=3D tst-audit3 tst-audit4 tst-audit5 tst-audit6 tst-audit7 tst-audi= t10 +tests +=3D tst-audit3 tst-audit4 tst-audit5 tst-audit6 tst-audit7 + +ifeq (yes,$(config-cflags-avx512)) +tests +=3D tst-audit10 +endif tests +=3D tst-split-dynreloc LDFLAGS-tst-split-dynreloc =3D -Wl,-T,$(..)sysdeps/x86_64/tst-split-dynrel= oc.lds