* [PATCH] powerpc: Remove duplicated llrintf and llrintf32 from libm.a (BZ 31787)
@ 2024-05-22 14:49 Adhemerval Zanella
2024-05-22 15:13 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: Adhemerval Zanella @ 2024-05-22 14:49 UTC (permalink / raw)
To: libc-alpha; +Cc: H . J . Lu
Both the generic and POWER6 versions provide definitions of the
symbol, which are already provided by the ifunc resolver.
Checked on powerpc-linux-gnu-power4.
---
.../powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c | 4 ++++
.../powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
index 5b1a5a8cf0..3c279ddd1a 100644
--- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
+++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
@@ -1,2 +1,6 @@
+#include <libm-alias-float.h>
+
#define __llrintf __llrintf_power6
+#undef libm_alias_float
+#define libm_alias_float(a, b)
#include <sysdeps/powerpc/powerpc32/fpu/s_llrintf.c>
diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
index 061962b84d..bce8f4564f 100644
--- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
+++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
@@ -1,2 +1,6 @@
+#include <libm-alias-float.h>
+
#define __llrintf __llrintf_ppc32
+#undef libm_alias_float
+#define libm_alias_float(a, b)
#include <sysdeps/powerpc/powerpc32/fpu/s_llrintf.c>
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: Remove duplicated llrintf and llrintf32 from libm.a (BZ 31787)
2024-05-22 14:49 [PATCH] powerpc: Remove duplicated llrintf and llrintf32 from libm.a (BZ 31787) Adhemerval Zanella
@ 2024-05-22 15:13 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2024-05-22 15:13 UTC (permalink / raw)
To: Adhemerval Zanella; +Cc: libc-alpha
On Wed, May 22, 2024 at 7:49 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> Both the generic and POWER6 versions provide definitions of the
> symbol, which are already provided by the ifunc resolver.
>
> Checked on powerpc-linux-gnu-power4.
> ---
> .../powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c | 4 ++++
> .../powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
> index 5b1a5a8cf0..3c279ddd1a 100644
> --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
> +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
> @@ -1,2 +1,6 @@
> +#include <libm-alias-float.h>
> +
> #define __llrintf __llrintf_power6
> +#undef libm_alias_float
> +#define libm_alias_float(a, b)
> #include <sysdeps/powerpc/powerpc32/fpu/s_llrintf.c>
> diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
> index 061962b84d..bce8f4564f 100644
> --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
> +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
> @@ -1,2 +1,6 @@
> +#include <libm-alias-float.h>
> +
> #define __llrintf __llrintf_ppc32
> +#undef libm_alias_float
> +#define libm_alias_float(a, b)
> #include <sysdeps/powerpc/powerpc32/fpu/s_llrintf.c>
> --
> 2.43.0
>
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-22 15:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-22 14:49 [PATCH] powerpc: Remove duplicated llrintf and llrintf32 from libm.a (BZ 31787) Adhemerval Zanella
2024-05-22 15:13 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).