From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by sourceware.org (Postfix) with ESMTPS id C2FDB3858D20 for ; Mon, 1 Apr 2024 13:17:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2FDB3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C2FDB3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711977472; cv=none; b=MNUfXsMBCxYK6WQ/xsg39zz8+WnlA5JGrPUk7PpFBZ0puD/7YvWW21tVKIU/gTbUQSGKRoA2Oa7gtM9Tj4aRCzcej5nPpvCLoT1nJ8sIZlgo0qSLXtcnvNcVKWzOKDlwAC8aYY0yrLa0aES0taFHN45g3y22mdTWQ4ctuIcu8Rw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711977472; c=relaxed/simple; bh=suPZb2hvmWL78WhuT639Hcm99uDjnIN96xJqniWAlv4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=HvoEt9RQTL4RRSQUS15uA6yJL/CmJTrL02GQB2lS4ozxGPCxbma7lP96gBrAIPJK55zjsHqkhCLSIFEqd4doATqnMkKCk7ywgWSL55XuQQe5K2Y4xz0pjlLKVrUMyLNX82yrXOwgrQsucXNFETCQD8AN0BXVd0+b587F0ZH7Xgk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-6147942ae18so17393547b3.2 for ; Mon, 01 Apr 2024 06:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711977470; x=1712582270; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z4SJ58LXBZQJD8EfQzCTbx3m43BCYuQOQ5rYhLglR+c=; b=KWjP9+bGWsZVabY/NvhKFFRRdh/FV1TQWkZ0UTIHzqWlMtEqKJEGjptRRPhDzmhtjA uG6flgm/R66yJYLNbFhPZkFF7OdCFh2Vqoydy+/GFP/eb17EToH7EtsfgnosM+0pWlEK +mc+CVN8QO+KLEfJgsdgssYDxeb9XZOeqdkYzNJUQUbBkAlVOXyzYEsxFva4KB/siiM7 RVuq9zKATvxtp9JR9gVZyEDsgLHbP2jdwk+LcesCHDc3xF/j552OZXQxVMeFzyu5MZ7k 5QL8j10ar5IjiyCOfp1yovwFDrIUZSTuSclNxhJWThyOuOQWC8xnJJkiQWD6HOwCa67Z yMWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711977470; x=1712582270; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z4SJ58LXBZQJD8EfQzCTbx3m43BCYuQOQ5rYhLglR+c=; b=lauP+iV5Vb9OxD3LB0O1kUFMQMxfWYWnWoaAOx3gS0vughN0vddJg0u9GAz+j/twAH 5Psy5UMXalTv7F31YdD8lSmdxBtXW+6kB5D0Q4/YLPD2qn6y1RHhG1DsLLWl1y1A0O9J QTYAu5eoR9YUiuB1y06fget6QCRdDdmqnkncXfzrXEn0psk/wDkQUF6fWty6ULkt0jtl y5QpuAm1cVciknNEfgMjlpFIZw32F5W34MX8oF0PGQJ0OdY8f0okZ9CfqTaMYTApaYb7 QnLa+XD1FAajTe8oXneKavBGLYbesNuOkkvcf4/lxdLrFFwbbWlo14ayjsFKrRxXX7mS dubQ== X-Forwarded-Encrypted: i=1; AJvYcCV7TYJlGl1+wxdHTig8mObn0/uRQ4Lw6BJNoem1cJTmqgGtJn9ld2fbmSG1LU5P+2JKM+djddmSDfjEZYl0jkTkp7/35beUaJm0 X-Gm-Message-State: AOJu0YxdWmnzLZ6+qcz5+PChv0C3lcLwlxLHTx/CREDCcHkR5Ub35v7H 6owN8ami78m/9QMIXw0jGrvnu+c74iUjHGBY14QLzIjIvCIcAPXaMy2MBcG6zHw7t5Rhks0E+oh SC3WfwADLD9baptEsw2u5NVjF2ZE= X-Google-Smtp-Source: AGHT+IEWu/7Lunh9pzRUayEs8CULHRIYYkL/+FPoy3fDqZdXeqrNOvtl73fBe38EyqzaxQbLeCLQvK02f0Gwg7GJ4l4= X-Received: by 2002:a81:4ecc:0:b0:611:9f44:3d4c with SMTP id c195-20020a814ecc000000b006119f443d4cmr8646663ywb.12.1711977468564; Mon, 01 Apr 2024 06:17:48 -0700 (PDT) MIME-Version: 1.0 References: <87plv91b22.fsf@oldenburg3.str.redhat.com> In-Reply-To: <87plv91b22.fsf@oldenburg3.str.redhat.com> From: "H.J. Lu" Date: Mon, 1 Apr 2024 06:17:12 -0700 Message-ID: Subject: Re: [PATCH] stdlib: reorganize stdlib Makefile routines by functionality To: Florian Weimer Cc: abush wang , abushwang via Libc-alpha , adhemerval.zanella@linaro.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 1, 2024 at 6:13=E2=80=AFAM Florian Weimer = wrote: > > * abush wang: > > > This is test: > > ``` > > uint64_t getnsecs() { > > uint32_t lo, hi; > > __asm__ __volatile__ ( > > "rdtsc" : "=3Da"(lo), "=3Dd"(hi) > > ); > > return ((uint64_t)hi << 32) | lo; > > } > > > > int main() { > > const int num_iterations =3D 1; > > uint64_t start, end, total_time =3D 0; > > > > start =3D getnsecs(); > > for (int i =3D 0; i < num_iterations; i++) { > > (void) lrand48(); > > } > > end =3D getnsecs(); > > total_time +=3D (end - start); > > > > printf("Average time for lrand48: %lu cycles\n", total_time / num_i= terations); > > return 0; > > } > > ``` > > before: > > Average time for lrand48: 21418 cycles > > > > after: > > Average time for lrand48: 9892 cycles > > Do you see this on x86-64? So this isn't a displacement range issue? > > It could be that this is a random performance change due to code > alignment, and not actually caused by the direct call distance. > I have a linker patch to control section layout: https://patchwork.sourceware.org/project/binutils/list/?series=3D29973 It can 1. Reduce gaps between text sections. 2. Put hot text sections close to each other. If it can solve this issue, we should add this feature to ld. --=20 H.J.