From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by sourceware.org (Postfix) with ESMTPS id 9A7D43858401 for ; Thu, 1 Jun 2023 15:55:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A7D43858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-565c3aa9e82so10821077b3.2 for ; Thu, 01 Jun 2023 08:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685634909; x=1688226909; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xB645x9/AFmyM1voO7/Z3DCD2AhjlES1Fgu6wAPlwyI=; b=DKNr4k1HzxSosARUv4ErrQWHlEEeRBmHCm5jWCyxaSbjVb4tBQ3AGHPf0ndfU7WTIt 6pZ/Z68agCQ8QDo6IyTLT01hlO98Lc/4/Vq1EZHuLqcVHGzCE3GQoFbCA64RnbAQ4pdM caYhwhx+mr40KwFnkJnJk7knxvWg1h/m6xfjlfQc938p5WNPzKAr6AtJWG2/IX3xItqT DBfTQJv8Wiwqmx/5UwublrCgQscKno8RsqHYzA6OlzdNyf/0/Tf/RbM90qixLX0/yWsP JP+r7ab2R27IufEocoyKpMYpOgwuFLEH7UZVgPiQ+deLIVucyp7AwNUeFjgWWOBVDUwC jdYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685634909; x=1688226909; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xB645x9/AFmyM1voO7/Z3DCD2AhjlES1Fgu6wAPlwyI=; b=J2ZWsXmDm2LdFazkaB+HXAIwQ9kwkKEYAN9bzxPd16yVCsJsykf6tSSUL87tKqv7R8 crLW0Ub6Bwg7QdFkMt00Bburuhy0GNy9pP4HdO4UWe/vV41HVFNhhRUs4PVvDEdhm/SA OQtXN5tJGlUoz4DQGxibqwZ/m8CvekBKIUn304Kvdug67KIs9KbAuBgpHWDqZIe2wO8Q +qfjUIn4qpnuCANmwZf0cB70qFfXce3/9ISzxZGXhLl1Sf9fhd5nc+vlT/PVi3nPBIPW w0IxxvCKB+6XjctosOCg/2vbLankSjSTvRznUWSEJs4iBeqBxYtTnCWA+xyEcC/mOlRu 316w== X-Gm-Message-State: AC+VfDzd+djgAOs09HUQIPBBQ3btZGSX2ZS2jiimT6fqbzx0dm1XWhu9 F1vkDilzK7ke59x4It0tkz9xxeUztHq8nApvKGZGTav0 X-Google-Smtp-Source: ACHHUZ4sKVeoOUoDB8iThzRqTa6lCieEjX/qphQlvXr5SXPKLBJKHfhau8nkH/zf2yNRr09kPefVJEijETAA5DKJmpg= X-Received: by 2002:a0d:e6d0:0:b0:561:be3f:ae2c with SMTP id p199-20020a0de6d0000000b00561be3fae2cmr9880768ywe.40.1685634907890; Thu, 01 Jun 2023 08:55:07 -0700 (PDT) MIME-Version: 1.0 References: <20230601034314.69375-1-hjl.tools@gmail.com> <87pm6f20zu.fsf@oldenburg.str.redhat.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 1 Jun 2023 08:54:31 -0700 Message-ID: Subject: Re: [PATCH] x86-64: Use YMM registers in memcmpeq-evex.S To: Noah Goldstein Cc: Florian Weimer , "H.J. Lu via Libc-alpha" , Sunil K Pandey Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3021.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jun 1, 2023 at 8:44=E2=80=AFAM Noah Goldstein wrote: > > On Thu, Jun 1, 2023 at 12:41=E2=80=AFAM Florian Weimer wrote: > > > > * H. J. Lu via Libc-alpha: > > > > > Include x86-evex256-vecs.h by default to use YMM registers in > > > memcmpeq-evex.S. > > Should we create an evex512 impl? YMM is good enough for now. There is no need for ZMM. > > > --- > > > sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_6= 4/multiarch/memcmpeq-evex.S > > > index 3666f649cd..7eefff77f1 100644 > > > --- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S > > > +++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S > > > @@ -42,7 +42,7 @@ > > > # endif > > > > > > # ifndef VEC_SIZE > > > -# include "x86-evex512-vecs.h" > > > +# include "x86-evex256-vecs.h" > > > # endif > > > # include "reg-macros.h" > > > > It would be nice if the commit message could describe the why, not just > > the what. 8-) > > > > We use -evex.S postfix for 256-bit evex. This was mistakenly implemented = as > evex512. > > > > Thanks, > > Florian > > --=20 H.J.