From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458]
Date: Fri, 27 Jul 2018 21:41:00 -0000 [thread overview]
Message-ID: <CAMe9rOoGhWwEeKAyX09go4L4mWPTVfnZ-CZObaUNB8DkVkd0Dw@mail.gmail.com> (raw)
In-Reply-To: <eaf8c7a9-fdc1-8d61-1cb7-bf168f0ef084@redhat.com>
On Fri, Jul 27, 2018 at 2:14 PM, Florian Weimer <fweimer@redhat.com> wrote:
> On 07/27/2018 10:38 PM, H.J. Lu wrote:
>>
>> -tests += tst-get-cpu-features
>> +# NB: All tests should be added to $(tests) and all static tests should
>> +# be added to $(tests-static).
>> +tests += tst-get-cpu-features tst-get-cpu-features-static
>
>
> Why the comment? What makes this instance so special to warrant one?
>
I can take out the comment.
--
H.J.
next prev parent reply other threads:[~2018-07-27 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 20:38 H.J. Lu
2018-07-27 21:14 ` Florian Weimer
2018-07-27 21:41 ` H.J. Lu [this message]
2018-07-29 14:20 ` V2 " H.J. Lu
2018-07-30 20:34 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoGhWwEeKAyX09go4L4mWPTVfnZ-CZObaUNB8DkVkd0Dw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).