From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by sourceware.org (Postfix) with ESMTPS id 098FB3857019 for ; Mon, 27 Jul 2020 19:17:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 098FB3857019 Received: by mail-io1-xd41.google.com with SMTP id l17so18176814iok.7 for ; Mon, 27 Jul 2020 12:17:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BlJhVUOSSTBu6ern1lML7tJcBNdJF1V2HMBpcnkCgyc=; b=GC3iBEb06Bvk4ZpyBEdtAjp63K1ufelKa9/Lf0TVLvBNeszRpgd8AjF1OTo6igR3DY 87iqT6A0z6fjOIbZRc/SVuyRj97Ul16DV78sc/O6VEyXTJkxTXyWIBx9adhN4ts1KYmL C3F1ihmOt+5q8AVTHGUKiCjjDF0u0BeLYDvzudbR6V6CFpLvZ/64EXtzmeV1A6KyFj0M q41q4cMYQFH9J2MMlYX9uShrmI2ZP59P84hu55fshnvJNuRCaFY2mmLqkSY9+XiwickD G+sBkDLfxmpk0BQR2rZhjTt+OaqL0GSeymUqsQryP3fBqoqOyrGpmPn/wG1z9rN0Jk+S 3G2Q== X-Gm-Message-State: AOAM533tt97JQxILTE+qvAj59KmeRBvWt2VGBoGNZuEWAfoHFmFzS2xG 8ek4S1qqS7Z7LR9ec67tNAK+Hk4py9cMqmwccIsV0IT8 X-Google-Smtp-Source: ABdhPJz5lGQOfKvyX+wh7RqvbWkhLh0kuPusfNY4ynx/cIHdkyczHkLhLd6KtIcMLsolewV7MS3wUJfB49g5cj8bvTU= X-Received: by 2002:a6b:bf85:: with SMTP id p127mr25477628iof.37.1595877470527; Mon, 27 Jul 2020 12:17:50 -0700 (PDT) MIME-Version: 1.0 References: <20200716112651.2257283-1-hjl.tools@gmail.com> <87o8ofy8e7.fsf@oldenburg2.str.redhat.com> <56cafa21-37ea-b39e-8c84-afb258f0d17a@redhat.com> <87sgdqp434.fsf@oldenburg2.str.redhat.com> <180ab9db-d012-52c9-736f-437eecafc35b@redhat.com> <91e0af7e-5f5c-a994-d7bf-dd94c45dcd71@redhat.com> <6276e59d-a363-32a8-10b1-5e19dc065d6d@redhat.com> <6396e998-af22-deaf-3127-257059f9f46b@redhat.com> <87y2n54hv4.fsf@oldenburg2.str.redhat.com> <87sgddup2z.fsf@oldenburg2.str.redhat.com> <878sf5ufek.fsf@oldenburg2.str.redhat.com> In-Reply-To: <878sf5ufek.fsf@oldenburg2.str.redhat.com> From: "H.J. Lu" Date: Mon, 27 Jul 2020 12:17:14 -0700 Message-ID: Subject: Re: V3 [PATCH] nptl: Zero-extend arguments to SETXID syscalls [BZ #26248] To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Content-Type: multipart/mixed; boundary="000000000000bca9e105ab712dfa" X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 19:17:52 -0000 --000000000000bca9e105ab712dfa Content-Type: text/plain; charset="UTF-8" On Mon, Jul 27, 2020 at 8:49 AM Florian Weimer wrote: > > * H. J. Lu via Libc-alpha: > > > + /* Enforce zero-extension for the pointer argument in > > + > > + int setgroups(size_t size, const gid_t *list); > > + > > + The kernel XID arguments are unsigned and do not require sign > > + extension. */ > > + unsigned long int id[3]; > > Maybe add the missing space before '('? Fixed. > Rest looks good to me for glibc 2.32. > This is the patch I am checking in. Thanks. -- H.J. --000000000000bca9e105ab712dfa Content-Type: text/x-patch; charset="US-ASCII"; name="0001-nptl-Zero-extend-arguments-to-SETXID-syscalls-BZ-262.patch" Content-Disposition: attachment; filename="0001-nptl-Zero-extend-arguments-to-SETXID-syscalls-BZ-262.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kd4w7cyy0 RnJvbSBlOTljYzZkYTkxM2I5NjI2NmRjZDIwNDAyZmJlZDRkNTBlMDYwZTNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IFRodSwgMTYgSnVsIDIwMjAgMDM6Mzc6MTAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBucHRsOiBa ZXJvLWV4dGVuZCBhcmd1bWVudHMgdG8gU0VUWElEIHN5c2NhbGxzIFtCWiAjMjYyNDhdCgpucHRs IGhhcwoKLyogT3Bjb2RlcyBhbmQgZGF0YSB0eXBlcyBmb3IgY29tbXVuaWNhdGlvbiB3aXRoIHRo ZSBzaWduYWwgaGFuZGxlciB0bwogICBjaGFuZ2UgdXNlci9ncm91cCBJRHMuICAqLwpzdHJ1Y3Qg eGlkX2NvbW1hbmQKewogIGludCBzeXNjYWxsX25vOwogIGxvbmcgaW50IGlkWzNdOwogIHZvbGF0 aWxlIGludCBjbnRyOwogIHZvbGF0aWxlIGludCBlcnJvcjsKfTsKCiAvKiBUaGlzIG11c3QgYmUg bGFzdCwgb3RoZXJ3aXNlIHRoZSBjdXJyZW50IHRocmVhZCBtaWdodCBub3QgaGF2ZQogICAgIHBl cm1pc3Npb25zIHRvIHNlbmQgU0lHU0VUWElEIHN5c2NhbGwgdG8gdGhlIG90aGVyIHRocmVhZHMu ICAqLwogIHJlc3VsdCA9IElOVEVSTkFMX1NZU0NBTExfTkNTIChjbWRwLT5zeXNjYWxsX25vLCAz LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjbWRwLT5pZFswXSwgY21kcC0+aWRb MV0sIGNtZHAtPmlkWzJdKTsKCkJ1dCB0aGUgc2Vjb25kIGFyZ3VtZW50IG9mIHNldGdyb3VwcyBz eXNjYWwgaXMgYSBwb2ludGVyOgoKICAgICAgIGludCBzZXRncm91cHMoc2l6ZV90IHNpemUsIGNv bnN0IGdpZF90ICpsaXN0KTsKCkJ1dCBvbiB4MzIsIHBvaW50ZXJzIHBhc3NlZCB0byBzeXNjYWxs IG11c3QgaGF2ZSBwb2ludGVyIHR5cGUgc28gdGhhdAp0aGV5IHdpbGwgYmUgemVyby1leHRlbmRl ZC4gIFRoZSBrZXJuZWwgWElEIGFyZ3VtZW50cyBhcmUgdW5zaWduZWQgYW5kCmRvIG5vdCByZXF1 aXJlIHNpZ24gZXh0ZW5zaW9uLiAgQ2hhbmdlIHhpZF9jb21tYW5kIHRvCgpzdHJ1Y3QgeGlkX2Nv bW1hbmQKewogIGludCBzeXNjYWxsX25vOwogIHVuc2lnbmVkIGxvbmcgaW50IGlkWzNdOwogIHZv bGF0aWxlIGludCBjbnRyOwogIHZvbGF0aWxlIGludCBlcnJvcjsKfTsKCnNvIHRoYXQgYWxsIGFy Z3VtZW50cyBhcmUgemVyby1leHRlbmRlZC4gIEEgdGVzdGNhc2UgaXMgYWRkZWQgZm9yIHgzMiBh bmQKc2V0Z3JvdXBzIHJldHVybmVkIHdpdGggRUZBVUxUIHdoZW4gcnVubmluZyBhcyByb290IHdp dGhvdXQgdGhlIGZpeC4KLS0tCiBucHRsL01ha2VmaWxlICAgICAgICB8ICAyICstCiBucHRsL2Rl c2NyLmggICAgICAgICB8ICA4ICsrKystCiBucHRsL3RzdC1zZXRncm91cHMuYyB8IDc5ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQs IDg3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgbnB0 bC90c3Qtc2V0Z3JvdXBzLmMKCmRpZmYgLS1naXQgYS9ucHRsL01ha2VmaWxlIGIvbnB0bC9NYWtl ZmlsZQppbmRleCA1ZTYyYzc3ODUzLi44OTU2OWM0ZjQ2IDEwMDY0NAotLS0gYS9ucHRsL01ha2Vm aWxlCisrKyBiL25wdGwvTWFrZWZpbGUKQEAgLTMxMCw3ICszMTAsNyBAQCB0ZXN0cy1pbnRlcm5h bCA6PSB0c3Qtcm9idXN0cGk4IHRzdC1yd2xvY2sxOSB0c3Qtcndsb2NrMjAgXAogCQkgIHRzdC1z ZXRnZXRuYW1lIFwKIAogeHRlc3RzID0gdHN0LXNldHVpZDEgdHN0LXNldHVpZDEtc3RhdGljIHRz dC1zZXR1aWQyIFwKLQl0c3QtbXV0ZXhwcDEgdHN0LW11dGV4cHA2IHRzdC1tdXRleHBwMTAKKwl0 c3QtbXV0ZXhwcDEgdHN0LW11dGV4cHA2IHRzdC1tdXRleHBwMTAgdHN0LXNldGdyb3VwcwogCiAj IFRoaXMgdGVzdCBjYW4gcnVuIGludG8gdGFzayBsaW1pdHMgYmVjYXVzZSBvZiBhIGxpbnV4IGtl cm5lbCBidWcKICMgYW5kIHRoZW4gY2F1c2UgdGhlIG1ha2UgcHJvY2VzcyB0byBmYWlsIHRvbywg c2VlIGJ1ZyAyNDUzNy4KZGlmZiAtLWdpdCBhL25wdGwvZGVzY3IuaCBiL25wdGwvZGVzY3IuaApp bmRleCA2YTUwOWI2NzI1Li5kODM0M2ZmOWExIDEwMDY0NAotLS0gYS9ucHRsL2Rlc2NyLmgKKysr IGIvbnB0bC9kZXNjci5oCkBAIC05NSw3ICs5NSwxMyBAQCBzdHJ1Y3QgcHRocmVhZF91bndpbmRf YnVmCiBzdHJ1Y3QgeGlkX2NvbW1hbmQKIHsKICAgaW50IHN5c2NhbGxfbm87Ci0gIGxvbmcgaW50 IGlkWzNdOworICAvKiBFbmZvcmNlIHplcm8tZXh0ZW5zaW9uIGZvciB0aGUgcG9pbnRlciBhcmd1 bWVudCBpbgorCisgICAgIGludCBzZXRncm91cHMgKHNpemVfdCBzaXplLCBjb25zdCBnaWRfdCAq bGlzdCk7CisKKyAgICAgVGhlIGtlcm5lbCBYSUQgYXJndW1lbnRzIGFyZSB1bnNpZ25lZCBhbmQg ZG8gbm90IHJlcXVpcmUgc2lnbgorICAgICBleHRlbnNpb24uICAqLworICB1bnNpZ25lZCBsb25n IGludCBpZFszXTsKICAgdm9sYXRpbGUgaW50IGNudHI7CiAgIHZvbGF0aWxlIGludCBlcnJvcjsg LyogLTE6IG5vIGNhbGwgeWV0LCAwOiBzdWNjZXNzIHNlZW4sID4wOiBlcnJvciBzZWVuLiAgKi8K IH07CmRpZmYgLS1naXQgYS9ucHRsL3RzdC1zZXRncm91cHMuYyBiL25wdGwvdHN0LXNldGdyb3Vw cy5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLmFlM2MxYjFiYTAKLS0t IC9kZXYvbnVsbAorKysgYi9ucHRsL3RzdC1zZXRncm91cHMuYwpAQCAtMCwwICsxLDc5IEBACisv KiBUZXN0IHNldGdyb3VwcyBhcyByb290IGFuZCBpbiB0aGUgcHJlc2VuY2Ugb2YgdGhyZWFkcyAo QnVnIDI2MjQ4KQorICAgQ29weXJpZ2h0IChDKSAyMDIwIEZyZWUgU29mdHdhcmUgRm91bmRhdGlv biwgSW5jLgorICAgVGhpcyBmaWxlIGlzIHBhcnQgb2YgdGhlIEdOVSBDIExpYnJhcnkuCisKKyAg IFRoZSBHTlUgQyBMaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRl IGl0IGFuZC9vcgorICAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExlc3Nl ciBHZW5lcmFsIFB1YmxpYworICAgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29m dHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCisgICB2ZXJzaW9uIDIuMSBvZiB0aGUgTGljZW5zZSwg b3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKworICAgVGhlIEdOVSBDIExp YnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwK KyAgIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdh cnJhbnR5IG9mCisgICBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFS IFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICAgTGVzc2VyIEdlbmVyYWwgUHVibGljIExpY2Vuc2Ug Zm9yIG1vcmUgZGV0YWlscy4KKworICAgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBv ZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYworICAgTGljZW5zZSBhbG9uZyB3aXRoIHRo ZSBHTlUgQyBMaWJyYXJ5OyBpZiBub3QsIHNlZQorICAgPGh0dHBzOi8vd3d3LmdudS5vcmcvbGlj ZW5zZXMvPi4gICovCisKKyNpbmNsdWRlIDxzdGRsaWIuaD4KKyNpbmNsdWRlIDxsaW1pdHMuaD4K KyNpbmNsdWRlIDxncnAuaD4KKyNpbmNsdWRlIDxlcnJuby5oPgorI2luY2x1ZGUgPGVycm9yLmg+ CisjaW5jbHVkZSA8c3VwcG9ydC94dGhyZWFkLmg+CisjaW5jbHVkZSA8c3VwcG9ydC9zdXBwb3J0 Lmg+CisjaW5jbHVkZSA8c3VwcG9ydC90ZXN0LWRyaXZlci5oPgorI2luY2x1ZGUgPHN1cHBvcnQv eHVuaXN0ZC5oPgorCisvKiBUaGUgcHVycG9zZSBvZiB0aGlzIHRlc3QgaXMgdG8gdGVzdCB0aGUg c2V0Z3JvdXBzIEFQSSBhcyByb290IGFuZCBpbgorICAgdGhlIHByZXNlbmNlIG9mIHRocmVhZHMu ICBPbmNlIHdlIGNyZWF0ZSBhIHRocmVhZCB0aGUgc2V0Z3JvdXBzCisgICBpbXBsZW1lbnRhdGlv biBtdXN0IGVuc3VyZSB0aGF0IGFsbCB0aHJlYWRzIGFyZSBzZXQgdG8gdGhlIHNhbWUKKyAgIGdy b3VwIGFuZCB0aGlzIG9wZXJhdGlvbiBzaG91bGQgbm90IGZhaWwuIExhc3RseSB3ZSB0ZXN0IHNl dGdyb3VwcworICAgd2l0aCBhIHplcm8gc2l6ZWQgZ3JvdXAgYW5kIGEgYmFkIGFkZHJlc3MgYW5k IHZlcmlmeSB3ZSBnZXQgRVBFUk0uICAqLworCitzdGF0aWMgdm9pZCAqCitzdGFydF9yb3V0aW5l ICh2b2lkICphcmdzKQoreworICByZXR1cm4gTlVMTDsKK30KKworc3RhdGljIGludAorZG9fdGVz dCAodm9pZCkKK3sKKyAgaW50IHNpemU7CisgIC8qIE5COiBTdGFjayBhZGRyZXNzIGNhbiBiZSBh dCAweGZmZlhYWFhYIG9uIDMyLWJpdCBPU2VzLiAgKi8KKyAgZ2lkX3QgbGlzdFtOR1JPVVBTX01B WF07CisgIGludCBzdGF0dXMgPSBFWElUX1NVQ0NFU1M7CisKKyAgcHRocmVhZF90IHRocmVhZCA9 IHhwdGhyZWFkX2NyZWF0ZSAoTlVMTCwgc3RhcnRfcm91dGluZSwgTlVMTCk7CisKKyAgc2l6ZSA9 IGdldGdyb3VwcyAoc2l6ZW9mIChsaXN0KSAvIHNpemVvZiAobGlzdFswXSksIGxpc3QpOworICBp ZiAoc2l6ZSA8IDApCisgICAgeworICAgICAgc3RhdHVzID0gRVhJVF9GQUlMVVJFOworICAgICAg ZXJyb3IgKDAsIGVycm5vLCAiZ2V0Z3JvdXBzIGZhaWxlZCIpOworICAgIH0KKyAgaWYgKHNldGdy b3VwcyAoc2l6ZSwgbGlzdCkgPCAwKQorICAgIHsKKyAgICAgIGlmIChlcnJubyA9PSBFUEVSTSkK KwlzdGF0dXMgPSBFWElUX1VOU1VQUE9SVEVEOworICAgICAgZWxzZQorCXsKKwkgIHN0YXR1cyA9 IEVYSVRfRkFJTFVSRTsKKwkgIGVycm9yICgwLCBlcnJubywgInNldGdyb3VwcyBmYWlsZWQiKTsK Kwl9CisgICAgfQorCisgIGlmIChzdGF0dXMgPT0gRVhJVF9TVUNDRVNTICYmIHNldGdyb3VwcyAo MCwgbGlzdCkgPCAwKQorICAgIHsKKyAgICAgIHN0YXR1cyA9IEVYSVRfRkFJTFVSRTsKKyAgICAg IGVycm9yICgwLCBlcnJubywgInNldGdyb3VwcyBmYWlsZWQiKTsKKyAgICB9CisKKyAgeHB0aHJl YWRfam9pbiAodGhyZWFkKTsKKworICByZXR1cm4gc3RhdHVzOworfQorCisjaW5jbHVkZSA8c3Vw cG9ydC90ZXN0LWRyaXZlci5jPgotLSAKMi4yNi4yCgo= --000000000000bca9e105ab712dfa--