From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by sourceware.org (Postfix) with ESMTPS id 0D994385829E for ; Fri, 16 Feb 2024 13:25:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D994385829E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0D994385829E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708089934; cv=none; b=m0SAAQcAYM2BaGnT53jvoiFQdrQLezp2HNdDNYyx1j44gEHNDde1aoz7FLCrEscNDiYrTLjNJVsilQONBKCsK17njKrKrQF2HF+jKyqbr5RJBgRjE2Vdv4ma9ApvI205PNtQCeMCNArehcQU92HJPJZ2zVk40AoDxvliA6w1hbA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708089934; c=relaxed/simple; bh=ikwwxK0APFu9WQvj2VBjH3s+g1xEXUv5F7+xDycZAqg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=sIE/453SVyF+RxNW+vM5Cx+UtDpxCgVGgU7GEMlUiidkhwPR7PWJOJY7olU2daqwo3tCmZ1EkYSZwl279PcXwUpXCvxPDWRqTdJRBVXW7w411Hu/T2yposBpjH0OhNR1S4oab/miYqAbmDlpvy5fRcFVE+P8ZjagVUsY5oiyPyw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-60777552d72so19127927b3.1 for ; Fri, 16 Feb 2024 05:25:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708089932; x=1708694732; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=suCWKD3E+kebc1G/5gLF2LXqAhoeNbaR+Hfr4ebuWmk=; b=bEoaqxV47zT/afTudYrzeCycJAi3fcK4JdAkA/15eGXtmnWSnT3B9xUnA4tay2FdoA nN6u9JFWJ6vFheyCxUBHG7TguDXjHMgSnBOhcbOIevdhReo+W7vhmzeLnNCBZTiOkm+Z 9TNLbvLWyDXre6ZArPcl6syZ1oNrjIopdGaUMrEx9mvgWnf+xp44tm+90SceY45s3Afo xWszeJLcoczT1E9QEk4w3ZP60W0X412s9vA0I/PRKq+N/035gEGuLrT5EuSujxsiJpA5 cQi3lSDCs+HuhHi/g3h5j8T5NcpzuHQjZ4xefScOh2i6rzeHrpEm07wM8AU0rTLjxhTD JRKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708089932; x=1708694732; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=suCWKD3E+kebc1G/5gLF2LXqAhoeNbaR+Hfr4ebuWmk=; b=JV2cRqM6Abt1NAlIJ9mTX7jzDI+LivdQrrNCv3i2tWOOjf1sip/fpmUJmL1rhlt2kt S8aRvYDS2N5pO1DvcwwYvbQno2Cs3yCTv9B4xnOy3S0735g5IsEoFRiOaESwPoMXdXud w8sfaH8FOCAsvuOYgTE1wU4UE5JLALqqVFeArowDFMmSp7w3/QR4UXrY22ivEksf/5+3 5VSSho1ufquN+12231u8zjRfdlmXBUMKyDIxEkQU/kVPLQuK5EBB3INyFUNOMWA+fTN5 cAphW3Y6kGdxfVJe0KQtiXE8ucNQZdVWlZtRkp0m8KQTYpsfIw4l+T9gEcVDbEqJx/QY fjpA== X-Forwarded-Encrypted: i=1; AJvYcCXf4GiOEwlK6rAuHm5aqseSP/UsZBoPF2ipt2+sHuQQDPrOo6uc2q9IL+4IzqBZRaUcQ+DkZlqqK5a+cIKsmsVkLKsy7Kjl/cfP X-Gm-Message-State: AOJu0YyKfhecKsq9uZbrWp+fr2jRCkjYPUus277l2catncwzEmntexnl SU+nabyO8Dtpwop5JpoDnqiTMbO9SSBASneviAawQz8EEFfmvKysduSZMT89AvViCWsAr9tC7u+ NcFLqMfPqKsvGRbGcxZZmR3hRFozDXHPoxK0= X-Google-Smtp-Source: AGHT+IG3sOJGE/mSEMJZu/mWFBmS1F5fsPs+FSytOsF3enZVV6UnU5EkwlPgbFcJ1Y2Wx/CMV7Q5rdmvAk5innowD54= X-Received: by 2002:a81:73d6:0:b0:607:60a5:8448 with SMTP id o205-20020a8173d6000000b0060760a58448mr4967948ywc.0.1708089932389; Fri, 16 Feb 2024 05:25:32 -0800 (PST) MIME-Version: 1.0 References: <20240213041501.2494232-1-hjl.tools@gmail.com> <20240213041501.2494232-3-hjl.tools@gmail.com> <871q9d7wra.fsf@oldenburg.str.redhat.com> <87mss061s0.fsf@oldenburg.str.redhat.com> <87eddc5zj6.fsf@oldenburg.str.redhat.com> In-Reply-To: <87eddc5zj6.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Fri, 16 Feb 2024 05:24:56 -0800 Message-ID: Subject: Re: [PATCH v4 2/2] x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers To: Florian Weimer Cc: Adhemerval Zanella Netto , libc-alpha@sourceware.org, Fangrui Song , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 16, 2024 at 5:06=E2=80=AFAM Florian Weimer = wrote: > > * H. J. Lu: > > >> > I thought that unversioned symbols interpose all versioned symbols. = Has > >> > this changed in the dynamic linker? > >> > >> Only for this case. > >> > > > > I was wrong. Version isn't needed. Will fix it. > > Ahh. You don't need malloc-for-test.so, either. I think you could use > -Wl,-E (--export-dynamic) to trigger interposition from the main > program. No need for --export-dynamic since malloc is exported from libc.so. > It would make sense to check using a counter that the interposed malloc > is in fact called. Will do. > Thanks, > Florian > Thanks. --=20 H.J.