From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 6681B3858029 for ; Mon, 8 Nov 2021 14:08:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6681B3858029 Received: by mail-pf1-x42b.google.com with SMTP id c126so7661223pfb.0 for ; Mon, 08 Nov 2021 06:08:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9Ydplpt56zkvDCvmML6NQXWiV2eCsNTyJB4ZysqSu6Q=; b=wA9HKHGmNcZBNPDuIf8fFkg5+45lpVyOIQrXyBfMu9PenbUoQXAmuOa/CdJXZUssrD TreRqtcfxajCCA9RqBkgASfvSwTVSdZSah1pCM/B7vhDfcXy39iXw6xlgMP4xFEVrU7g 0yIn/3A6vaTdsUWTSYZtbb/AJa91wIOUDwWu++Hj+sCZ3ZG6escf1pUwTWVX/LO9AK6T JV4jfl6xe4+AxpgcyaaJSXJuXJMrTBvadUACdpMIe/a1Yb1jzqpCngGffuM3ykxYq1U7 /CL0tiWi2D+CkaACGF2QOKJAkY7um6PdZWRYNr50CHGVtkG2EIRebs3FCPUMvS5O6dZ9 wknQ== X-Gm-Message-State: AOAM532nmoa3TA520vquKr3Ooj48IZ/ebujuMh2DCQTnCI+ohfh/rTpd 7Y4GY60Kv06IfLB/4joux0DZ8R+VRgaiglGijFg= X-Google-Smtp-Source: ABdhPJxzcZ9P4zOyVFBbcK74o/EldkX3IRv9FTr51yx82AGmhMyh3iwM0wTClVH1+3LtiCGnVzdvMFbbG53DpSVRdd0= X-Received: by 2002:a63:87c1:: with SMTP id i184mr103930pge.75.1636380497354; Mon, 08 Nov 2021 06:08:17 -0800 (PST) MIME-Version: 1.0 References: <20211107150727.157003-1-hjl.tools@gmail.com> <20211107150727.157003-2-hjl.tools@gmail.com> <8735o6kbed.fsf@oldenburg.str.redhat.com> In-Reply-To: <8735o6kbed.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Mon, 8 Nov 2021 06:07:41 -0800 Message-ID: Subject: Re: [PATCH 1/2] dso-ordering-test.py: Put all sources in one directory [BZ #28550] To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 14:08:19 -0000 On Mon, Nov 8, 2021 at 5:46 AM Florian Weimer wrote: > > * H. J. Lu via Libc-alpha: > > > Also use a temporary file to generate Makefile fragments for DSO sorting > > tests. > > I don't see this part in the patch? This is the leftover from the old changes. > > diff --git a/scripts/dso-ordering-test.py b/scripts/dso-ordering-test.py > > index 944ee74052..26497159a0 100644 > > --- a/scripts/dso-ordering-test.py > > +++ b/scripts/dso-ordering-test.py > > @@ -526,9 +526,13 @@ def process_testcase(t): > > base_test_name = t.test_name > > test_subdir = base_test_name + "-dir" > > testpfx = objpfx + test_subdir + "/" > > + test_srcdir = "dso-sort-tests-src/" > > + testpfx_src = objpfx + test_srcdir > > > > if not os.path.exists(testpfx): > > os.mkdir(testpfx) > > + if not os.path.exists(testpfx_src): > > + os.mkdir(testpfx_src) > > > > def find_objs_not_depended_on(t): > > objs_not_depended_on = [] > > @@ -595,6 +599,11 @@ def process_testcase(t): > > # Print out needed Makefile fragments for use in glibc/elf/Makefile. > > module_names = "" > > for o in test_descr.objs: > > + rule = ("$(objpfx)" + test_subdir + "/" + test_name > > + + "-" + o + ".os: $(objpfx)" + test_srcdir > > + + test_name + "-" + o + ".c\n" > > + "\t$(compile.c) $(OUTPUT_OPTION)\n") > > + makefile.write (rule); > > Spurious semicolon at end of line (there are multiple such cases). I will remove them. > Why do you put the generated test sources into a separate subdirectory? > To avoid the default make rule: $(objpfx)%$o: $(objpfx)%.c $(before-compile); $$(compile-command.c) which causes the problem for parallel build. -- H.J.