From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: RFC: Add <sys/platform/x86.h> to glibc 2.29
Date: Fri, 17 Aug 2018 15:46:00 -0000 [thread overview]
Message-ID: <CAMe9rOoMsLTXcpvGLnaeDZ4PiOu3WHVkU+STO4pBnK1VDcYq9g@mail.gmail.com> (raw)
In-Reply-To: <ffb5c746-1672-076c-e1e2-ae6c4f435026@redhat.com>
On Fri, Aug 17, 2018 at 7:50 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 07/29/2018 06:16 PM, H.J. Lu wrote:
>>
>> extern enum cpu_features_kind __x86_get_cpu_kind (void)
>> __attribute__ ((const));
>>
>> extern const struct cpuid_registers *__x86_get_cpuid_registers
>> (unsigned int) __attribute__ ((const));
>>
>> extern unsigned int __x86_get_arch_feature (unsigned int)
>> __attribute__ ((const));
>
>
> Are these functions supposed to be usable in IFUNC resolvers?
They have the same limitation as
/* Used from outside of glibc to get access to the CPU features
structure. */
extern const struct cpu_features *__get_cpu_features (void)
__attribute__ ((const));
> Shouldn't these identifiers be in the public (non-internal) namespace?
>
Do we have precedents for such arch specific public functions?
--
H.J.
next prev parent reply other threads:[~2018-08-17 15:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 16:16 H.J. Lu
2018-07-31 13:32 ` Carlos O'Donell
2018-07-31 14:49 ` H.J. Lu
2018-07-31 15:06 ` Carlos O'Donell
2018-07-31 16:17 ` H.J. Lu
2018-08-17 14:50 ` Florian Weimer
2018-08-17 15:46 ` H.J. Lu [this message]
2018-08-17 16:19 ` Florian Weimer
2018-08-17 16:44 ` H.J. Lu
2018-08-17 19:11 ` Florian Weimer
2018-08-20 11:29 ` Florian Weimer
2018-08-20 20:55 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoMsLTXcpvGLnaeDZ4PiOu3WHVkU+STO4pBnK1VDcYq9g@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).