From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d])
	by sourceware.org (Postfix) with ESMTPS id 537523858016;
	Wed, 28 Sep 2022 19:24:23 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 537523858016
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-qv1-xf2d.google.com with SMTP id s13so8737418qvq.10;
        Wed, 28 Sep 2022 12:24:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=hADIooByKUmfOcv2autM7imI6XCWkdARvCtvt6hX1Y8=;
        b=pu7xMkZlPOL8GVyO3sqjm9vLcFP0Q0J3X8pMCTSGwGux7DSB8kVOTyX/nO1nCsPTVw
         ZJQF6O2BlsMMwaDLz3i1FLcFYZdSedq4UCXSDRyncR9PK9fAtp46LFuPih926acUcRVp
         7FH4nK92WNDX/NSMtnMGSgRfqcv4X9w0NbrOyzVFJwSn4FkiEHQxDmXo2ebxEHp7K5pl
         M/dHs2aWLWqco6twRonPLmQ4Q4wgaa6Oh6rLPVtl/ugy0UdjcjAV03HmLpPxAAXLy/z3
         SuA7Rzb3E/nXDcSNpyfuA672TeafOX9dF0cRXFYtqiiLRgpWp7yTUsIgyza7Qhki0Hqk
         ntnA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=hADIooByKUmfOcv2autM7imI6XCWkdARvCtvt6hX1Y8=;
        b=O0CSt/UgFSd2NifyCyaVUVyh5CUhWz3z50hjxyKbpcEin6IDB1qpiLD66yHvlYU5/O
         iXTeKusLL0G1VRcfPcTEMEDoXnZaixjGO5LKXQBPlmTVb/3WkN7iCc5ij5Ie/UCziw8h
         3yliA3eHhjIIAcec3ibc//fIB+uBwZXo4hnWXwuR4FfAiJhdAAMlPkWdLevUx3IEI8cU
         bUUiy7foZ3DjC1B/tpDfAvp0NbvO5KzGclZHPej2jZbgxe1eSbdLyvpFJ56eoR9vf9kq
         RY++/fJ+ucZdj02mqC8bJJWVDavpZq9G7IGr+xDZiWVJlEMk6e5v73cFNIFwthhUQ9GT
         P3KQ==
X-Gm-Message-State: ACrzQf3A7yADHBJG145t16yT7DYoFh0gqfd0xn+Ysup9v12C6lf4aoX9
	Lnahj4s+B4h7UR29s5JUixjCzNskkyMJpBW9qKD8wr3Tl44=
X-Google-Smtp-Source: AMsMyM7VjROJxajailq4qeW0KudHDX+PPPcmN1h8LmdYbcRrg0sEt+gYos+/wWa4OYuUhOZebMQehyJrTXmR8u6iNU4=
X-Received: by 2002:ad4:5944:0:b0:4ad:7802:c35a with SMTP id
 eo4-20020ad45944000000b004ad7802c35amr27030683qvb.84.1664393062621; Wed, 28
 Sep 2022 12:24:22 -0700 (PDT)
MIME-Version: 1.0
References: <20210419233607.916848-1-goldstein.w.n@gmail.com>
 <20210419233607.916848-2-goldstein.w.n@gmail.com> <YzAO/ictPso/Y5LS@aurel32.net>
 <CAFUsyf+U==grKgr9ZivEHDYsj=Xxi0MXBtQDfkU-JBHxb0pq+A@mail.gmail.com>
 <CAMAf5_eD8ABiFiKabV5xKkR-xLR7sK7Dx18z4VoawUUwkomf+g@mail.gmail.com>
 <CAMe9rOqSa5CJNpM_0EPbCWeStWG2JW7M7PYEWyNEv_bXpF2WzQ@mail.gmail.com> <CAMAf5_eoqSNp+OwjH-wtqdEbNn1ty=b5szWAESU9cZRxzqE2Cw@mail.gmail.com>
In-Reply-To: <CAMAf5_eoqSNp+OwjH-wtqdEbNn1ty=b5szWAESU9cZRxzqE2Cw@mail.gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 28 Sep 2022 12:23:46 -0700
Message-ID: <CAMe9rOoO9wAJ412qgATRFKXj8XUiXKp2APLkSg6iKLSVZ2X9eg@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] x86: Optimize strlen-avx2.S
To: Sunil Pandey <skpgkp2@gmail.com>
Cc: Noah Goldstein <goldstein.w.n@gmail.com>, 
	Libc-stable Mailing List <libc-stable@sourceware.org>, GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3018.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Wed, Sep 28, 2022 at 12:09 PM Sunil Pandey <skpgkp2@gmail.com> wrote:
>
> On Wed, Sep 28, 2022 at 11:24 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Wed, Sep 28, 2022 at 6:55 AM Sunil Pandey <skpgkp2@gmail.com> wrote:
> > >
> > > Attached patch fixes BZ# 29611.
> > >
> > > I would like to backport it to 2.32,2.31,2.30,2.29 and 2.29. Let me know
> > > if there is any objection.
> >
> > It doesn't fully fix BZ #29611.  Like Noah mentioned, we need to add
> > BMI2 check to ifunc-impl-list.c for all functions which use "ifunc-avx2.h".
> >
> >
> > H.J.
>
> Pulling up corresponding patches are extremely difficult as they are not
> modular. I can modify existing patches (as posted on bug report) to
> incorporate ifunc-impl-list.c functionality. If it is OK?

Please mention BZ #29611 in the commit log of the backport and submit
a separate patch to fully fix BZ #29611.  We should use a patch set for
BZ #29611.

> For backporting small incremental changes are preferred. Single monolithic
> patch makes backporting extremely difficult, if not impossible.



-- 
H.J.