From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 274D23896C0C for ; Wed, 28 Apr 2021 01:31:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 274D23896C0C Received: by mail-oi1-x22a.google.com with SMTP id u80so27938450oia.0 for ; Tue, 27 Apr 2021 18:31:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mAnbKsPwn3o3Dsu9n4yZu3l+P9j/FZIrAmhBZ4H3lSY=; b=W9MYj5HYzLk6TF7Gha3WZSgk3GZqKf2+W9y1zoq62VUpn8AufARxZcsClDjl+bdgKQ s1HPIFTkQM3oYTMiAgyZCRvPHwwqh0h6SLaWyRMg3DjebgBgYhKDCufOEV0BZJ4N/9k/ B0d487pS/xnR4OPdaHpB+3iqjFqdWeYWHdxsT9vx7G1Ltq1gy05c97J4ZF7tD7Bi14Ft GdT1KfGbgnu3LjpxRGvNdMkifWHC/+Vkgwx41kSeenAu38XDyn75OUYFpF8OerOuxwQO PpXLQjaK4+bHf+CKgupPfXfbVIJbQnPppoq26UnuPSWang2EL8Sd2GHrlffW5BCHHVMw 8HcA== X-Gm-Message-State: AOAM533dIXFAP5ofcVWd+5jP/b0ccENUVRr4qNm5qcMi0A9wzWfJOAc4 JjLrC5Mj42LwhQGgxC/jJpNwnmUmE/e7QzYBmuM= X-Google-Smtp-Source: ABdhPJzRlbQmjcxdGxyQdWrLspmtlIzD62ElDJZxw0TDiSCm8w4q3wJwErZwWXUYsrspfKkHfHwY07MDZaOIiL6Z/So= X-Received: by 2002:aca:dd82:: with SMTP id u124mr800666oig.35.1619573463624; Tue, 27 Apr 2021 18:31:03 -0700 (PDT) MIME-Version: 1.0 References: <2ec7fadb-cc15-a005-f708-d2adecc8cc39@gmail.com> <875z08qqy8.fsf@oldenburg.str.redhat.com> <571eb466-8979-8579-3b52-38f29a628a39@gmail.com> <47fc35d1-05b0-c02e-77dc-b3193aefd865@gmail.com> In-Reply-To: <47fc35d1-05b0-c02e-77dc-b3193aefd865@gmail.com> From: "H.J. Lu" Date: Tue, 27 Apr 2021 18:30:27 -0700 Message-ID: Subject: Re: [PATCH] add attribute none to pthread_setspecific (BZ #27714) To: Martin Sebor Cc: Joseph Myers , Florian Weimer , Martin Sebor via Libc-alpha Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 01:31:05 -0000 On Tue, Apr 27, 2021 at 6:00 PM Martin Sebor via Libc-alpha wrote: > > On 4/27/21 3:58 PM, Joseph Myers wrote: > > On Tue, 27 Apr 2021, Martin Sebor via Libc-alpha wrote: > > > >> These are warnings in my build (I've seen a few others scroll by > >> and have always assumed they were expected(*)). Those you pasted > > > > Most warnings are errors by default (unless you use --disable-werror, > > which should never normally be used in glibc development unless you're > > e.g. reviewing the warnings you get if you add extra warning options to > > those with which glibc is built by default, in order to fix those warnings > > before adding the extra options). > > Ah, that's what my build script does and I keep forgetting to > change that when working on Glibc (as opposed to testing new > GCC warnings). My bad. The attached diff patches up the tests > to pass the function a valid argument. I'll plan to commit it > shortly unless you prefer some other solution. > It doesn't work: https://sourceware.org/bugzilla/show_bug.cgi?id=27714#c3 -- H.J.