From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 5EA093858D35 for ; Fri, 14 Jan 2022 16:06:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5EA093858D35 Received: by mail-pg1-x52c.google.com with SMTP id t32so3120308pgm.7 for ; Fri, 14 Jan 2022 08:06:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JP8Po2aO3h7LVQD2apLACSN0hbiQI9ZSdiIf2+UlxPc=; b=iarF861X6NZUxs/WpJObuANDSx9rSN6TUXQbOT+FQS//IG5l2nyNy4YK/wCiqIV8JH wmCHWX8IyS2qT8neQGl1SA8Azp/r5KBLbBR/TMMkzzdsBDUBzvs9tX+q8tYELXfxrc0d SB9HymsFKTpWw/b5DBEisTaanC+shwTUxMQvyX+JiJBT2iugiY8oQjiQBNnhU/vOXpNg esXvnNLSU8mUxkMiY72ZdvMoJBJhWA8RPRjfmbdo0JxgnXAIxBZEs6SXNrdWGU3UyDZw kkDDoKx8MrBWKPXY7tQMZlspFS8BhiikkonORU4FaqAnCvKy7V/Zloi5Z2qivqE883Gh UqnA== X-Gm-Message-State: AOAM530irB8RMBWcSruITROxpxgW37OK/IzxbQpKoJ4HK244GKqYNtEw 7yfBN4ICQIknW5C87bxbqBeL9T1/RW2xtsjSEgc= X-Google-Smtp-Source: ABdhPJwGhKoZF33vXnkqZBBQ7C8N2g3enqZg5S+i5pZtLr8aqesvSKtJ2fLclGh5+3jBexbdkEj6+z7f2JkacMCZukE= X-Received: by 2002:a05:6a00:1311:b0:4ba:1288:67dc with SMTP id j17-20020a056a00131100b004ba128867dcmr9489428pfu.43.1642176405490; Fri, 14 Jan 2022 08:06:45 -0800 (PST) MIME-Version: 1.0 References: <636c6da259e612258791a6e816bfc7bbfed97e3a.1641228666.git.fweimer@redhat.com> <878rvitkth.fsf@oldenburg.str.redhat.com> <874k66tjgd.fsf@oldenburg.str.redhat.com> <87zgnys4ca.fsf@oldenburg.str.redhat.com> <87v8yms44r.fsf@oldenburg.str.redhat.com> In-Reply-To: <87v8yms44r.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Fri, 14 Jan 2022 08:06:09 -0800 Message-ID: Subject: Re: [PATCH 3/3] elf/tst-dl_find_object: Disable subtests for non-contiguous maps (bug 28732) To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3021.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 16:06:47 -0000 On Fri, Jan 14, 2022 at 7:56 AM Florian Weimer wrote: > > * H. J. Lu: > > > On Fri, Jan 14, 2022 at 7:51 AM Florian Weimer wrote: > >> > >> * H. J. Lu: > >> > >> > On Fri, Jan 14, 2022 at 7:39 AM Florian Weimer wrote: > >> >> > >> >> * H. J. Lu: > >> >> > >> >> >> We never set l_contiguous for the main executable, so it doesn't matter > >> >> >> what the link editor does. And none of the glibc fixes went in so far. > >> >> >> > >> >> >> Thanks, > >> >> >> Florian > >> >> >> > >> >> > > >> >> > Should l_contiguous be set on the main executable? If not, why? > >> >> > >> >> I think it should be set even if the kernel loads the main executable. > >> >> See patch 2: > >> >> > >> >> [PATCH 2/3] elf: Set l_contiguous to 1 for the main map in more cases > >> >> > >> > > >> > If we have the second patch, do we still need the 3rd one? > >> > >> I think gaps are expected on some architectures for main executable > >> (ia64?). > >> > > > > Please add a header to indicate that the gap is expected only on some > > architectures. > > Sorry, do you mean there should be a .h file to indicate whether the > architecture expects a gap? > > How do I tell whether the gap is expected or the result of binutils > bugs? > You can add a linker test to check for the linker bug. -- H.J.