From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com
 [IPv6:2607:f8b0:4864:20::12e])
 by sourceware.org (Postfix) with ESMTPS id 7215738618E2
 for <libc-alpha@sourceware.org>; Mon, 28 Sep 2020 14:39:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7215738618E2
Received: by mail-il1-x12e.google.com with SMTP id q4so1474252ils.4
 for <libc-alpha@sourceware.org>; Mon, 28 Sep 2020 07:39:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=G+D/ibDw4FOdauD6erqChzihAFyAmHipsJzyixnCRLA=;
 b=FsnyADCRp6U5ZB2nHr23bkdKW5unOwzztll1UlePOyYCk828aj61eUOExNL1/Kj2ZY
 mQmfnpakCYlR8UJBHgv7ZfYm/BP469dUyHD40uSvQ0SOmJ3ymsVdyFBRkL+F7HkW99Zh
 pYPZTPen1VBgNkfB4FRDxw5itG7bAGMNAwk5VKeqFX3GE5vDVNVtX9HmQmi16jQl6wZ0
 thg5FpkJD+oanmzcRYHTX3othKW8u5bQkVmj3Sn//m1AuiGxC9GiYPDTdFW3r5QjK7mF
 NuwMSN1Raw1M0jImnHFJBzAIQFsj5dVDCM4LZTJtdSaKm6s96PCBwIQv4zIVhRV8Q/+z
 IJwg==
X-Gm-Message-State: AOAM530KxpPPxfqd7PVjzsGD11tUBsqT2PSXbVBNuRt9ZUgP/nX44mws
 uxDBMUMwp2pFjFt4O6+/BNx3y5P/ytCFdxhJMtjiXWcw2D4=
X-Google-Smtp-Source: ABdhPJyQbjdUfs+M/hKBbDHRaNYwkji6Neydl/tdDyQgloYKOHOuxF4q9ke8fQmpS31aQDnj6nXYA5GU7qoHAC7gg4o=
X-Received: by 2002:a92:790b:: with SMTP id u11mr1554092ilc.13.1601303991896; 
 Mon, 28 Sep 2020 07:39:51 -0700 (PDT)
MIME-Version: 1.0
References: <20200918160709.949608-1-hjl.tools@gmail.com>
 <20200918160709.949608-2-hjl.tools@gmail.com>
 <87imby6obw.fsf@oldenburg2.str.redhat.com>
 <CAMe9rOo_OUmsikKWj_pXiy-G+NJZGGJwzn2_YTczXPvd09FaRA@mail.gmail.com>
 <87y2ku574k.fsf@oldenburg2.str.redhat.com>
 <CAMe9rOqjzDHL+O04FSCzRdnANJK0_3o5pDCd2UGyFsce+mU8Kg@mail.gmail.com>
 <87lfgu56c8.fsf@oldenburg2.str.redhat.com>
In-Reply-To: <87lfgu56c8.fsf@oldenburg2.str.redhat.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 28 Sep 2020 07:39:16 -0700
Message-ID: <CAMe9rOoR_m6L7XUyMBjtqT_c80eiNUjuSOD112iX-Wne6cCYvQ@mail.gmail.com>
Subject: Re: [PATCH 1/4] x86: Initialize CPU info via IFUNC relocation [BZ
 26203]
To: Florian Weimer <fweimer@redhat.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3033.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Sep 2020 14:39:53 -0000

On Mon, Sep 28, 2020 at 7:22 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu:
>
> > We want to call init_cacheinfo as early as possible.  __libc_early_init is
> > still too late.
>
> My point is that we should call it from IFUNC resolvers that need it,
> and from __libc_early_init.  That should cover all cases, no?

Why call it from __libc_early_init after it has been called by
IFUNC reloc?  IFUNC relocations are processed before
__libc_early_init is called.

> It would also settle the matter of the assert.
>
>

-- 
H.J.