From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by sourceware.org (Postfix) with ESMTPS id 8E66E3857C57 for ; Mon, 6 Jul 2020 13:43:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8E66E3857C57 Received: by mail-il1-x142.google.com with SMTP id x9so32942701ila.3 for ; Mon, 06 Jul 2020 06:43:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q4BgV0G2MdhX6QztvAHw5Vv5BNJMF3Jv9qWy5IL3kk8=; b=CkcnPLUXSAW3KKFRR/uDYaATqkox+1MtMJQf/kBbuxQ8dLPcbLnVVGSL7Q0YS42K9q W30mVHUyynisbUII10CkIhrz6bmid3+VvFjtX5ibcnbpZ/8ejTS7qsqXs/ivU120dcCv GWTVto1tJWF75/yzwhOPS7CDKNKVjDdWfxPdf2oohT4vUFitGX9UNYcqsjusUQbLa6ls AoXfnxn8yWth7P6ujYuFsEIwnJjh+rGEZxv5SjhrVk6CzKsPMaPHb0ldPv9lNv6W8Tfn JerHZypzTaL85kSVn3bGwqLawtcFfcuCEaSOiN6Oy7ryH0VTc/aNzZH7L2ghHOBg9K5s NrTA== X-Gm-Message-State: AOAM532E8B3iQ0EKIyOvvwCmcyHlW3R8o1gUsy/1ez8YSXHw2Vb8+Ozf Tz0l2Mh4QdyAD27rvPOzd/buvGrM4UE626goxFY= X-Google-Smtp-Source: ABdhPJz3qK/QqAlBmocE/Joka8l8xorbpaJSBNE0ZYKOtKuG2qVYGV5d0MZM0l+BsPRQxSDEMxK5AJ0WEGJ/fHW01FE= X-Received: by 2002:a92:9914:: with SMTP id p20mr30923550ili.273.1594042989103; Mon, 06 Jul 2020 06:43:09 -0700 (PDT) MIME-Version: 1.0 References: <20200703175220.1178840-1-hjl.tools@gmail.com> <20200703175220.1178840-2-hjl.tools@gmail.com> <20200703230951.GA1301408@gmail.com> <00c789ae-2ef6-5197-59ad-30eea4703d4a@redhat.com> In-Reply-To: <00c789ae-2ef6-5197-59ad-30eea4703d4a@redhat.com> From: "H.J. Lu" Date: Mon, 6 Jul 2020 06:42:33 -0700 Message-ID: Subject: Re: V2 [PATCH 1/2] Update tunable min/max values To: "Carlos O'Donell" Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2020 13:43:10 -0000 On Mon, Jul 6, 2020 at 6:15 AM Carlos O'Donell wrote: > > On 7/6/20 9:13 AM, H.J. Lu wrote: > > On Mon, Jul 6, 2020 at 5:47 AM Carlos O'Donell wrote: > >> > >> On 7/3/20 7:09 PM, H.J. Lu wrote: > >>>> Why not raise the dl-tunables.list minimum to 1? > >>>> Then the above code just becomes what we used to have. > >>> > >>> What we used to have are > >>> > >>> cpu_features->non_temporal_threshold > >>> = TUNABLE_GET (x86_non_temporal_threshold, long int, NULL); > >>> ... > >>> __x86_shared_non_temporal_threshold > >>> = (cpu_features->non_temporal_threshold != 0 > >>> ? cpu_features->non_temporal_threshold > >>> : __x86_shared_cache_size * threads * 3 / 4); > >>> > >>> I just changed the order. > >> This is a bug in sysdeps/x86/dl-tunables.list where we have failed > >> to set the minimum to 1. Please fix dl-tunables.list instead of > >> rewriting the code which is incorrect? > > > > I will update this patch after 2.32 is branched since it isn't needed for > > 2.32. > > That's fine with me, and this patch is easily backported. > BTW, this patch exposed: https://sourceware.org/bugzilla/show_bug.cgi?id=26203 which is fixed by https://sourceware.org/pipermail/libc-alpha/2020-July/115788.html -- H.J.