From: "H.J. Lu" <hjl.tools@gmail.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] ld.so: Handle read-only dynamic section gracefully [BZ #28340]
Date: Wed, 15 Sep 2021 09:13:10 -0700 [thread overview]
Message-ID: <CAMe9rOoTUb6ZydtotZW8U-Q6Op0h77RTw_UgeOZXtiO_C1jqJg@mail.gmail.com> (raw)
In-Reply-To: <c7b54844-b9d0-b140-4b19-1c17ef8cd489@sourceware.org>
On Wed, Sep 15, 2021 at 8:42 AM Siddhesh Poyarekar
<siddhesh@sourceware.org> wrote:
>
> On 9/15/21 8:05 PM, H.J. Lu wrote:
> > On Tue, Sep 14, 2021 at 12:09 PM Siddhesh Poyarekar via Libc-alpha
> > <libc-alpha@sourceware.org> wrote:
> >>
> >> ld.so on x86_64 (and possibly for all other architectures that don't
> >> have a read-only dynamic section by default but I haven't checked on
> >> all of them), when invoked with a DSO that has a read-only .dynamic
> >> section, crashes when trying to update gotplt, symtab, etc. entries
> >> with the load address. This crash happens even during verification,
> >
> > There are no relocations in vDSO. Why does ld.so try to update
> > gotplt, symtab, etc. entries?
>
> elf_get_dynamic_info adjusts the dynamic entries whenever l->l_addr is
> non-zero, regardless of whether there are relocations or not. It does
> so even when it is called through setup_vdso, except that the adjustment
> is done in a special static array for the vdso and not in the dynamic
> section itself.
>
> Siddhesh
Can you extract logic from setup_vdso to handle DSOs without
relocations?
--
H.J.
next prev parent reply other threads:[~2021-09-15 16:13 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 19:09 Siddhesh Poyarekar
2021-09-14 19:15 ` Florian Weimer
2021-09-15 1:14 ` Siddhesh Poyarekar
2021-09-15 14:35 ` H.J. Lu
2021-09-15 15:42 ` Siddhesh Poyarekar
2021-09-15 16:13 ` H.J. Lu [this message]
2021-09-15 16:24 ` Siddhesh Poyarekar
2021-09-15 16:34 ` H.J. Lu
2021-09-16 1:43 ` Siddhesh Poyarekar
2021-09-16 2:23 ` H.J. Lu
2021-09-16 3:46 ` Siddhesh Poyarekar
2021-09-16 4:26 ` H.J. Lu
2021-09-16 4:28 ` Siddhesh Poyarekar
2021-09-16 4:30 ` H.J. Lu
2021-09-16 4:48 ` Florian Weimer
2021-09-16 5:36 ` Siddhesh Poyarekar
2021-09-16 5:46 ` Florian Weimer
2021-09-16 6:04 ` Siddhesh Poyarekar
2021-09-16 14:11 ` Carlos O'Donell
2021-09-16 15:18 ` H.J. Lu
2021-09-16 16:45 ` Siddhesh Poyarekar
2021-09-16 17:38 ` H.J. Lu
2021-09-16 17:58 ` Siddhesh Poyarekar
2021-09-16 22:11 ` H.J. Lu
2021-09-17 2:47 ` Siddhesh Poyarekar
2021-09-17 2:59 ` H.J. Lu
2021-09-17 3:36 ` Siddhesh Poyarekar
2021-09-17 3:42 ` H.J. Lu
2021-09-17 3:44 ` Siddhesh Poyarekar
2021-09-17 3:44 ` Florian Weimer
2021-09-17 3:51 ` Siddhesh Poyarekar
2021-09-16 18:03 ` Florian Weimer
2021-09-16 22:14 ` H.J. Lu
2021-09-17 2:58 ` Siddhesh Poyarekar
2021-09-17 3:46 ` Florian Weimer
2021-09-17 4:00 ` Florian Weimer
2021-09-17 4:12 ` [PATCH] ld.so: Remove DL_RO_DYN_SECTION H.J. Lu
2021-09-17 6:54 ` David Abdurachmanov
2021-09-17 9:01 ` Siddhesh Poyarekar
2021-09-17 15:40 ` H.J. Lu
2021-10-14 12:36 ` [PATCH] ld.so: Handle read-only dynamic section gracefully [BZ #28340] Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoTUb6ZydtotZW8U-Q6Op0h77RTw_UgeOZXtiO_C1jqJg@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).