Re: [PATCH 1/3] New generic sincosf

["H.J. Lu" <hjl.tools@gmail.com>]

On Fri, Dec 15, 2017 at 6:17 AM, Rajalakshmi Srinivasaraghavan
<raji@linux.vnet.ibm.com> wrote:
>
>
> On 12/15/2017 07:49 AM, H.J. Lu wrote:
>>
>> On Thu, Dec 14, 2017 at 4:29 PM, Joseph Myers <joseph@codesourcery.com>
>> wrote:
>>>
>>> On Wed, 13 Dec 2017, Rajalakshmi Srinivasaraghavan wrote:
>>>
>>>> This implementation is based on generic s_sinf.c and s_cosf.c.
>>>> Tested on s390x, powerpc64le and powerpc32.
>>>>
>>>> 2017-12-12  Rajalakshmi Srinivasaraghavan  <raji@linux.vnet.ibm.com>
>>>>
>>>>        * sysdeps/ieee754/flt-32/s_cosf.c: Move reduced() and
>>>>        constants to s_sincos.h file.
>>>>        * sysdeps/ieee754/flt-32/s_sinf.c: Likewise.
>>>>        * sysdeps/ieee754/flt-32/s_sincosf.c: New implementation.
>>>>        * sysdeps/ieee754/flt-32/s_sincos.h: New file.
>>>
>>>
>>> OK.
>>>
>>
>> Please put those static constants into a different file and mark them
>> hidden so that they can be shared when they are compiled twice
>> for FMA.
>>
>
> I assume you are asking changes similar to
> sysdeps/ieee754/flt-32/e_exp2f_data.c. Could you please explain the

Yes.

On x86-64, I will compile sinf/cosf/sincosf twice, with and without FMA.
Both versions of sinf/cosf/sincosf should share the same set of
tables to avoid data duplication.

> advantage of doing this or suggest any previous mail thread which I can
> refer to?

Thanks.

-- 
H.J.