From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 0CB323858030 for ; Mon, 8 Nov 2021 13:13:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0CB323858030 Received: by mail-pl1-x62e.google.com with SMTP id y1so15740370plk.10 for ; Mon, 08 Nov 2021 05:13:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/5ddXBi+H+SK2J6TaQAi/VAFUWvZYlfuDtWZzimJ2As=; b=0uafxuPmWRYOin/0nIzo6SloWlLPSelur1IRm8oqt+cikKtjRm+f2oQCRInfmD/fJL 40CmvWx0/8BPRkJB8DAMxmOvV8QuEKSRGDArWVI05fx42/wRA/jEhWMF48+JzYYQAXSW TK712AXxi4rzqqc2LGnWgVkJhOztC5zO05D1oRo2+Ee77R7sVutsE6jyu+peHTv/VqlC 166KS4wAYJABy6GOS6HPyhloKAYMNbYU+3RgYK62xad6ZjVtr8KaX9AlZMV0jrXDYIK2 +iCNe8WxoZffEf6BBZLYZIyxMv7qbWI6rmsTN2nBEpXQ+Jjpz02+PKrc1SXuql5buh5T xlfw== X-Gm-Message-State: AOAM530mg5+IqRaAn6LWilsz8lOiUKOJnKjdf1izxQbJFtKZYHbonEr2 YwTQTBBGHb4ub4wLlQKt0HjmgkoMG0Kvei8F3J02jq0W X-Google-Smtp-Source: ABdhPJzDOcRGcu/omuoxDQh80S1iPO1rtFMAAx5btw15bow00r8voF+MKPLKN5hx7P8dc/a14HmvsbGZGGwi2KqZmek= X-Received: by 2002:a17:90b:3b82:: with SMTP id pc2mr10197669pjb.120.1636377235061; Mon, 08 Nov 2021 05:13:55 -0800 (PST) MIME-Version: 1.0 References: <20211107160829.1004634-1-hjl.tools@gmail.com> <2e15794f-555c-30f1-f774-f23839146da6@linaro.org> In-Reply-To: <2e15794f-555c-30f1-f774-f23839146da6@linaro.org> From: "H.J. Lu" Date: Mon, 8 Nov 2021 05:13:19 -0800 Message-ID: Subject: Re: [PATCH] test-memcpy.c: Double TIMEOUT to (8 * 60) To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 13:13:58 -0000 On Mon, Nov 8, 2021 at 3:39 AM Adhemerval Zanella wrote: > > > > On 07/11/2021 13:08, H.J. Lu via Libc-alpha wrote: > > commit d585ba47fcda99fdf228e3e45a01b11a15efbc5a > > Author: Noah Goldstein > > Date: Mon Nov 1 00:49:48 2021 -0500 > > > > string: Make tests birdirectional test-memcpy.c > > > > This commit updates the memcpy tests to test both dst > src and dst < > > src. This is because there is logic in the code based on the > > > > Signed-off-by: Noah Goldstein > > Reviewed-by: H.J. Lu > > > > significantly increased the number of tests. On Intel Core i7-1165G7, > > test-memcpy takes 120 seconds to run when machine is idle. Double > > TIMEOUT to (8 * 60) for test-memcpy to avoid timeout when machine is > > under heavy load. > > Shouldn't we split the test instead? If it takes 120s on a high-end chip, > it might take way more in other chips. It also optimizes the testsuite, > since it would allow to better use parallel builds. This sounds like a good idea. Noah, can you do that? Thanks. > > --- > > string/test-memcpy.c | 1 + > > string/test-string.h | 4 +++- > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/string/test-memcpy.c b/string/test-memcpy.c > > index 3b0f3127b7..101d51c487 100644 > > --- a/string/test-memcpy.c > > +++ b/string/test-memcpy.c > > @@ -22,6 +22,7 @@ > > # define MIN_PAGE_SIZE 131072 > > # define TEST_MAIN > > # define TEST_NAME "memcpy" > > +# define TIMEOUT (8 * 60) > > # include "test-string.h" > > > > char *simple_memcpy (char *, const char *, size_t); > > diff --git a/string/test-string.h b/string/test-string.h > > index 8ee00a04b1..9a6b76daa4 100644 > > --- a/string/test-string.h > > +++ b/string/test-string.h > > @@ -68,7 +68,9 @@ extern impl_t __start_impls[], __stop_impls[]; > > > > > > # define TEST_FUNCTION test_main > > -# define TIMEOUT (4 * 60) > > +# ifndef TIMEOUT > > +# define TIMEOUT (4 * 60) > > +# endif > > # define OPT_ITERATIONS 10000 > > # define OPT_RANDOM 10001 > > # define OPT_SEED 10002 > > -- H.J.