From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by sourceware.org (Postfix) with ESMTPS id CBABF3849AEF for ; Sat, 13 Apr 2024 15:57:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBABF3849AEF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CBABF3849AEF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713023834; cv=none; b=Dtlq0pC57STVWZxRwDn1VtviGfwfABZnfr+XYqeYSZkjFAaeYoD3La1aBcyb/f6UsAK/IPlVaWtK0JUA677eVWNXjolkRB5bLoGEWo09Fn87tced7JDZ5Ugde+t+B8OPSx+ZAnp7Y6U2KB83oXsiplsfGpQHfWpjqLajTOJpl+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713023834; c=relaxed/simple; bh=KZYpU9M16q+Cn6b/QLCscjqOgnbFPTsFGtuapAzFiRo=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=oWY7af360kHLY7w+YMwD6vzvkYWGo7xvn89UdNe8nZU5H7N7MAU3+N/i7ytuAPWw7PrEPgwzXtYeNnzVzyihmTLFeQTPblU160XFFYZoWvkafQfJ+HF+Tzj29GRnN2jIQS9RNvVPBNUFKDfO5ykAWeG2tJjJjw7YS12KR+kkFG8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-61816fc256dso17068317b3.0 for ; Sat, 13 Apr 2024 08:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713023832; x=1713628632; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t/5upvT3hIqr6XQWvFrhJaxS9ZOhw1Pv5yCWFcD0V6w=; b=cVlf8Vtd7oj/t2hMwK+SnSYcGY+5mdyHHC72ohmwX6m6JQhJR5QMD6E3FO42rwhFox GabgJ8iXeaQZu7yDMx9nlRELk0cuA2G9JrwRF8sbCmsn1cZnHmDQlLcM7OPauT/K4705 lXHo7J7ZwelSOSmF0jSpN+eDWziSA63rOG20iJgujjyU+tliG9+S8PJmDWgOAxFTSp36 ha3M8oagpUnvJ4uI+4OlgxkBcQbgU4dwrMtcA446PkQd0rrw/ABrOKwNxgeQ3qIqqbQt Vp1yvZgkN249GhRpvrD/arVEkhGHHWCFvTXEPuM/aVcmdKujnVBMiaAsZtlvTYMPC44i /eoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713023832; x=1713628632; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t/5upvT3hIqr6XQWvFrhJaxS9ZOhw1Pv5yCWFcD0V6w=; b=MMYnU849D7T4lQo4KjfNLnduRPNLQHWEyWQFN8rEr8exObE/Xyzvu3WUG5SMqcvFbP DJbxtt503S+H6YzUZ81dUhVw5QNh7fAEgzOFOjSCFk9koH98RbCBYbDXjDDU7ebZA6sY VS+AjrMZlUz0P2IB540eiYRX34OTyIGqXoOyzf4H2n/it3PcJqh+ShHJCIN8IukqznjP J3DKT5yEITtrRZHAzTpJ7Q+JApU1F/N60kXLf0rroofzt78Qlga/kCf35B3gfzUot/hd WsUeiWrDX3elt6Se7i/ssDaWeXXHTgcJDmn2trmtit+2z5FYnq414IWxn4Z+Yrhp7HLv C6KA== X-Gm-Message-State: AOJu0YzOcYscHR5wU5i56IC+460PJzSpWhZz94xhWd7zZpIilv0sfxWS yUfZckbfclfppxjfNW38lIjUYleCXT1JYT/m4Vea4WiRm/HCHaYOqDvtwJfpflYk8yWFTAtl0jq UwWumXeNQnEHsJBrLO1PnQUDdzk2S3w== X-Google-Smtp-Source: AGHT+IE4PeaiF7RxqYZoFnp5EW+PbAmXR+G2iVjEPPJpe8L8Lw/KhhpUQT1jvkzERsvk+30b2xwfHUbsq5W1td1hMyA= X-Received: by 2002:a81:b204:0:b0:614:64f:7df1 with SMTP id q4-20020a81b204000000b00614064f7df1mr4798079ywh.3.1713023832093; Sat, 13 Apr 2024 08:57:12 -0700 (PDT) MIME-Version: 1.0 References: <87a5lx2u9a.fsf@oldenburg.str.redhat.com> <875xwl2tku.fsf@oldenburg.str.redhat.com> <871q792ssr.fsf@oldenburg.str.redhat.com> <87plut1cqd.fsf@oldenburg.str.redhat.com> In-Reply-To: <87plut1cqd.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Sat, 13 Apr 2024 08:56:36 -0700 Message-ID: Subject: Re: [PATCH] Revert "x86_64: Suppress false positive valgrind error" To: Florian Weimer Cc: libc-alpha@sourceware.org, Sunil K Pandey Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Apr 13, 2024 at 8:52=E2=80=AFAM Florian Weimer = wrote: > > * H. J. Lu: > > > On Sat, Apr 13, 2024 at 8:27=E2=80=AFAM H.J. Lu w= rote: > >> > >> On Sat, Apr 13, 2024 at 8:20=E2=80=AFAM Florian Weimer wrote: > >> > > >> > * H. J. Lu: > >> > > >> > > On Sat, Apr 13, 2024 at 8:03=E2=80=AFAM Florian Weimer wrote: > >> > >> > >> > >> * H. J. Lu: > >> > >> > >> > >> > On Sat, Apr 13, 2024 at 7:49=E2=80=AFAM Florian Weimer wrote: > >> > >> >> > >> > >> >> This reverts commit a1735e0aa858f0c8b15e5ee9975bff4279423680. > >> > >> >> > >> > >> >> The test failure is a real valgrind bug that needs to be fixed= before > >> > >> >> valgrind is usable with a glibc that has been built with > >> > >> >> CC=3D"gcc -march=3Dx86-64-v3". The valgrind fix addresses the= observed > >> > >> >> test failure as well. > >> > >> >> > >> > >> >> Upstream bug: > >> > >> >> > >> > >> >> Tested on x86_64-linux-gnu with and without CC=3D"gcc -march= =3Dx86-64-v3". > >> > >> >> The elf/tst-valgrind-smoke tests again fails with an unpatched= valgrind, > >> > >> >> and the proposed upstream patch fixes it. (Apparently, valgri= nd > >> > >> >> matches on soname, and not the file name, which is ld.so in th= e test.) > >> > >> > > >> > >> > Please clarify that your patch fixes the glibc valgrind test by= not using > >> > >> > strcmp-avx2.S in the valgrind test. > >> > >> > >> > >> Sorry, clarify where? In the commit message here? On the upstre= am bug? > >> > > > >> > > In the glibc commit message. > >> > > > >> > >> My valgrind patch replaces the strcmp implementation in ld.so wit= h its > >> > >> own. > >> > >> > >> > > > >> > > Please mention it in the glibc commit message. > >> > > >> > Okay, I'll send a v2. > >> > > >> > Could someone proficient in x86-64 assembly have a look at my strcmp > >> > implementation? > >> > >> Can you adapt sysdeps/i386/i686/strcmp.S for valgrind? > >> > > > > You can use sysdeps/x86_64/strcmp.S from glibc 2.10: > > True. It's mostly a licensing matter at this point. The copyright > notice is longer than the assemly =E2=80=A6 > You can hook your strcmp into glibc and run the glibc strcmp test. If it passes the test, it is good to go. --=20 H.J.