From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id DD0D9385801D for ; Fri, 10 Dec 2021 18:58:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD0D9385801D Received: by mail-pg1-x532.google.com with SMTP id k4so8811542pgb.8 for ; Fri, 10 Dec 2021 10:58:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iXovw2eyiiiq0rBYJrflgqzccNuMz6+za3RNnGJ4uNI=; b=jlzmBRU9W1rsK0J8RYLg+tb0eno3aHxzsAbEHe+3DxXQGU2dKyB0wZHh8irtzUHm29 SCyXcghXTdJijFTF0+x6s8oT4PX0v2+247RH7qV55y3cYJ0mjlIbbzcDSxSKul1Ao0bt ytzihhXhkds6QO/rUpJr6OngaEfFezvUCxj6JZNxWeVHJvauORBQ05A8rydi15ypWCpe 8TpJeTgMgJvLukOw3BEUMHK0i/IUFwH0QshNtkrFu1S4iSDM5jszQ8QzgDGgRCtnXQ6U /xc6P0EdJBSVSRDbN/j00Dc52ULLMVr+4DlH36PLtYybcEs1VVGrKeniYwxqmGZVTQBd kqhw== X-Gm-Message-State: AOAM530ep4cg7gsN0Nk2Bl+Z1dDe7+e7FHvPO8wW7gbftOdHGERwGIQV Soke352SUsokod7yk2eJ1f/seMlAL/RLAdGWOto= X-Google-Smtp-Source: ABdhPJxmFnd29+O/0m+c4s7weEa0SFRgIxaxySQyvDVLgIdlSQon73a8dGXyOPLGYypB3jPXHa2GirSQz4L1/fyD+TI= X-Received: by 2002:a05:6a00:8cd:b0:4a2:82d7:1703 with SMTP id s13-20020a056a0008cd00b004a282d71703mr20004088pfu.43.1639162698013; Fri, 10 Dec 2021 10:58:18 -0800 (PST) MIME-Version: 1.0 References: <20211204045848.71105-1-rongwei.wang@linux.alibaba.com> <20211210123911.86568-1-rongwei.wang@linux.alibaba.com> <20211210123911.86568-2-rongwei.wang@linux.alibaba.com> <87ilvw79ax.fsf@oldenburg.str.redhat.com> In-Reply-To: From: "H.J. Lu" Date: Fri, 10 Dec 2021 10:57:42 -0800 Message-ID: Subject: Re: [PATCH v5 1/2] elf: Properly align PT_LOAD segments To: Florian Weimer Cc: Rongwei Wang , GNU C Library , xuyu@linux.alibaba.com, gavin.dg@linux.alibaba.com Content-Type: multipart/mixed; boundary="000000000000585efc05d2cf4e44" X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 18:58:20 -0000 --000000000000585efc05d2cf4e44 Content-Type: text/plain; charset="UTF-8" On Fri, Dec 10, 2021 at 10:54 AM H.J. Lu wrote: > > On Fri, Dec 10, 2021 at 7:45 AM Florian Weimer wrote: > > > > * H. J. Lu: > > > > > Reviewed-by: H.J. Lu > > > > > > I will check it for you. > > > > Please adjust the copyright line due to Signed-off-by. Thanks. > > > > Florian > > This is the patch I am checking in. > > Thanks. > > -- > H.J. This is the right one. -- H.J. --000000000000585efc05d2cf4e44 Content-Type: text/x-patch; charset="US-ASCII"; name="v6-0001-elf-Properly-align-PT_LOAD-segments-BZ-28676.patch" Content-Disposition: attachment; filename="v6-0001-elf-Properly-align-PT_LOAD-segments-BZ-28676.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kx0r407c0 RnJvbSBkMGUyMGJjNDJkNWIwYjIzOTY5Y2MzMmM0Mzk0NDhlNjJjNGNiODMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb25nd2VpIFdhbmcgPHJvbmd3ZWkud2FuZ0BsaW51eC5hbGli YWJhLmNvbT4KRGF0ZTogRnJpLCAxMCBEZWMgMjAyMSAyMDozOToxMCArMDgwMApTdWJqZWN0OiBb UEFUQ0ggdjYgMS8yXSBlbGY6IFByb3Blcmx5IGFsaWduIFBUX0xPQUQgc2VnbWVudHMgW0JaICMy ODY3Nl0KCldoZW4gUFRfTE9BRCBzZWdtZW50IGFsaWdubWVudCA+IHRoZSBwYWdlIHNpemUsIGFs bG9jYXRlIGVub3VnaCBzcGFjZSB0bwplbnN1cmUgdGhhdCB0aGUgc2VnbWVudCBjYW4gYmUgcHJv cGVybHkgYWxpZ25lZC4gIFRoaXMgY2hhbmdlIGhlbHBzIGNvZGUKc2VnbWVudHMgdXNlIGh1Z2Ug cGFnZXMgYmVjb21lIHNpbXBsZSBhbmQgYXZhaWxhYmxlLgoKVGhpcyBmaXhlcyBbQlogIzI4Njc2 XS4KClNpZ25lZC1vZmYtYnk6IFh1IFl1IDx4dXl1QGxpbnV4LmFsaWJhYmEuY29tPgpTaWduZWQt b2ZmLWJ5OiBSb25nd2VpIFdhbmcgPHJvbmd3ZWkud2FuZ0BsaW51eC5hbGliYWJhLmNvbT4KLS0t CiBlbGYvZGwtbG9hZC5jICAgICAgICAgfCAgMiArKwogZWxmL2RsLWxvYWQuaCAgICAgICAgIHwg IDMgKystCiBlbGYvZGwtbWFwLXNlZ21lbnRzLmggfCA1MCArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKystLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDUwIGluc2VydGlvbnMoKyks IDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZWxmL2RsLWxvYWQuYyBiL2VsZi9kbC1sb2Fk LmMKaW5kZXggYmY4OTU3ZTczYy4uNzIxNTkzMTM1ZSAxMDA2NDQKLS0tIGEvZWxmL2RsLWxvYWQu YworKysgYi9lbGYvZGwtbG9hZC5jCkBAIC0xLDUgKzEsNiBAQAogLyogTWFwIGluIGEgc2hhcmVk IG9iamVjdCdzIHNlZ21lbnRzIGZyb20gdGhlIGZpbGUuCiAgICBDb3B5cmlnaHQgKEMpIDE5OTUt MjAyMSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKyAgIENvcHlyaWdodCBUaGUgR05V IFRvb2xjaGFpbiBBdXRob3JzLgogICAgVGhpcyBmaWxlIGlzIHBhcnQgb2YgdGhlIEdOVSBDIExp YnJhcnkuCiAKICAgIFRoZSBHTlUgQyBMaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4g cmVkaXN0cmlidXRlIGl0IGFuZC9vcgpAQCAtMTE1MCw2ICsxMTUxLDcgQEAgX2RsX21hcF9vYmpl Y3RfZnJvbV9mZCAoY29uc3QgY2hhciAqbmFtZSwgY29uc3QgY2hhciAqb3JpZ25hbWUsIGludCBm ZCwKIAkgIGMtPm1hcGVuZCA9IEFMSUdOX1VQIChwaC0+cF92YWRkciArIHBoLT5wX2ZpbGVzeiwg R0xSTyhkbF9wYWdlc2l6ZSkpOwogCSAgYy0+ZGF0YWVuZCA9IHBoLT5wX3ZhZGRyICsgcGgtPnBf ZmlsZXN6OwogCSAgYy0+YWxsb2NlbmQgPSBwaC0+cF92YWRkciArIHBoLT5wX21lbXN6OworCSAg Yy0+bWFwYWxpZ24gPSBwaC0+cF9hbGlnbjsKIAkgIGMtPm1hcG9mZiA9IEFMSUdOX0RPV04gKHBo LT5wX29mZnNldCwgR0xSTyhkbF9wYWdlc2l6ZSkpOwogCiAJICAvKiBEZXRlcm1pbmUgd2hldGhl ciB0aGVyZSBpcyBhIGdhcCBiZXR3ZWVuIHRoZSBsYXN0IHNlZ21lbnQKZGlmZiAtLWdpdCBhL2Vs Zi9kbC1sb2FkLmggYi9lbGYvZGwtbG9hZC5oCmluZGV4IGUzMjlkNDlhODEuLmU2ZGFiY2IzMzYg MTAwNjQ0Ci0tLSBhL2VsZi9kbC1sb2FkLmgKKysrIGIvZWxmL2RsLWxvYWQuaApAQCAtMSw1ICsx LDYgQEAKIC8qIE1hcCBpbiBhIHNoYXJlZCBvYmplY3QncyBzZWdtZW50cyBmcm9tIHRoZSBmaWxl LgogICAgQ29weXJpZ2h0IChDKSAxOTk1LTIwMjEgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJ bmMuCisgICBDb3B5cmlnaHQgVGhlIEdOVSBUb29sY2hhaW4gQXV0aG9ycy4KICAgIFRoaXMgZmls ZSBpcyBwYXJ0IG9mIHRoZSBHTlUgQyBMaWJyYXJ5LgogCiAgICBUaGUgR05VIEMgTGlicmFyeSBp cyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKQEAgLTc0LDcg Kzc1LDcgQEAgRUxGX1BSRUZFUlJFRF9BRERSRVNTX0RBVEE7CiAgICBJdHMgZGV0YWlscyBoYXZl IGJlZW4gZXhwYW5kZWQgb3V0IGFuZCBjb252ZXJ0ZWQuICAqLwogc3RydWN0IGxvYWRjbWQKIHsK LSAgRWxmVyhBZGRyKSBtYXBzdGFydCwgbWFwZW5kLCBkYXRhZW5kLCBhbGxvY2VuZDsKKyAgRWxm VyhBZGRyKSBtYXBzdGFydCwgbWFwZW5kLCBkYXRhZW5kLCBhbGxvY2VuZCwgbWFwYWxpZ247CiAg IEVsZlcoT2ZmKSBtYXBvZmY7CiAgIGludCBwcm90OyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgLyogUFJPVF8qIGJpdHMuICAqLwogfTsKZGlmZiAtLWdpdCBhL2VsZi9kbC1tYXAtc2VnbWVu dHMuaCBiL2VsZi9kbC1tYXAtc2VnbWVudHMuaAppbmRleCBmOWZiMTEwZWUzLi43MGE0YzQwNjk1 IDEwMDY0NAotLS0gYS9lbGYvZGwtbWFwLXNlZ21lbnRzLmgKKysrIGIvZWxmL2RsLW1hcC1zZWdt ZW50cy5oCkBAIC0xLDUgKzEsNiBAQAogLyogTWFwIGluIGEgc2hhcmVkIG9iamVjdCdzIHNlZ21l bnRzLiAgR2VuZXJpYyB2ZXJzaW9uLgogICAgQ29weXJpZ2h0IChDKSAxOTk1LTIwMjEgRnJlZSBT b2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisgICBDb3B5cmlnaHQgVGhlIEdOVSBUb29sY2hhaW4g QXV0aG9ycy4KICAgIFRoaXMgZmlsZSBpcyBwYXJ0IG9mIHRoZSBHTlUgQyBMaWJyYXJ5LgogCiAg ICBUaGUgR05VIEMgTGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0 ZSBpdCBhbmQvb3IKQEAgLTE4LDYgKzE5LDUwIEBACiAKICNpbmNsdWRlIDxkbC1sb2FkLmg+CiAK Ky8qIE1hcCBhIHNlZ21lbnQgYW5kIGFsaWduIGl0IHByb3Blcmx5LiAgKi8KKworc3RhdGljIF9f YWx3YXlzX2lubGluZSBFbGZXKEFkZHIpCitfZGxfbWFwX3NlZ21lbnQgKGNvbnN0IHN0cnVjdCBs b2FkY21kICpjLCBFbGZXKEFkZHIpIG1hcHByZWYsCisJCSBjb25zdCBzaXplX3QgbWFwbGVuZ3Ro LCBpbnQgZmQpCit7CisgIGlmIChfX2dsaWJjX2xpa2VseSAoYy0+bWFwYWxpZ24gPD0gR0xSTyhk bF9wYWdlc2l6ZSkpKQorICAgIHJldHVybiAoRWxmVyhBZGRyKSkgX19tbWFwICgodm9pZCAqKSBt YXBwcmVmLCBtYXBsZW5ndGgsIGMtPnByb3QsCisJCQkJTUFQX0NPUFl8TUFQX0ZJTEUsIGZkLCBj LT5tYXBvZmYpOworCisgIC8qIElmIHRoZSBzZWdtZW50IGFsaWdubWVudCA+IHRoZSBwYWdlIHNp emUsIGFsbG9jYXRlIGVub3VnaCBzcGFjZSB0bworICAgICBlbnN1cmUgdGhhdCB0aGUgc2VnbWVu dCBjYW4gYmUgcHJvcGVybHkgYWxpZ25lZC4gICovCisgIEVsZlcoQWRkcikgbWFwbGVuID0gKG1h cGxlbmd0aCA+PSBjLT5tYXBhbGlnbgorCQkgICAgICAgPyAobWFwbGVuZ3RoICsgYy0+bWFwYWxp Z24pCisJCSAgICAgICA6ICgyICogYy0+bWFwYWxpZ24pKTsKKyAgRWxmVyhBZGRyKSBtYXBfc3Rh cnQgPSAoRWxmVyhBZGRyKSkgX19tbWFwICgodm9pZCAqKSBtYXBwcmVmLCBtYXBsZW4sCisJCQkJ CSAgICAgIFBST1RfTk9ORSwKKwkJCQkJICAgICAgTUFQX0FOT05ZTU9VU3xNQVBfUFJJVkFURSwK KwkJCQkJICAgICAgLTEsIDApOworICBpZiAoX19nbGliY191bmxpa2VseSAoKHZvaWQgKikgbWFw X3N0YXJ0ID09IE1BUF9GQUlMRUQpKQorICAgIHJldHVybiBtYXBfc3RhcnQ7CisKKyAgRWxmVyhB ZGRyKSBtYXBfc3RhcnRfYWxpZ25lZCA9IEFMSUdOX1VQIChtYXBfc3RhcnQsIGMtPm1hcGFsaWdu KTsKKyAgbWFwX3N0YXJ0X2FsaWduZWQgPSAoRWxmVyhBZGRyKSkgX19tbWFwICgodm9pZCAqKSBt YXBfc3RhcnRfYWxpZ25lZCwKKwkJCQkJICAgbWFwbGVuZ3RoLCBjLT5wcm90LAorCQkJCQkgICBN QVBfQ09QWXxNQVBfRklMRXxNQVBfRklYRUQsCisJCQkJCSAgIGZkLCBjLT5tYXBvZmYpOworICBp ZiAoX19nbGliY191bmxpa2VseSAoKHZvaWQgKikgbWFwX3N0YXJ0X2FsaWduZWQgPT0gTUFQX0ZB SUxFRCkpCisgICAgX19tdW5tYXAgKCh2b2lkICopIG1hcF9zdGFydCwgbWFwbGVuKTsKKyAgZWxz ZQorICAgIHsKKyAgICAgIC8qIFVubWFwIHRoZSB1bnVzZWQgcmVnaW9ucy4gICovCisgICAgICBF bGZXKEFkZHIpIGRlbHRhID0gbWFwX3N0YXJ0X2FsaWduZWQgLSBtYXBfc3RhcnQ7CisgICAgICBp ZiAoZGVsdGEpCisJX19tdW5tYXAgKCh2b2lkICopIG1hcF9zdGFydCwgZGVsdGEpOworICAgICAg RWxmVyhBZGRyKSBtYXBfZW5kID0gbWFwX3N0YXJ0X2FsaWduZWQgKyBtYXBsZW5ndGg7CisgICAg ICBkZWx0YSA9IG1hcF9zdGFydCArIG1hcGxlbiAtIG1hcF9lbmQ7CisgICAgICBpZiAoZGVsdGEp CisJX19tdW5tYXAgKCh2b2lkICopIG1hcF9lbmQsIGRlbHRhKTsKKyAgICB9CisKKyAgcmV0dXJu IG1hcF9zdGFydF9hbGlnbmVkOworfQorCiAvKiBUaGlzIGltcGxlbWVudGF0aW9uIGFzc3VtZXMg KGFzIGRvZXMgdGhlIGNvcnJlc3BvbmRpbmcgaW1wbGVtZW50YXRpb24KICAgIG9mIF9kbF91bm1h cF9zZWdtZW50cywgaW4gZGwtdW5tYXAtc2VnbWVudHMuaCkgdGhhdCBzaGFyZWQgb2JqZWN0cwog ICAgYXJlIGFsd2F5cyBsYWlkIG91dCB3aXRoIGFsbCBzZWdtZW50cyBjb250aWd1b3VzIChvciB3 aXRoIGdhcHMKQEAgLTUzLDEwICs5OCw3IEBAIF9kbF9tYXBfc2VnbWVudHMgKHN0cnVjdCBsaW5r X21hcCAqbCwgaW50IGZkLAogICAgICAgICAgICAtIE1BUF9CQVNFX0FERFIgKGwpKTsKIAogICAg ICAgLyogUmVtZW1iZXIgd2hpY2ggcGFydCBvZiB0aGUgYWRkcmVzcyBzcGFjZSB0aGlzIG9iamVj dCB1c2VzLiAgKi8KLSAgICAgIGwtPmxfbWFwX3N0YXJ0ID0gKEVsZlcoQWRkcikpIF9fbW1hcCAo KHZvaWQgKikgbWFwcHJlZiwgbWFwbGVuZ3RoLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjLT5wcm90LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBNQVBfQ09QWXxNQVBfRklMRSwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZmQsIGMtPm1hcG9mZik7CisgICAgICBsLT5sX21hcF9zdGFy dCA9IF9kbF9tYXBfc2VnbWVudCAoYywgbWFwcHJlZiwgbWFwbGVuZ3RoLCBmZCk7CiAgICAgICBp ZiAoX19nbGliY191bmxpa2VseSAoKHZvaWQgKikgbC0+bF9tYXBfc3RhcnQgPT0gTUFQX0ZBSUxF RCkpCiAgICAgICAgIHJldHVybiBETF9NQVBfU0VHTUVOVFNfRVJST1JfTUFQX1NFR01FTlQ7CiAK LS0gCjIuMzMuMQoK --000000000000585efc05d2cf4e44--