From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by sourceware.org (Postfix) with ESMTPS id 057433858C35 for ; Fri, 9 Feb 2024 13:19:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 057433858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 057433858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707484780; cv=none; b=GYSjk/Ov5z9XwHDCROVEyNA/rT35skAWvyqPDttcnHkDN0bW/e3sC5M8PvwhSQMGGaCnASXvpbHLlNdhu8e4hkIo3KTQX3UokoD/C+nCGHW3K5pFUnRpV0yOXQMno0I+uhOqjTk+66BQKIkSp+jMAj8kIfwyJ64KWghsQuzgshY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707484780; c=relaxed/simple; bh=nESVVD96WXalE4BAOJ9SNYnnwg27rWTG/GWx0Mey1cg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=uOLMTCf7dklNNeGYu+Lj0ZgxlrSdeD5ug7giNglZvfmWGnemm/vLn160xtz0egxGmhiNcfCylrQQifZmkos4pgua9/wi0i0HKxcyyG/CYnWY7hcm3DQM0ggCdzL0K6nPbhJ21whIca80G7hC6mpo9hmD51zAHJkKkdNdqn17J4E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-dc6e08fde11so951944276.1 for ; Fri, 09 Feb 2024 05:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707484778; x=1708089578; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iJZoCXYvxMWbdv2C5N0BawDcirbSDhrlLxtdsgUgs4U=; b=FWHzJ7ZnXYaJiSV1ld8455xscrT8UCHlfIjwg+nYqoeMJpKSFgQV3TaBEmpELjPuPZ kuyz9L5tLCDbDvemtY7jX2WYwZYnJ8YzwWN612+1LAyjaMcp6ir2ucZpgHYch+sBiE2P MGtzg2k6+JGkzysqATS8fVg54RRj4+2NBnhwZnqa3z9c+Kl/p3jRSh8E4SZVuzSiSbji ZEp/8ejoz7yGJDSkbGRTkWJGHm9GP/xPYPc10mMIcJeNBD8i5K8i3c7s1QDg8IIM1bkQ dXc9kWehVjIUSWXZzOs1ClNuCmbSg9zjVjh6iz/rqZU4t3PhJLmFwokC7HoQ9OF8eoRd Q+kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707484778; x=1708089578; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iJZoCXYvxMWbdv2C5N0BawDcirbSDhrlLxtdsgUgs4U=; b=RRj/TY+Eo0VXgNdXu6ygKnlQio7Kf+LC8/ozvlcDurc2xt/JuGV3TFoYiZO1iuSajM if5YL1HBDqKUbQlrQQNskBLfWpCv1GNWSLNoLGhnd4hDQgu8V9U95Fh2srr0yyT/Y9Rd n0nnQvvJXIZ2bZpPFVHGbotP//sPHyYb28tcgpxxRbNLfJwvGOM7pnsU4dEThnWoedq1 ff7BgLg8Kn0QoX0HtMatRBk53duyBf3mxZhI0Zti1CgQwNvV8aVd4HNqWPCavS55j4hD jlpMnh4VrS5FGScrfORiPZeviOT0JnJ4LnAvqSAO0KBAeOtFcwMub3niG9wam0sU5PUb SO/A== X-Gm-Message-State: AOJu0YwO+cGDd5YQJsnsi82zVfuyvAX7apcbROvi2mmLIA7zLzXHBeZJ 875VYwX3g+ewOcA7Smxr7PdR1TwccwKSPWEd6snhpqeB6AQMJyUtiI6fYaFR6YHPphqznQ1AbqT 7y3XU0UZeagyIBxB4E804DC8/39w= X-Google-Smtp-Source: AGHT+IFEl0kHTScrqCuXgNTjeb+ktEvYcrGiwxrehGAdsT0KihblE1ataCIHF6Tg/ES0Us12ebUO6AnUf2sWtuedu3c= X-Received: by 2002:a05:6902:cc6:b0:dbe:9509:141c with SMTP id cq6-20020a0569020cc600b00dbe9509141cmr1390005ybb.30.1707484778184; Fri, 09 Feb 2024 05:19:38 -0800 (PST) MIME-Version: 1.0 References: <20240209125449.2352780-1-hjl.tools@gmail.com> <87jznd7pxj.fsf@oldenburg.str.redhat.com> In-Reply-To: <87jznd7pxj.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Fri, 9 Feb 2024 05:19:01 -0800 Message-ID: Subject: Re: [PATCH] elf: Properly remove the initial 'env' command To: Florian Weimer Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3014.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 9, 2024 at 5:00=E2=80=AFAM Florian Weimer = wrote: > > * H. J. Lu: > > > index 9e70e74bf8..dfba94de64 100644 > > --- a/elf/tst-rtld-list-diagnostics.py > > +++ b/elf/tst-rtld-list-diagnostics.py > > @@ -294,7 +294,11 @@ def main(argv): > > check_consistency_with_manual(opts.manual) > > > > # Remove the initial 'env' command. > > - parse_diagnostics(opts.command.split()[1:]) > > + options =3D [] > > + for o in opts.command.split()[0:]: > > + if o !=3D 'env': > > + options.append(o) > > + parse_diagnostics(options) > > I think you can write this as: > > options =3D opts.command.split()[:] > options.remove('env') > > It only removes the first occurrence, but I think that is more correct > anyway. > Fixed in v2. Thanks. --=20 H.J.