From: "H.J. Lu" <hjl.tools@gmail.com>
To: Rongwei Wang <rongwei.wang@linux.alibaba.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Align argument of __munmap to page size [BZ #28676]
Date: Mon, 13 Dec 2021 19:34:45 -0800 [thread overview]
Message-ID: <CAMe9rOoZS5V-UZ6CMhSaYWfzMp3_oJtNnrPJLw=hkG36FX32UQ@mail.gmail.com> (raw)
In-Reply-To: <3e6b30a4-cf8a-49c9-7382-3f3255c8201a@linux.alibaba.com>
On Mon, Dec 13, 2021 at 6:49 PM Rongwei Wang
<rongwei.wang@linux.alibaba.com> wrote:
>
> Hi, HJ
>
> Thanks for your help to fix this bug. And I just found out that the
> patch "elf: Properly align PT_LOAD segments" had been merged into
> glibc/master.
>
> And I saw Florian's email:
>
> > We should check munmap failure though and rollback everything if
> > necessary. It's possible we can undo the initial PROT_NONE mapping even
> > if future munmap calls fail because unmapping the first mapping does not
> > need to split a mapping.
>
> It seems rollback initial PROT_NONE mapping when munmap fails is good
> idea. Nice to have. Of course, IMO, this your patch is also can fix this
> munmap failure well. what do you think?
>
> When this fix is stable in glibc upstream, I will backport it into our
> internal glibc repo. So, if you have any improve this fix suggestions, I
> will respond immediately. Sorry for my speed is much slower than your.
>
>
Let's wait for a few days.
--
H.J.
next prev parent reply other threads:[~2021-12-14 3:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 15:20 H.J. Lu
2021-12-14 2:49 ` Rongwei Wang
2021-12-14 3:34 ` H.J. Lu [this message]
2021-12-14 7:40 ` Florian Weimer
2021-12-14 13:48 ` H.J. Lu
2021-12-14 14:24 ` Florian Weimer
2021-12-14 15:15 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOoZS5V-UZ6CMhSaYWfzMp3_oJtNnrPJLw=hkG36FX32UQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=rongwei.wang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).