From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by sourceware.org (Postfix) with ESMTPS id 6F8653858D37 for ; Thu, 1 Sep 2022 16:27:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F8653858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-x734.google.com with SMTP id a10so9859766qkl.13 for ; Thu, 01 Sep 2022 09:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Uu8DzoFUa5RpS86TJgrz0ije8XxAiW/RLmh8mUvHKHQ=; b=WAx+eo5FNetM8CHupL18wrxRpQiKwUUBVZmx2ek/5Y7THboBbW72lxnWeeYXpq4DcK vI92w6cBAgHeKhasbAf/yMkLsH0t/M28oiLTp0plNIlHx/pWeikyI7mgJaaRrJAxxfCY tf9Pxi3cD97BLHcd3GoSxB/GP29lXa5BLLPne3VlBaEall7NHCPrjNxfNWU/lV9Fa8NK 8dhK+1hjgSpSVsn/7vItC35ltZ5e2vvrJyy9z0GgVsqSYRhNsuNf27Zif33a+45/4BSG AhWCJuFOz3FbEfTBiWpwMVxKsUYAWlKkwsaggj+zXh1m68RTjPxudeGQtgl/+ry3vUc5 LvQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Uu8DzoFUa5RpS86TJgrz0ije8XxAiW/RLmh8mUvHKHQ=; b=BBKGbT0kn/Kn5wXIJxGrght7r2vt0zIPTuc8gB4SxSzTwXnuP1frJTodyM5H4KPjjP wihV0FPhHpBSQhIAD25cZtdcalDRofCYGXWEfy4COYpQqdL5ori6lmgwz68nwbO/hc5y 552mIoERe5TttTTq3QcavMXXBqElS15kQrRSd7tDT9vyE1JCEG/lRy5tamXWo5z5SLP9 RcMkn3pvm884Tv8Uyy2MBdzGTDO/JSrXZNtmLg6YFFGuR1F3D3PyBaRNf2Tm7BoQkL79 TN4Qzel83K2QEXw1jWCLpLDFjsMIvkikOJKXizuE35Vj8yr9StkKx9Zdu+RbwzpGYjvl qXWg== X-Gm-Message-State: ACgBeo3pP29DuAwkLY1DWh+qHqFNAg+esZPVF89KAiHPAJveFfqGGXmV VWNoXAOW1JcFl9ZEJFPExebKD90xW6dUQ59MMvq14VGn X-Google-Smtp-Source: AA6agR6oP+f40DT+g3PFunJ6d57X1D+KIQWx6MojpvFulUrVR2RprauK0KWBaB0nHwbBK0BiWracx/h+WZHy8kOjUeA= X-Received: by 2002:a05:620a:2699:b0:6b8:c299:23c2 with SMTP id c25-20020a05620a269900b006b8c29923c2mr19849122qkp.768.1662049646776; Thu, 01 Sep 2022 09:27:26 -0700 (PDT) MIME-Version: 1.0 References: <20220831181443.3875972-1-adhemerval.zanella@linaro.org> <612f2a05-2e13-007c-0168-7d6eb9559554@linaro.org> <02ecae64-64cf-bb6c-1adf-d680d7ab5bed@linaro.org> In-Reply-To: <02ecae64-64cf-bb6c-1adf-d680d7ab5bed@linaro.org> From: "H.J. Lu" Date: Thu, 1 Sep 2022 09:26:50 -0700 Message-ID: Subject: Re: [PATCH] math: x86: Remove extra '%' on FP_INIT_ROUNDMODE inline asm To: Adhemerval Zanella Netto Cc: joseph_myers@mentor.com, GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3024.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Sep 1, 2022 at 8:23 AM Adhemerval Zanella Netto wrote: > > > > On 01/09/22 11:51, H.J. Lu wrote: > > On Thu, Sep 1, 2022 at 6:01 AM Adhemerval Zanella Netto > > wrote: > >> > >> > >> > >> On 31/08/22 16:33, H.J. Lu wrote: > >>> On Wed, Aug 31, 2022 at 11:16 AM Adhemerval Zanella via Libc-alpha > >>> wrote: > >>>> > >>>> Checked on x86_64-linux-gnu. > >>>> --- > >>>> sysdeps/x86/fpu/sfp-machine.h | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/sysdeps/x86/fpu/sfp-machine.h b/sysdeps/x86/fpu/sfp-machine.h > >>>> index 5892f4f5fe..1cacdb4ebd 100644 > >>>> --- a/sysdeps/x86/fpu/sfp-machine.h > >>>> +++ b/sysdeps/x86/fpu/sfp-machine.h > >>>> @@ -41,7 +41,7 @@ typedef unsigned int UTItype __attribute__ ((mode (TI))); > >>>> > >>>> # define FP_INIT_ROUNDMODE \ > >>>> do { \ > >>>> - __asm__ __volatile__ ("%vstmxcsr\t%0" : "=m" (_fcw)); \ > >>>> + __asm__ __volatile__ ("vstmxcsr\t%0" : "=m" (_fcw)); \ > >>>> } while (0) > >>>> #else > >>>> # define _FP_W_TYPE_SIZE 32 > >>>> -- > >>>> 2.34.1 > >>>> > >>> > >>> The intention was to generate stmxcsr with SSE and vstmxcsr with > >>> AVX. I think we should define a special prefix, like AVX_INSN_PREFIX, > >>> which is 'v' if __AVX__ is defined and empty if __AVX__ isn't defined. > >>> > >> > >> Right, I was not aware of it. Is is documented on gcc inline assembly > > > > I need to take a look. > > Thanks. > > > > >> manual somewhere (I could not find it)? In any case I will follow your > >> suggestion. > > > > There is no need for it. %v is handled by compiler with an operand. > > Not by all compilers in fact, that's why I proposing the change. Then my scheme should work. -- H.J.