From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by sourceware.org (Postfix) with ESMTPS id EFC7C384404C for ; Mon, 27 Jul 2020 11:56:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EFC7C384404C Received: by mail-il1-x143.google.com with SMTP id r12so12793292ilh.4 for ; Mon, 27 Jul 2020 04:56:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZdOr1IGmalESZFKggjp1luCiTD+Ld9RbV97lQFlvYxI=; b=sQrUKPiwP6DzEmqxvN0RECwupCeeIuCNp6R9WxaJkojtZ/Gvk9JoaKLc5gP2x7nlaH 3PLFoKYzQPyGNB9q7Q1DBN2fknlMZi3jKQ79JM2uGWMxC+MpcxCDgq9Ss0gTZ4HMCBrK Wf15uWJ/buUKzJeUk2XDLMU3HhC3xkGEASg89O85bjspHP/+kbaP86+pe20MumpNRMhR Ta2ADubl0unl8ZX1aySPRff8HkFX5reRYYNnEbWbhosAmTXZlpQ7b6Z1s3TPAFui7C8R db7TaZkpM/v3XtQg43Iox3EcoSbqZvq/5lROSHuvyfBjXztSXtxKsFzi1ByAA8b1GKnJ G64g== X-Gm-Message-State: AOAM530XdQEl2xPmHIjcd2/cRV5VUBH0XR3vNfIHoumfuJCPQF6iin7v SloDx21nX6dziJwMqqXDt3IqRalc4JEsYqbxAo8= X-Google-Smtp-Source: ABdhPJyEOsnUMRozwuQzg1O6Zrvkv2tSp87AAOg0/Qi1UMGNTXmk3csdko9E/tLfqRmQmwV8HDyo6eJqkGMtBlqUXMc= X-Received: by 2002:a92:40cc:: with SMTP id d73mr12011327ill.213.1595850961484; Mon, 27 Jul 2020 04:56:01 -0700 (PDT) MIME-Version: 1.0 References: <20200716112651.2257283-1-hjl.tools@gmail.com> <87o8ofy8e7.fsf@oldenburg2.str.redhat.com> <56cafa21-37ea-b39e-8c84-afb258f0d17a@redhat.com> <87sgdqp434.fsf@oldenburg2.str.redhat.com> <180ab9db-d012-52c9-736f-437eecafc35b@redhat.com> <91e0af7e-5f5c-a994-d7bf-dd94c45dcd71@redhat.com> <6276e59d-a363-32a8-10b1-5e19dc065d6d@redhat.com> <6396e998-af22-deaf-3127-257059f9f46b@redhat.com> <87y2n54hv4.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87y2n54hv4.fsf@oldenburg2.str.redhat.com> From: "H.J. Lu" Date: Mon, 27 Jul 2020 04:55:25 -0700 Message-ID: Subject: Re: [PATCH] nptl: Zero-extend arguments to SETXID syscalls [BZ #26248] To: Florian Weimer Cc: "Carlos O'Donell via Libc-alpha" , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 11:56:03 -0000 On Sun, Jul 26, 2020 at 11:00 PM Florian Weimer wrote: > > * Carlos O'Donell via Libc-alpha: > > > We can't fix this easily quickly. > > We can make this test a non-container xtest today. It's better than no > test at all. > Currently this test is in sysdeps/unix/sysv/linux/x86_64/x32/tst-setgroups.c since there are static int do_test (void) { int size; /* NB: Stack address is at 0xfffXXXXX. */ gid_t list[NGROUPS_MAX]; int status = EXIT_SUCCESS; and x32 stack starts at 0xfffXXXXX, which triggers this bug. Should it be moved to nptl/tst-setgroups.c? -- H.J.