From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Pawar, Amit" <Amit.Pawar@amd.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH x86_64] Update memcpy, mempcpy and memmove selection order for Excavator CPU BZ #19583
Date: Thu, 17 Mar 2016 11:53:00 -0000 [thread overview]
Message-ID: <CAMe9rOo_pgS7Vh1+JGWiYbHr3yXZmRDpxaLX6Xs9dzHr-TSH1A@mail.gmail.com> (raw)
In-Reply-To: <SN1PR12MB073325E2FB320E3CECD22660978B0@SN1PR12MB0733.namprd12.prod.outlook.com>
On Thu, Mar 17, 2016 at 3:52 AM, Pawar, Amit <Amit.Pawar@amd.com> wrote:
> This patch is fix for https://sourceware.org/bugzilla/show_bug.cgi?id=19583
>
> As per the suggestion, defining new bit_arch_Prefer_Fast_Copy_Backward and index_arch_Prefer_Fast_Copy_Backward feature bit macros to update IFUNC selection order for memcpy, memcpy_chk, mempcpy, mempcpy_chk, memmove and memmove_chk functions without affecting other targets. PFA patch and ChangeLog files to this mail. If OK please commit it from my side.
>
>
A few comments:
1. Since there is bit_arch_Fast_Copy_Backward already, please
add bit_arch_Avoid_AVX_Fast_Unaligned_Load instead.
2. Please verify that index_arch_XXX are the same and use
one index_arch_XXX to set all bits. There are examples in
sysdeps/x86/cpu-features.c.
3. Please use proper ChangeLog format:
* file (name of function, macro, ...): What changed.
--
H.J.
next prev parent reply other threads:[~2016-03-17 11:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 10:52 Pawar, Amit
2016-03-17 11:53 ` H.J. Lu [this message]
2016-03-17 14:16 ` Pawar, Amit
2016-03-17 14:46 ` H.J. Lu
2016-03-18 11:43 ` Pawar, Amit
2016-03-18 11:51 ` H.J. Lu
2016-03-18 12:25 ` Pawar, Amit
2016-03-18 12:34 ` H.J. Lu
2016-03-18 13:22 ` Pawar, Amit
2016-03-18 13:51 ` H.J. Lu
2016-03-18 13:55 ` Adhemerval Zanella
2016-03-18 14:43 ` H.J. Lu
2016-03-18 14:45 ` H.J. Lu
2016-03-18 15:19 ` Pawar, Amit
2016-03-18 15:24 ` H.J. Lu
2016-03-22 11:08 ` Pawar, Amit
2016-03-22 14:50 ` H.J. Lu
2016-03-22 14:57 ` Pawar, Amit
2016-03-22 15:03 ` H.J. Lu
2016-03-23 10:12 ` Pawar, Amit
2016-03-23 17:59 ` H.J. Lu
2016-03-28 7:43 ` Pawar, Amit
2016-03-28 12:12 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOo_pgS7Vh1+JGWiYbHr3yXZmRDpxaLX6Xs9dzHr-TSH1A@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=Amit.Pawar@amd.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).