From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by sourceware.org (Postfix) with ESMTPS id 056EE3858D1E for ; Tue, 21 May 2024 15:41:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 056EE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 056EE3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1132 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716306080; cv=none; b=SovwnkdV0imDC8nwwxHc//MOyj37zgC24ovAFM5mubQGVB0PqVYMm5F0toKpNL4G54xAUe03V7sL2mKEoq8oNOjN7SKC65AiUfw1QbCyg71HxzsFvfLjj0xnsopSJv4Jg4UxrBMLFd9nH2ofwpUwNesIWuWJjL9VR580Y9GIfok= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716306080; c=relaxed/simple; bh=M/jZLpUZDD7bnZ7knrNF6Fj9hDIWhD+zXayvhJ7wNYQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=GT8N8xIOpbW/mTtBG5LT41npcV9TtBRZ+X5RlQ9ci0Bn4m7rEIa7Yu3vtSeFIg6NgTCZyZYFYsR67AydVLFoz9qEDQ4abi6wRbGOGd43dlo7P3uDPVUhMCkRckiKwOLVuAtINAByhZ27qdEpntr7/qJ4y+T3TNTVhLCQy6OgHD4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-61e0c1ec7e2so30658667b3.0 for ; Tue, 21 May 2024 08:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716306078; x=1716910878; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gm3DBRX6p99ErWfdl0UTp8eAXHopj2bg52BYYpzGbq8=; b=mZV9wthgM4i0DGtFlLNesM/LAHvvaIHA7dde0+hqUet2HIvCM3KoJa7mzhswQiAgl3 spssnl8eMvpsc5HyIm56gWyo4g7cdciuv/PaHhJ041aox5lgctYELmjyV8+yCe32xlhe k4cH+MW6bk4lbr1/yEUjxL07hsjr1O3vWys4p5m2k1Da9m2i75MvXza6rqLu9BgK3fpG BhMWkLJQLLcfPNssYGAbPKeE50mCs2sMFvdqCNfsE/uK2Gu2BPdOeBzFUph18f9rdPfD LnwBCxlu6cyHWMdzrgBebGryDNb/PsxkpmYb1R8Jp5J6uQS6W2ArbfcLfq3uQnRKv0Vk 59RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716306078; x=1716910878; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gm3DBRX6p99ErWfdl0UTp8eAXHopj2bg52BYYpzGbq8=; b=mpMq/er/e8/CE7WHipBREM6A+GCBxECU8fNP0jc+II/gAIkqWUU3Xwj/l9rt/iTI0E f/cjDqu6U/dOMoHSM0KGY9nNGc1O/eJYtBGDiTIKt8766qVQPLt3i6kEN6mqlxtxRppH 9/PPnGqQXE+cJKMMnq1odxh/HGYK3GcvoCDA7rAWSueVC3t/O1NI0mp/+i3D/F6Dvlvz K3fadnkY4/MHTfGwDC/E3JYkR79E9IsGxKVV1PBKiN1zo7M15P58+HoDb8l+Gs9QvdKH 9/9nznO82geAvMXEzw3eXa67zXEusrQ4kBrlRkFWxIuLCLSfREPQhOT8D93RBqt2n8AU TBzQ== X-Gm-Message-State: AOJu0YybiiUpW1K/ZABnEXR4lmwnuBn4vzO+QwKZ3zSSrCLf8T89g9OK CpV/UnG3UhaBl9rxrz5doVTXWlTTHK0Y9wxIrlCMvLF9OyBV5xLv+rGQMZ9QFnZM+9n3dbdUsOU eVKpcivJO88opJT0eNVKmecyhz1Y= X-Google-Smtp-Source: AGHT+IFCVPMdY03l/9GfiO/S0dt4ph2i2msiwwaSpTgFS7v15yDS0eeHvaQaLZAd02I1qz3P+LFfQnY0Va81au/pA+c= X-Received: by 2002:a05:690c:6084:b0:61a:db4d:cc1f with SMTP id 00721157ae682-627971c33dbmr52590797b3.7.1716306078263; Tue, 21 May 2024 08:41:18 -0700 (PDT) MIME-Version: 1.0 References: <20240402140644.2172819-1-adhemerval.zanella@linaro.org> <20240402140644.2172819-8-adhemerval.zanella@linaro.org> In-Reply-To: From: "H.J. Lu" Date: Tue, 21 May 2024 08:40:41 -0700 Message-ID: Subject: Re: [PATCH v3 7/7] math: Provide modf128 for static libm on alpha, s390, and sparcv9 To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3018.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 20, 2024 at 12:07=E2=80=AFPM Adhemerval Zanella Netto wrote: > > > > On 20/05/24 13:59, H.J. Lu wrote: > > On Tue, Apr 2, 2024 at 7:07=E2=80=AFAM Adhemerval Zanella > > wrote: > >> > >> Checked with a build for the affected ABIs > >> --- > >> sysdeps/ieee754/ldbl-64-128/s_modfl.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/sysdeps/ieee754/ldbl-64-128/s_modfl.c b/sysdeps/ieee754/l= dbl-64-128/s_modfl.c > >> index 7d7aeae111..ba3d31334a 100644 > >> --- a/sysdeps/ieee754/ldbl-64-128/s_modfl.c > >> +++ b/sysdeps/ieee754/ldbl-64-128/s_modfl.c > >> @@ -1,10 +1,10 @@ > >> #include > >> #include > >> -#if IS_IN (libc) > >> +#if IS_IN (libc) && defined SHARED > >> # undef libm_alias_ldouble > >> # define libm_alias_ldouble(from, to) > >> #endif > >> #include > >> -#if IS_IN (libc) > >> +#if IS_IN (libc) && defined SHARED > >> long_double_symbol (libc, __modfl, modfl); > > > > Doesn't this remove modfl from static library? > > As for copysignf128 and frexp128, this symbol is also provided by libc.a. > Before this patch: > > alpha-linux-gnu$ readelf -sW libc.a | grep -w modf.* > 19: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modfl > 17: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modff32x > 18: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modff64 > 19: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modf > 17: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modff32 > 18: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modff > > After this patch: > > alpha-linux-gnu$ readelf -sW libc.a | grep -w modf.* > 19: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modff64x > 20: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modff128 > 21: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modfl > 17: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modff32x > 18: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modff64 > 19: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modf > 17: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modff32 > 18: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 = modff > > I am working on a patch to check missing symbols in static libraries. I opened: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31781 scalbnf128 seems also missing in alpha libm.a. --=20 H.J.