From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by sourceware.org (Postfix) with ESMTPS id 00B603858D20 for ; Mon, 1 Apr 2024 14:16:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00B603858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00B603858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b36 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711980983; cv=none; b=pkFx1ON69jI/W0BcrRmpMORzOGSfc5MZUrNrpSxeCq/aiLRgPVpCQstH9MFAwsBsZnqAtV28SzGW1NnCVa4ixb3psddybwoVp+5Xsr6F3JSBmdYFz56PR9gKyo4pXpKJlzWq0dOLNUnDWEcmTtvHhlMss8a4hk9dZmeJ/QhCLf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711980983; c=relaxed/simple; bh=FtdU+SQepB4p4wGx+9RMPBfAEjdgrscLKx5V7ZGNfT0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Z52668YI2vgHSEY7o85ZRlbNHKgCUj3Wi9gxS0VfD8T91WAvfNcMHS9Rhysky7tswBNkFFFJ1Rn0yFxs871bh0C6+yVVXpJJ5Sytn5ORIrgXEl9fBhFP9FRgoWoDck0H0t40aupbvyRCZ11AakQP+9gMpdogcthsYRoVn7YR6ns= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb36.google.com with SMTP id 3f1490d57ef6-dc6cbe1ac75so2913041276.1 for ; Mon, 01 Apr 2024 07:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711980980; x=1712585780; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zwrMRuDjbGOuHahI+Arb6KejOBXAvF7zq9r0OBs95/Q=; b=WKEyArM7MqBuQj2FNC5ATPRA8TL8osGXH2ILy75069gBGedsYOVRcjBJqyUaZRt5Mz IiMxjGsfLbwQZUnB9pVXZPFeL/w6euVFr/315/Tl21uJR7L+V7jKCaKDyWkUYkQv1uQu BqT63fT+F4npeSGZ9o5UVjZvs78GV51vXlLueVxQAX4jsKaVsx6bhv0pZGNYzOeARcwx J5G9HEFO8KoWvNYeGUa7jxJNARKrsWVe1WGtv6OjQ5trapJNtr82BL1DJVf8XTm7OAzU n+3d2rvVoQ4OMbUlVXYb/7Ns3a4D3GGS4qTEFe4sOgL4j8VY65tDdZz0ybFi40X0pZGm hIYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711980980; x=1712585780; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zwrMRuDjbGOuHahI+Arb6KejOBXAvF7zq9r0OBs95/Q=; b=CyfxvGPmtwkPjS+hOieXbLmw3gwVK+4Goz+PmL7t9o+zum/6ui1xLRjoLgEsjawDco BKsrmzaVJvdUBFTL07jfVvPdIB2E4pKJIooiDZ4j6dJoaQkyleD3rY61UF11P8iW53zw IPODaf479KuDFJmE8mCvSoqwecrBKBQptUckh3USZIYhjLm1EYdt6y1rF7tuFVtbQQvt h0bWhOGPMIovrYuFeI5P7UtNgJFvegsYSzo8BgYrG0AFQgRDaCC2kBsB/mpVPzkrLg4i RfkgcAlKERnURuTDitzyuIZQgXOAVuFE7jda8WvidKhiL800owGKbh8+vDiRYgUlbH4R g19A== X-Gm-Message-State: AOJu0YxBIse9h4zIxDskcAFIgwaOk7OrG9sNft+vfhWmAeRl1RZyHMzn 49cCxx2j7BKGYlKn8W/pY6W2ce0NQuD4B6VrksvdN/uzTD+/AVBOxSPaeVy/XxK/c3viEBGtiN6 7D+rreB7MnRcD8+NgpSyUqS+VshQ= X-Google-Smtp-Source: AGHT+IGD9WJAOJnHlE40uaK7q/rcXZ2KQgzhHVXX+cEcKGQHrOq9CSbvTb51C7EQAWlZFUMfWHo7poKzDR5UGoCWawU= X-Received: by 2002:a5b:11:0:b0:dda:a305:542f with SMTP id a17-20020a5b0011000000b00ddaa305542fmr8929772ybp.17.1711980979483; Mon, 01 Apr 2024 07:16:19 -0700 (PDT) MIME-Version: 1.0 References: <20231228172026.2013007-1-adhemerval.zanella@linaro.org> <20231228172026.2013007-11-adhemerval.zanella@linaro.org> In-Reply-To: <20231228172026.2013007-11-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Mon, 1 Apr 2024 07:15:43 -0700 Message-ID: Subject: Re: [PATCH 10/12] x86: Do not raise inexact exception on floor/floorf To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 28, 2023 at 9:24=E2=80=AFAM Adhemerval Zanella wrote: > > It is not allowed anymore on ISO C23. > > Checked on x86_64-linux-gnu and i686-linux-gnu. > --- > sysdeps/i386/fpu/s_floor.S | 34 --------------------------------- > sysdeps/i386/fpu/s_floor.c | 38 +++++++++++++++++++++++++++++++++++++ > sysdeps/i386/fpu/s_floorf.S | 34 --------------------------------- > sysdeps/i386/fpu/s_floorf.c | 38 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 76 insertions(+), 68 deletions(-) > delete mode 100644 sysdeps/i386/fpu/s_floor.S > create mode 100644 sysdeps/i386/fpu/s_floor.c > delete mode 100644 sysdeps/i386/fpu/s_floorf.S > create mode 100644 sysdeps/i386/fpu/s_floorf.c > > diff --git a/sysdeps/i386/fpu/s_floor.S b/sysdeps/i386/fpu/s_floor.S > deleted file mode 100644 > index 7143fdcc9a..0000000000 > --- a/sysdeps/i386/fpu/s_floor.S > +++ /dev/null > @@ -1,34 +0,0 @@ > -/* > - * Public domain. > - */ > - > -#include > -#include > - > -RCSID("$NetBSD: s_floor.S,v 1.4 1995/05/09 00:01:59 jtc Exp $") > - > -ENTRY(__floor) > - fldl 4(%esp) > - subl $32,%esp > - cfi_adjust_cfa_offset (32) > - > - fnstenv 4(%esp) /* store fpu environment */ > - > - /* We use here %edx although only the low 1 bits are defined. > - But none of the operations should care and they are faster > - than the 16 bit operations. */ > - movl $0x400,%edx /* round towards -oo */ > - orl 4(%esp),%edx > - andl $0xf7ff,%edx > - movl %edx,(%esp) > - fldcw (%esp) /* load modified control word */ > - > - frndint /* round */ > - > - fldenv 4(%esp) /* restore original environment *= / > - > - addl $32,%esp > - cfi_adjust_cfa_offset (-32) > - ret > -END (__floor) > -libm_alias_double (__floor, floor) > diff --git a/sysdeps/i386/fpu/s_floor.c b/sysdeps/i386/fpu/s_floor.c > new file mode 100644 > index 0000000000..90ba61da92 > --- /dev/null > +++ b/sysdeps/i386/fpu/s_floor.c > @@ -0,0 +1,38 @@ > +/* Return largest integral value not less than argument. i386 version. > + Copyright (C) 2023 Free Software Foundation, Inc. 2024. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#define NO_MATH_REDIRECT > +#include > +#include > +#include > + > +double > +__floor (double x) > +{ > + fenv_t fenv; > + double r; > + > + libc_feholdexcept_setround_387 (&fenv, FE_DOWNWARD); > + asm volatile ("frndint" : "=3Dt" (r) : "0" (x)); > + /* Preserve "invalid" exceptions from sNaN input. */ > + fenv.__status_word |=3D libc_fetestexcept_387 (FE_INVALID); > + libc_fesetenv_387 (&fenv); > + > + return r; > +} > +libm_alias_double (__floor, floor) > diff --git a/sysdeps/i386/fpu/s_floorf.S b/sysdeps/i386/fpu/s_floorf.S > deleted file mode 100644 > index 8fad9c0698..0000000000 > --- a/sysdeps/i386/fpu/s_floorf.S > +++ /dev/null > @@ -1,34 +0,0 @@ > -/* > - * Public domain. > - */ > - > -#include > -#include > - > -RCSID("$NetBSD: s_floorf.S,v 1.3 1995/05/09 00:04:32 jtc Exp $") > - > -ENTRY(__floorf) > - flds 4(%esp) > - subl $32,%esp > - cfi_adjust_cfa_offset (32) > - > - fnstenv 4(%esp) /* store fpu environment */ > - > - /* We use here %edx although only the low 1 bits are defined. > - But none of the operations should care and they are faster > - than the 16 bit operations. */ > - movl $0x400,%edx /* round towards -oo */ > - orl 4(%esp),%edx > - andl $0xf7ff,%edx > - movl %edx,(%esp) > - fldcw (%esp) /* load modified control word */ > - > - frndint /* round */ > - > - fldenv 4(%esp) /* restore original environment *= / > - > - addl $32,%esp > - cfi_adjust_cfa_offset (-32) > - ret > -END (__floorf) > -libm_alias_float (__floor, floor) > diff --git a/sysdeps/i386/fpu/s_floorf.c b/sysdeps/i386/fpu/s_floorf.c > new file mode 100644 > index 0000000000..0e7e8223a8 > --- /dev/null > +++ b/sysdeps/i386/fpu/s_floorf.c > @@ -0,0 +1,38 @@ > +/* Return largest integral value not less than argument. i386 version. > + Copyright (C) 2023 Free Software Foundation, Inc. 2024. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#define NO_MATH_REDIRECT > +#include > +#include > +#include > + > +float > +__floorf (float x) > +{ > + fenv_t fenv; > + float r; > + > + libc_feholdexcept_setround_387 (&fenv, FE_DOWNWARD); > + asm volatile ("frndint" : "=3Dt" (r) : "0" (x)); > + /* Preserve "invalid" exceptions from sNaN input. */ > + fenv.__status_word |=3D libc_fetestexcept_387 (FE_INVALID); > + libc_fesetenv_387 (&fenv); > + > + return r; > +} > +libm_alias_float (__floor, floor) > -- > 2.34.1 > --=20 H.J.