From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by sourceware.org (Postfix) with ESMTPS id 742743858D3C for ; Thu, 2 Mar 2023 04:23:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 742743858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb29.google.com with SMTP id k199so2458053ybf.4 for ; Wed, 01 Mar 2023 20:23:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uo4PRv2ER+wHln1pkJvvbdN3dSPEmvGnYASCJ6gMxBQ=; b=GhK+K88wmA/6eoRZW1svN1TJxGEaV7cqJO46x8SIvzh2T5erKOFuIwo+Hgn+uHMEXt mEPAzZ+BEyoxYjyFZ/9sS9xbcZv82TqV+0mrVOck7uQVoexJmLHXAFVkRMtQlykKWApQ BYUZch859C/RAs3VAhN2ia1qebL+zYZbUdCJ+/EaahIHIaHmdQRzfQcQ1IvuJDT1O3+y GsvpZIIyLOBDboUtYSa6C8McXvMV65AL3yMEIUBiRuRNmn1i0CARFIcuG8Fszc9OU4+6 nQML2ielyEhUcDao2r9dBq8blPaew2yFPNseHtRahaljGMdYq6VqOeEoW3LC/0t0vWjX KTwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uo4PRv2ER+wHln1pkJvvbdN3dSPEmvGnYASCJ6gMxBQ=; b=DCqCXcdylqO0fQ7hO7VT3ys1yxkTuEqr9CW6eAmUj9C9dfTbVjGpLmIokWv770qc2K bvOr+jBCnC2xz2HDO6QE3l8UulDRmB+NbD+VxWiiouPTVZdKUCezzP4hjjYI/UgzWyoG xYTAz1oC1LQjcRFbeATAhi08R/W9tHJoqHHvcmjtr9Opikoyuusd660yv0gArAjNViVu 5s4L3ovc5y1DKKUnMZA5ZTgLY3FmtmNDxTIRC56fW1sekd99MbvVQQtnDqVo/B7HM+PD 5rwX1q7mZ/4FwHr+zUJMF/ZM7htiuIsDHY5SYpauyXm8i0Kehl+MV8Qgcv9syNg5Ffkl 8eww== X-Gm-Message-State: AO0yUKX8VDOeMYqrPyQTUUfYiIF/PqBEBA5thrANsv/hn+uNBaBKIW94 g6jaXeDwh/l0H0PK6MZmcFpx8Ezb8ljwjndZFUw= X-Google-Smtp-Source: AK7set9NurXsvNqGKjevuzb9eDht5qB/DG58xtI2BWBHW+WLp6zRj4DFez8QxcNMcwe6/8tp3f9zHSsbiAcq2SSeEQU= X-Received: by 2002:a5b:b91:0:b0:906:307b:1449 with SMTP id l17-20020a5b0b91000000b00906307b1449mr724479ybq.5.1677731007721; Wed, 01 Mar 2023 20:23:27 -0800 (PST) MIME-Version: 1.0 References: <20230302023349.3194099-1-caiyinyu@loongson.cn> In-Reply-To: <20230302023349.3194099-1-caiyinyu@loongson.cn> From: "H.J. Lu" Date: Wed, 1 Mar 2023 20:22:51 -0800 Message-ID: Subject: Re: [PATCH] x86: Fix bug about glibc.cpu.hwcaps. To: caiyinyu Cc: libc-alpha@sourceware.org, goldstein.w.n@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3022.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 1, 2023 at 6:36=E2=80=AFPM caiyinyu wrot= e: > > Recorded in [BZ #30183]: > > 1. export GLIBC_TUNABLES=3Dglibc.cpu.hwcaps=3D-AVX512 > 2. Add _dl_printf("p -- %s\n", p); just before switch(nl) in > sysdeps/x86/cpu-tunables.c > 3. compiled and run ./testrun.sh /usr/bin/ls > you will get: > > p -- -AVX512 > p -- LC_ADDRESS=3Den_US.UTF-8 > p -- LC_NUMERIC=3DC > ... > > The function, TUNABLE_CALLBACK (set_hwcaps) > (tunable_val_t *valp), checks far more than it should and it > should stop at end of "-AVX512". > --- > sysdeps/x86/cpu-tunables.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sysdeps/x86/cpu-tunables.c b/sysdeps/x86/cpu-tunables.c > index d3e1367bda..772fb0c4c2 100644 > --- a/sysdeps/x86/cpu-tunables.c > +++ b/sysdeps/x86/cpu-tunables.c > @@ -107,13 +107,13 @@ TUNABLE_CALLBACK (set_hwcaps) (tunable_val_t *valp) > NOTE: the IFUNC selection may change over time. Please check all > multiarch implementations when experimenting. */ > > - const char *p =3D valp->strval; > + const char *p =3D valp->strval, *c; > struct cpu_features *cpu_features =3D &GLRO(dl_x86_cpu_features); > size_t len; > > do > { > - const char *c, *n; > + const char *n; > bool disable; > size_t nl; > > @@ -283,7 +283,7 @@ TUNABLE_CALLBACK (set_hwcaps) (tunable_val_t *valp) > } > p +=3D len + 1; > } > - while (*p !=3D '\0'); > + while (*c !=3D '\0'); > } > > # if CET_ENABLED > -- > 2.31.1 > OK. Thanks. --=20 H.J.