From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id DB6393841466 for ; Thu, 30 Jun 2022 02:04:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB6393841466 Received: by mail-pj1-x1029.google.com with SMTP id n16-20020a17090ade9000b001ed15b37424so1289230pjv.3 for ; Wed, 29 Jun 2022 19:04:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JMS0ekDtf1DrZ+RpUjdaN70XG4/i5DD+umDKkBSkICY=; b=5mYIamENop0jQc9vZS+FJCIHZYDGjZ+DJoqXJXCu4pCS30+CUA1dDOg7al9advQpFI gm/LJ0iMSGqt9QnpV+NJblWTgPLto8x4NuBDmHlIhEflfpqO9nQwvZIgf8hTF2OvB6Ha NzwzTSncv/RnVkv/BgVfaEUM+rbKGH+k+aoSa0ZykoCWxvAD2tCux/HD+TLBLGE551IV j5TbE7v5bG5GU5owslcmeJGTMf5OUd9v9Du1hk1d/WOCBYzvbeFk8rrZZ7tpEH+Sm7FC /QsW7aG4B4B9eQ1JkQr/zA8spOnM/4WwVQx5FPu8ItKH8BjPpT+W8DvvKTDFwV0Lf/i+ V2uw== X-Gm-Message-State: AJIora+20EnDQPJ3xNfj3OsJZiNgIhhlbVYjhT4GbcpKLEtcx8j23p0A k2hgZt45Uo+5Aa/7T80Xl3Sq+4PrAVYECNJTQfXk4xqS X-Google-Smtp-Source: AGRyM1tGiv7f733vLfAxh7ucxuKdwddb5q0UOO6PGNpLieyUA6lP/vkhUGOACIIm6ej2n6UtYt7ShR+kJMpS4ylQZAE= X-Received: by 2002:a17:90b:895:b0:1ec:827c:ef0f with SMTP id bj21-20020a17090b089500b001ec827cef0fmr8996150pjb.10.1656554654978; Wed, 29 Jun 2022 19:04:14 -0700 (PDT) MIME-Version: 1.0 References: <20220630015618.3586787-1-goldstein.w.n@gmail.com> <20220630015618.3586787-3-goldstein.w.n@gmail.com> In-Reply-To: <20220630015618.3586787-3-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Wed, 29 Jun 2022 19:03:39 -0700 Message-ID: Subject: Re: [PATCH v1] x86: Add missing IS_IN (libc) check to strncmp-sse4_2.S To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 02:04:17 -0000 On Wed, Jun 29, 2022 at 6:56 PM Noah Goldstein wrote: > > Was missing to for the multiarch build rtld-strncmp-sse4_2.os was > being built and exporting symbols: > > build/glibc/string/rtld-strncmp-sse4_2.os: > 0000000000000000 T __strncmp_sse42 > > Introduced in: > > commit 11ffcacb64a939c10cfc713746b8ec88837f5c4a > Author: H.J. Lu > Date: Wed Jun 21 12:10:50 2017 -0700 > > x86-64: Implement strcmp family IFUNC selectors in C > --- > sysdeps/x86_64/multiarch/strncmp-sse4_2.S | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S > index 9773e5fc09..310a6dbe77 100644 > --- a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S > +++ b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S > @@ -16,6 +16,8 @@ > License along with the GNU C Library; if not, see > . */ > > -#define STRCMP_SSE42 __strncmp_sse42 > -#define USE_AS_STRNCMP > -#include "strcmp-sse42.S" > +#if IS_IN (libc) > +# define STRCMP_SSE42 __strncmp_sse42 > +# define USE_AS_STRNCMP > +# include "strcmp-sse42.S" > +#endif > -- > 2.34.1 > LGTM. Thanks. -- H.J.