From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id B6D08385801A for ; Sat, 27 Mar 2021 17:56:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B6D08385801A Received: by mail-oi1-x233.google.com with SMTP id i81so9084029oif.6 for ; Sat, 27 Mar 2021 10:56:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DiywRsMGPyvMtbeS08u/QjNJb8mPjCfjKzEGU7ROnvY=; b=Lbmn85pnOkDUtdR5OwgtGJuf1/JjzRD1KuInEpIfZbCXIi6nxKQtEqCqig8PqJkeYK 3lOOLRKADBg1oGHCI2ltlRCQMJzu6ICgJx1hT/8CWt5Ain3RrWeq12pdN14DlvxvZ4rq QcQmWAbefpwznEnktVKaa+2YuKyTO2EH4rHPxJmKN79yQ45FRA+BJuZVbIBbehM0nsLE 3YHaDBjp9WFmn8AjTSYyhRq1XIMGReg1NTIv80lK9uLUF6d+uzX/pU0nWRYlbQk/WMLw WtOjqEQADcsrcW4rrchLl71OKB9gNXb2q1DVVUiz0DnZOeCCfSJYCjl/aFVTeXDKXA6Q gmuQ== X-Gm-Message-State: AOAM531dn/XfHuNZAQ7xFZ2Frh9r7+r3Vpu/RzSXEG/kYbJIIsSrjJ+g kpkKf5lntCIEqmTH2LBG0Vk4ag6YktXI8mbi9UDfaZODTg5feQ== X-Google-Smtp-Source: ABdhPJxzIr368/un5WFnk1Nhj8Aj7IJSdf7/igIbMdI3xm90onkF+pixPSf5kIRRFvlgFroDTN7o/gKm/llY5CPO/Ok= X-Received: by 2002:a05:6808:10c5:: with SMTP id s5mr13723276ois.58.1616867805181; Sat, 27 Mar 2021 10:56:45 -0700 (PDT) MIME-Version: 1.0 References: <20210327162433.3215479-1-hjl.tools@gmail.com> <87lfa88p8l.fsf@mid.deneb.enyo.de> <87blb48oxa.fsf@mid.deneb.enyo.de> In-Reply-To: <87blb48oxa.fsf@mid.deneb.enyo.de> From: "H.J. Lu" Date: Sat, 27 Mar 2021 10:56:09 -0700 Message-ID: Subject: Re: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655] To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3034.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2021 17:56:47 -0000 On Sat, Mar 27, 2021 at 10:52 AM Florian Weimer wrote: > > * H. J. Lu: > > > Subject: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655] > > > > Use wmemset to initialize wchar_t string. > > --- > > string/test-strnlen.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/string/test-strnlen.c b/string/test-strnlen.c > > index a49d93afa2..b98dc10a56 100644 > > --- a/string/test-strnlen.c > > +++ b/string/test-strnlen.c > > @@ -27,6 +27,7 @@ > > > > #ifndef WIDE > > # define STRNLEN strnlen > > +# define MEMSET memset > > # define CHAR char > > # define BIG_CHAR CHAR_MAX > > # define MIDDLE_CHAR 127 > > @@ -34,6 +35,7 @@ > > #else > > # include > > # define STRNLEN wcsnlen > > +# define MEMSET wmemset > > # define CHAR wchar_t > > # define BIG_CHAR WCHAR_MAX > > # define MIDDLE_CHAR 1121 > > @@ -153,7 +155,7 @@ do_page_tests (void) > > size_t last_offset = (page_size / sizeof (CHAR)) - 1; > > > > CHAR *s = (CHAR *) buf2; > > - memset (s, 65, (last_offset - 1)); > > + MEMSET (s, 65, (last_offset - 1)); > > s[last_offset] = 0; > > > > /* Place short strings ending at page boundary. */ > > Patch looks good. Please change the commit message to mention that > this changes just a test. I changed the commit subject to test-strnlen.c: Initialize wchar_t string with wmemset [BZ #27655] -- H.J.