Re: [PATCH] elf: Properly remove the initial 'env' command

["H.J. Lu" <hjl.tools@gmail.com>]

On Fri, Feb 9, 2024 at 5:30 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Andreas Schwab:
>
> > On Feb 09 2024, H.J. Lu wrote:
> >
> >> diff --git a/elf/tst-rtld-list-diagnostics.py b/elf/tst-rtld-list-diagnostics.py
> >> index 9e70e74bf8..dfba94de64 100644
> >> --- a/elf/tst-rtld-list-diagnostics.py
> >> +++ b/elf/tst-rtld-list-diagnostics.py
> >> @@ -294,7 +294,11 @@ def main(argv):
> >>          check_consistency_with_manual(opts.manual)
> >>
> >>      # Remove the initial 'env' command.
> >> -    parse_diagnostics(opts.command.split()[1:])
> >> +    options = []
> >> +    for o in opts.command.split()[0:]:
> >> +        if o != 'env':
> >> +            options.append(o)
> >
> > Why does it need to do that in the first place?
>
> Good question.  I must have copied it from scripts/tst-ld-trace.py.  I
> think we can remove the .split() and run the command string with

How does removing .split() work?  The argument is

"/export/build/gnu/tools-build/glibc-apx-sde/test-sde.sh env
/export/build/gnu/tools-build/glibc-apx-sde/build-x86_64-linux/elf/ld-linux-x86-64.so.2
--list-diagnostics"

We need .split() to change it to proper arguments.

> shell=True.
>
> Thanks,
> Florian
>


-- 
H.J.