From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id B8F503858C83 for ; Tue, 26 Apr 2022 15:40:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8F503858C83 Received: by mail-pl1-x629.google.com with SMTP id n18so30613931plg.5 for ; Tue, 26 Apr 2022 08:40:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=La/EKsBExKQVO8DAbMO/+IKwiIiGrt3s4316jPkN7+c=; b=EnEwDckWu4hFvviTI5oCvF1QF0bvxHEVy3+hwG3xiGpq0illIZl6XCoca+uH/lfRGD UuzSLD+JvrLpmu/y/RdUc/MEYCTcgzGeRSLPfLh0BBV8Ktc+mux2VuurYbHD1wb+YAn4 4YbjWEeq0Efj30IaiM6/jaErfklYeCdcwG7O40xgOLwts+IFtni9BXJJMJEvlY6v1e9V e8dyYWAuzf9sI2wTDrAAm5iPQNGc+owIDJ4JtTuTsuSTyg+3L90cf94RJ8rUE8Dv7khW ce8e6tf6InaDXlgLIAegS+L2j0HK7uZNSHy5NeM02pvCkZw++8cX12Cg6z5I347F/aZ7 vIuA== X-Gm-Message-State: AOAM531u4AvqrKGMVhYsfokv66ujCGZBKLeEOpoc750Hs/BKVnoxHdvx 107QwewuKJDwnlDsitJzmfyhUNHwcC2QwKudnmM= X-Google-Smtp-Source: ABdhPJzShfzz0NVXn8vZR8IGz4iMyzgNVminl0NuYnWnRBv5iU4lXvAf9LN7CcT7ZhTnD3+k1b5MINfIvX4z4p4bt4A= X-Received: by 2002:a17:902:eacd:b0:15c:17fc:31e with SMTP id p13-20020a170902eacd00b0015c17fc031emr22349207pld.4.1650987629684; Tue, 26 Apr 2022 08:40:29 -0700 (PDT) MIME-Version: 1.0 References: <20220422190139.2615492-1-hjl.tools@gmail.com> <24b4ea75-f160-12d8-26e7-6a7069f77665@linaro.org> In-Reply-To: <24b4ea75-f160-12d8-26e7-6a7069f77665@linaro.org> From: "H.J. Lu" Date: Tue, 26 Apr 2022 08:39:53 -0700 Message-ID: Subject: Re: [PATCH v11 0/7] Support DT_RELR relative relocation format To: Adhemerval Zanella Cc: GNU C Library , Fangrui Song , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3019.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 15:40:32 -0000 On Mon, Apr 25, 2022 at 10:23 AM Adhemerval Zanella wrote: > > > > On 22/04/2022 16:01, H.J. Lu wrote: > > Changes in v11: > > > > 1. Replace > > > > if (!(map)->l_info[DT_RELR]) > > > > with > > > > if ((map)->l_info[DT_RELR] == NULL) > > > > 2. Add a space to --disable-default-dt-relr option. > > 3. Compile extra DT_RELR tests with $(no-stack-protector). > > 4. Add DT_RELR related macros to scripts/glibcelf.py. > > > > Changes in v10: > > > > 1. Don't check GLIBC_PRIVATE definition for DT_RELR in ld.so since ld.so > > has no DT_NEEDED entry. > > > > Changes in v9: > > > > 1. A DT_RELR shared library without DT_NEEDED works. > > 2. A DT_RELR shared library without DT_VERNEED works. > > 3. A DT_RELR shared library without libc.so on DT_NEEDED works. > > > > Changes in v8: > > > > 1. Remove the out-of-date comments in _dl_check_map_versions. > > 2. Change "long" to "long int". > > 3. Update the DT_RELR NEWS entry. > > > > Changes in v7: > > > > 1. Add GLIBC_ABI_DT_RELR support before adding DT_RELR support. > > 2. Update the DT_RELR NEWS entry. > > 3. Misc fixes. > > > > Changes in v6: > > > > 1. Move ELF_DYNAMIC_DO_RELR before ELF_DYNAMIC_DO_REL. > > > > Changes in v5: > > > > 1. Update NEWS entry with the linker option, -z pack-relative-relocs. > > 2. Remove elf/libc-abi-version.exp and use $(READELF) to check > > GLIBC_ABI_DT_RELR. > > > > Changes in v4: > > > > 1. Always enable GLIBC_ABI_DT_RELR check. > > 2. Use $(OBJDUMP) instead of $(NM) for GLIBC_ABI_DT_RELR check. > > > > Changes in v3: > > > > 1. Don't define SUPPORT_DT_RELR. > > 2. Enable DT_RELR in glibc shared libraries and position independent > > executables (PIE) automatically if linker supports -z pack-relative-relocs. > > > > Changes in v2: > > > > 1. Enable DT_RELR for all targets. > > 2. Issue an error if there is a DT_RELR entry without GLIBC_ABI_DT_RELR > > dependency nor GLIBC_PRIVATE definition. > > > > Fangrui Song (1): > > elf: Support DT_RELR relative relocation format [BZ #27924] > > The patchset looks ok, the only piece that I think it does not add much and > it would be better to be dropped is the '--disable-default-dt-relr' support. > > As we discussed in the weekly patchset call, having less configure switches > is desirable and this specific option will most likely not be used. I will drop the -disable-default-dt-relr patch, rebase and check them in. Thanks. -- H.J.