From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 341A1385801C for ; Thu, 4 Aug 2022 21:24:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 341A1385801C Received: by mail-pl1-x636.google.com with SMTP id z19so980906plb.1 for ; Thu, 04 Aug 2022 14:24:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=wiuID6HeAV2NB+fbNu/qUcj0Ln9/7XCExlgvwQmK7ss=; b=iJyv/++toByyuka2cBqQnkaPHDkxzXvwJ/ZUd0Vt2kTTBWcGSbScf8+Zk912IB7xpX sc2XzMRNvGONR0d8UaTecmPBdyWm8KVNmXIIjTVPPtNk9ksnDJQNLwuOtTWKobLJ2aLz mN4EfV7SWIrPuZmarjIrBH1ypqo7u8hfkBgKJVPn+ddYzsoAFviLGsHeGmkWNv4fV4bC aUdnAqkeys7gi1k1PEwApNsW7QQXOwsFOIjJMC8xFnbGlX3Oe/py9JCoSRZlDq410LQD fL88rAOjtWIC+jk13M2G7vj1vwZPg6gygSUlXqLsONzqA6pkEPnAyf3KXbdI1tEYOK03 JucA== X-Gm-Message-State: ACgBeo3zjZ0ZZh3/gANlgtWOkVdkR16nYxvm9BXd72j2VRjMqL46C8Md gMM+Sc/bPwVCK8loyUXP/XCf2g/GnD16mSiJo8k= X-Google-Smtp-Source: AA6agR5Vnmh4CuSt8+3BCt4FaPjiKWvF/cdhBgwzAdAov5hHteqXTczuMBXLfsX9fxE1xPKj8wy1+ifikuEGW/sQQNQ= X-Received: by 2002:a17:903:2406:b0:16d:6b7a:57c6 with SMTP id e6-20020a170903240600b0016d6b7a57c6mr3604337plo.149.1659648258976; Thu, 04 Aug 2022 14:24:18 -0700 (PDT) MIME-Version: 1.0 References: <20220804210016.2613403-1-adhemerval.zanella@linaro.org> In-Reply-To: <20220804210016.2613403-1-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Thu, 4 Aug 2022 14:23:38 -0700 Message-ID: Subject: Re: [PATCH] i386: Use fldt instead of fld on e_logl.S To: Adhemerval Zanella Cc: GNU C Library , Fangrui Song Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3024.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2022 21:24:23 -0000 On Thu, Aug 4, 2022 at 2:00 PM Adhemerval Zanella wrote: > > Clang cannot assemble fldt in the AT&T dialect mode. > --- > sysdeps/i386/i686/fpu/e_logl.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/i386/i686/fpu/e_logl.S b/sysdeps/i386/i686/fpu/e_logl.S > index 63183ac544..5d53f3bb22 100644 > --- a/sysdeps/i386/i686/fpu/e_logl.S > +++ b/sysdeps/i386/i686/fpu/e_logl.S > @@ -43,7 +43,7 @@ ENTRY(__ieee754_logl) > fsubl MO(one) // x-1 : x : log(2) > 5: fld %st // x-1 : x-1 : x : log(2) > fabs // |x-1| : x-1 : x : log(2) > - fld MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > + fldt MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > fcomip %st(1) // |x-1| : x-1 : x : log(2) > fstp %st(0) // x-1 : x : log(2) > jc 2f > @@ -76,7 +76,7 @@ ENTRY(__logl_finite) > fsubl MO(one) // x-1 : x : log(2) > fld %st // x-1 : x-1 : x : log(2) > fabs // |x-1| : x-1 : x : log(2) > - fld MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > + fldt MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > fcomip %st(1) // |x-1| : x-1 : x : log(2) > fstp %st(0) // x-1 : x : log(2) > jc 2b > -- > 2.34.1 > I don't think this is correct since there are .type limit,@object limit: .double 0.29 It should be fldl. -- H.J.