On Thu, Apr 30, 2020 at 7:04 AM Andreas Schwab wrote: > > On Apr 30 2020, H.J. Lu wrote: > > > On Thu, Apr 30, 2020 at 6:51 AM Andreas Schwab wrote: > >> > >> On Apr 30 2020, Florian Weimer wrote: > >> > >> > * Andreas Schwab: > >> > > >> >> On Apr 30 2020, H.J. Lu via Libc-alpha wrote: > >> >> > >> >>> diff --git a/include/sys/prctl.h b/include/sys/prctl.h > >> >>> index 0920ed642b..1a74d83879 100644 > >> >>> --- a/include/sys/prctl.h > >> >>> +++ b/include/sys/prctl.h > >> >>> @@ -4,6 +4,8 @@ > >> >>> # ifndef _ISOMAC > >> >>> > >> >>> extern int __prctl (int __option, ...); > >> >>> +libc_hidden_proto (__prctl) > >> >>> +libc_hidden_proto (prctl) > >> >> > >> >> Why do you need the hidden alias for prctl? All references inside > >> >> libc.so should use __prctl. > >> > > >> > Right. I want to clean this up in a separate patch. > >> > >> ??? Why adding it in the first place? > >> > >> Andreas. > >> > > > > It was there before my patch: > > That doesn't matter, the syscall template adds it blindly to all names. > > Andreas. > Here is the updated patch without libc_hidden_proto (prctl) OK for master? Thanks. -- H.J.