From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105831 invoked by alias); 3 Apr 2016 13:42:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 105821 invoked by uid 89); 3 Apr 2016 13:42:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*schwab X-HELO: mail-qg0-f50.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Mfp9Mb0Y3iNl+JrHeQ6UWvVxVg+8wfmW+TVfkW2Ym5c=; b=TFOiGRYiIKcyKvZ85R16f3JvOTxfTlonSJBaEQx1KDMl9Aez79DGimNAWFCNcVpFoY ZlKuaIXiPj98/DkxEX06S6mQIo9H2j+EmFFjj3/MEQhuNEc8+HUVVKL2RgmLrBH/R4hZ 2Lm5ic3TZgVHELCgC7UhLCGx0M90D1Ax8TmWsGSZRMr7Hep+mX4gbyD3fwGPOthc/Q3h pW1W6iUH4+jafuKlc84wDwiEvcsFCvKIl1+E9loyIt9pq/u1b6H2YnSS/Ah6zKzELwo9 czeMCaaKNlZJd/leN/6vn0cFO9X5Y4IwimQp4mrS3foYk2xS99JJTP4T/Kv/FgvLPK4r QPHQ== X-Gm-Message-State: AD7BkJLGkXpXhmPvbAkABwiDsloxhfsaFQ4qW8rAlZ3ofrdFZfta2V8rUllf1jHulnYn5D0GBdlPIbrcOa5GDw== MIME-Version: 1.0 X-Received: by 10.140.23.139 with SMTP id 11mr5181343qgp.62.1459690926083; Sun, 03 Apr 2016 06:42:06 -0700 (PDT) In-Reply-To: References: <20160402153421.GA28788@intel.com> <20160402173308.GU6588@vapier.lan> Date: Sun, 03 Apr 2016 13:42:00 -0000 Message-ID: Subject: Re: [PATCH] Reduce number of mmap calls from __libc_memalign in ld.so From: "H.J. Lu" To: Andreas Schwab Cc: GNU C Library Content-Type: multipart/mixed; boundary=001a11c14b0c227c0d052f94c741 X-SW-Source: 2016-04/txt/msg00035.txt.bz2 --001a11c14b0c227c0d052f94c741 Content-Type: text/plain; charset=UTF-8 Content-length: 275 On Sat, Apr 2, 2016 at 11:55 PM, Andreas Schwab wrote: > "H.J. Lu" writes: > >> + if (__glibc_unlikely (nup == 0 && n)) > > Please also fix the implicit boolean coercion. > > Andreas. > Like this? OK for master? -- H.J. --001a11c14b0c227c0d052f94c741 Content-Type: application/octet-stream; name="0001-Reduce-number-of-mmap-calls-from-__libc_memalign-in-.patch" Content-Disposition: attachment; filename="0001-Reduce-number-of-mmap-calls-from-__libc_memalign-in-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_imkm9gd60 Content-length: 2579 RnJvbSA1ZDY3MzM3OWE5MDc2MTFiZTE4ZWJkNDhhMTZhMmRmN2IzYWIzZjlj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhq bC50b29sc0BnbWFpbC5jb20+CkRhdGU6IFNhdCwgMiBBcHIgMjAxNiAwODoy NTozMSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFJlZHVjZSBudW1iZXIgb2Yg bW1hcCBjYWxscyBmcm9tIF9fbGliY19tZW1hbGlnbiBpbiBsZC5zbwoKX19s aWJjX21lbWFsaWduIGluIGxkLnNvIGFsbG9jYXRlcyBvbmUgcGFnZSBhdCBh IHRpbWUgYW5kIHRyaWVzIHRvCm9wdGltaXplIGNvbnNlY3V0aXZlIF9fbGli Y19tZW1hbGlnbiBjYWxscyBieSBob3BpbmcgdGhhdCB0aGUgbmV4dAptbWFw IGlzIGFmdGVyIHRoZSBjdXJyZW50IG1lbW9yeSBhbGxvY2F0aW9uLgoKSG93 ZXZlciwgdGhlIGtlcm5lbCBoYW5kcyBvdXQgbW1hcCBhZGRyZXNzZXMgaW4g dG9wLWRvd24gb3JkZXIsIHNvCnRoaXMgb3B0aW1pemF0aW9uIGluIHByYWN0 aWNlIG5ldmVyIGhhcHBlbnMsIHdpdGggdGhlIHJlc3VsdCB0aGF0IHdlCmhh dmUgbW9yZSBtbWFwIGNhbGxzIGFuZCB3YXN0ZSBhIGJ1bmNoIG9mIHNwYWNl IGZvciBlYWNoIF9fbGliY19tZW1hbGlnbi4KClRoaXMgY2hhbmdlIG1ha2Vz IF9fbGliY19tZW1hbGlnbiB0byBtbWFwIG9uZSBwYWdlIGV4dHJhLiAgV29y c3QgY2FzZSwKdGhlIGtlcm5lbCBuZXZlciBwdXRzIGEgYmFja2luZyBwYWdl IGJlaGluZCBpdCwgYnV0IGJlc3QgY2FzZSBpdCBhbGxvd3MKX19saWJjX21l bWFsaWduIHRvIG9wZXJhdGUgbXVjaCBtdWNoIGJldHRlci4gIEZvciBlbGYv dHN0LWFsaWduIC0tZGlyZWN0LAppdCByZWR1Y2VzIG51bWJlciBvZiBtbWFw IGNhbGxzIGZyb20gMTIgdG8gOS4KCgkqIGVsZi9kbC1taW5pbWFsLmMgKF9f bGliY19tZW1hbGlnbik6IE1tYXAgb25lIGV4dHJhIHBhZ2UuCi0tLQogZWxm L2RsLW1pbmltYWwuYyB8IDEyICsrKysrLS0tLS0tLQogMSBmaWxlIGNoYW5n ZWQsIDUgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9lbGYvZGwtbWluaW1hbC5jIGIvZWxmL2RsLW1pbmltYWwuYwppbmRl eCA3NjJlNjViLi5jOGE4ZjhkIDEwMDY0NAotLS0gYS9lbGYvZGwtbWluaW1h bC5jCisrKyBiL2VsZi9kbC1taW5pbWFsLmMKQEAgLTY2LDE1ICs2NiwxMyBA QCBfX2xpYmNfbWVtYWxpZ24gKHNpemVfdCBhbGlnbiwgc2l6ZV90IG4pCiAK ICAgaWYgKGFsbG9jX3B0ciArIG4gPj0gYWxsb2NfZW5kIHx8IG4gPj0gLSh1 aW50cHRyX3QpIGFsbG9jX3B0cikKICAgICB7Ci0gICAgICAvKiBJbnN1ZmZp Y2llbnQgc3BhY2UgbGVmdDsgYWxsb2NhdGUgYW5vdGhlciBwYWdlLiAgKi8K KyAgICAgIC8qIEluc3VmZmljaWVudCBzcGFjZSBsZWZ0OyBhbGxvY2F0ZSBh bm90aGVyIHBhZ2UgcGx1cyBvbmUgZXh0cmEKKwkgcGFnZSB0byByZWR1Y2Ug bnVtYmVyIG9mIG1tYXAgY2FsbHMuICAqLwogICAgICAgY2FkZHJfdCBwYWdl OwogICAgICAgc2l6ZV90IG51cCA9IChuICsgR0xSTyhkbF9wYWdlc2l6ZSkg LSAxKSAmIH4oR0xSTyhkbF9wYWdlc2l6ZSkgLSAxKTsKLSAgICAgIGlmIChf X2dsaWJjX3VubGlrZWx5IChudXAgPT0gMCkpCi0JewotCSAgaWYgKG4pCi0J ICAgIHJldHVybiBOVUxMOwotCSAgbnVwID0gR0xSTyhkbF9wYWdlc2l6ZSk7 Ci0JfQorICAgICAgaWYgKF9fZ2xpYmNfdW5saWtlbHkgKG51cCA9PSAwICYm IG4gIT0gMCkpCisJcmV0dXJuIE5VTEw7CisgICAgICBudXAgKz0gR0xSTyhk bF9wYWdlc2l6ZSk7CiAgICAgICBwYWdlID0gX19tbWFwICgwLCBudXAsIFBS T1RfUkVBRHxQUk9UX1dSSVRFLAogCQkgICAgIE1BUF9BTk9OfE1BUF9QUklW QVRFLCAtMSwgMCk7CiAgICAgICBpZiAocGFnZSA9PSBNQVBfRkFJTEVEKQot LSAKMi41LjUKCg== --001a11c14b0c227c0d052f94c741--