From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Use size_t for mallinfo fields.
Date: Tue, 7 Jul 2020 06:19:00 -0700 [thread overview]
Message-ID: <CAMe9rOoknt-7br5xRBZyH-eVp+TpjosDSYjMs1mQFdY9Qc_AFQ@mail.gmail.com> (raw)
In-Reply-To: <b4acaa69-a6e8-8d4c-8475-82f6602d8920@suse.cz>
On Tue, Jul 7, 2020 at 6:08 AM Martin Liška <mliska@suse.cz> wrote:
>
> On 7/7/20 2:17 PM, Andreas Schwab wrote:
> > On Jul 07 2020, Martin Liška wrote:
> >
> >> The current int type can easily overflow for allocation of more
> >> than 4GB.
> >>
> >> The following patch changes that to size_t. I guess I need to adjust
> >> the API version of the function, right?
> >
> > Not only that, it breaks the ABI of mallinfo.
>
> Sure, so what options do I have? I'm new to glibc so a hint would be appreciated.
>
You need to keep the old version of mallinfo in libc.so. There are
plenty of examples
in glibc source:
malloc/hooks.c:#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_25)
malloc/hooks.c:#endif /* SHLIB_COMPAT */
malloc/malloc.c:#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_24)
malloc/malloc.c:#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_26)
malloc/obstack.c:# if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_3_4)
--
H.J.
next prev parent reply other threads:[~2020-07-07 13:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 12:00 Martin Liška
2020-07-07 12:17 ` Andreas Schwab
2020-07-07 13:07 ` Martin Liška
2020-07-07 13:19 ` H.J. Lu [this message]
2020-07-07 13:49 ` Florian Weimer
2020-07-07 13:52 ` Martin Liška
2020-07-07 14:22 ` Florian Weimer
2020-07-07 14:32 ` Andreas Schwab
2020-07-07 14:36 ` Florian Weimer
2020-07-08 7:25 ` Martin Liška
2020-07-08 7:24 ` Martin Liška
2020-07-23 10:23 ` Martin Liška
2020-07-23 14:38 ` Szabolcs Nagy
2020-07-27 12:08 ` Martin Liška
2020-07-27 12:21 ` Florian Weimer
2020-07-27 12:45 ` Martin Liška
2020-08-11 12:26 ` Martin Liška
2020-08-11 13:44 ` Florian Weimer
2020-08-11 17:08 ` DJ Delorie
2020-08-12 12:29 ` Martin Liška
2020-08-24 9:55 ` Martin Liška
2020-08-28 19:05 ` DJ Delorie
2020-08-31 13:35 ` H.J. Lu
2020-08-31 13:56 ` Adhemerval Zanella
2020-08-31 14:00 ` H.J. Lu
2020-08-31 14:10 ` Adhemerval Zanella
2020-09-01 17:26 ` Joseph Myers
2020-09-02 13:19 ` Martin Liška
2020-09-02 13:34 ` Adhemerval Zanella
2020-09-02 14:00 ` Carlos O'Donell
2020-09-02 16:11 ` DJ Delorie
2020-09-21 8:49 ` Martin Liška
2020-09-02 20:16 ` DJ Delorie
2020-09-02 20:24 ` Florian Weimer
2020-09-02 21:04 ` [PATCH/v2] " DJ Delorie
2020-09-03 11:17 ` Adhemerval Zanella
2020-09-03 21:33 ` DJ Delorie
2020-09-17 23:02 ` DJ Delorie
2020-09-02 20:25 ` [PATCH] " Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoknt-7br5xRBZyH-eVp+TpjosDSYjMs1mQFdY9Qc_AFQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=mliska@suse.cz \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).