From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by sourceware.org (Postfix) with ESMTPS id 792B53858D1E for ; Mon, 20 May 2024 21:35:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 792B53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 792B53858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716240921; cv=none; b=MdvKz2SLT1+iuq9T1KT2fWKxgC4Ocm+kA6KweCGDJPtTD+zao4Ij9PpwKht1u3nvGh3L7jZADG1s8vZjAF1V8Ilb6+bz/EFzONLNXseHIZMjcEsUCl1QeiIgH2B7K/E2KIaleYIid2L1i509dA/p1p8z/XZATn861UBiZdm5up8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716240921; c=relaxed/simple; bh=EJUPw18WNbxYT60FdfvKH0x0xx3lWBTOwzVyqS4kI0k=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=age1Thoy4wK/tFGNcYQcVGlfWf6oeCI3PafPZBgD/jbyPjzxCd9xhPT/zCggyjYAc5vWTlhN06BGtjDugx0fa+W6jAYJDIa7Ts4mZVY1AsjmYKprhb818XZy/IvakYi2Aioji7O3peXKIg0BS1PWvJZ+2bVz3+xm19TDM8NarDQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-61df903aa05so32145037b3.3 for ; Mon, 20 May 2024 14:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716240919; x=1716845719; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XUrX83kKSL3LOF6vXYV+K2Y5KOsaXCcp91Cik+HnSpg=; b=GQlZt+zQ0Qe/EnZMc8rT3t5cXdJ/TLyLuNkbfIOphM2XmxIZAmEZ4XARPf4m+xULXW kg2okzw0YHn03fGr3fGj5F1uxJewpz6PvfxzC2LvPfyCfquinxcVH580ms0XDmcx6R2X Py4p6EDJqa5MRfuR0+IxDxdiMGnCWWAbEIL4F6HSvLv35pO7d/nFGssz4Ng6k+trAbkr TGk3y01jr0mQHwib9eU4t534/15tJ+Kf3X0RR0JtiKt6wwGark8XmARdmDPZ+nH8YCMY aq5R0tZ5EGgK0lbbgE/p+PxZAzdrMbxay4RpaGPJf1xi5QuqufYruW+J0OeuWiVwLldV xDsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716240919; x=1716845719; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XUrX83kKSL3LOF6vXYV+K2Y5KOsaXCcp91Cik+HnSpg=; b=jAqwEzcxwltUUIQsaiHFMwCAq+qloRfEIdOGvFZNy6XfEM/KtAr6/9r4IW6P7fuqLV qw0Prv6IVOnAK/9CmvycHqVQIUh4AnjLXBmjoQQhUilbc4OxrTAZUnA8QquT4NI3ezwY Z4ZW8YDMFwZVAdWyZ0A20fXglvG0Tw5rx3xT+WYcrJYaQoPoxbS9JBBQ+vhf7Z+Chssg Y381e50BC3OhuSyJjYQH2hJ3JH+XdwbyE6zLUqC7TwlBupxK2PWNZju1q6WaT1faOrFN 1YHVsNyrxrkZQN9c7c7C3BzomQsWJ7xr4p7wRFmk5Hpjrq00JxMXA4FNt13KKjJTrrL2 F6tw== X-Gm-Message-State: AOJu0YwIhKG3GYxkchIMpYpcqP626y4ZXQATX5xyqKt0m1J9StgtOkBe yuzjb8dvkNmpW+miYzdMAjgnsRg5V/JRaccKQz+9ZgeKiIgry+L6T1hpXezGhrzj7q/l5X/TKSA 5kRALuUx6KUm6iaxxlUMiAnz9Zcg= X-Google-Smtp-Source: AGHT+IE+1znmtKqARyG+cNxLdN03VFzODHKPdXje1T8KlNEq9ORMvy8FtO+X+GFYp6OBNz/N6YzEC29kFDlXOcJCrwk= X-Received: by 2002:a05:690c:6c87:b0:615:2ed7:5aa with SMTP id 00721157ae682-622b001cc0emr434740107b3.45.1716240917832; Mon, 20 May 2024 14:35:17 -0700 (PDT) MIME-Version: 1.0 References: <20240402140644.2172819-1-adhemerval.zanella@linaro.org> <20240402140644.2172819-5-adhemerval.zanella@linaro.org> In-Reply-To: <20240402140644.2172819-5-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Mon, 20 May 2024 14:34:41 -0700 Message-ID: Subject: Re: [PATCH v3 4/7] math: Fix isnanf128 static build To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 2, 2024 at 7:06=E2=80=AFAM Adhemerval Zanella wrote: > > Some static implementation of float128 routines might call __isnanf128, > which is not provided by the static object. > > Checked on x86_64-linux-gnu. > --- > sysdeps/ieee754/float128/float128_private.h | 2 +- > sysdeps/ieee754/float128/s_isnanf128.c | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/sysdeps/ieee754/float128/float128_private.h b/sysdeps/ieee75= 4/float128/float128_private.h > index 38a8bdd0fe..672bf3cccf 100644 > --- a/sysdeps/ieee754/float128/float128_private.h > +++ b/sysdeps/ieee754/float128/float128_private.h > @@ -352,7 +352,7 @@ > #define frexpl frexpf128 > #define getpayloadl getpayloadf128 > #define isinfl isinff128_do_not_use > -#define isnanl isnanf128_do_not_use Why is this change needed? Will the issue be fixed by https://patchwork.sourceware.org/project/glibc/list/?series=3D34121 > +#define isnanl isnanf128 > #define ldexpl ldexpf128 > #define llrintl llrintf128 > #define llroundl llroundf128 > diff --git a/sysdeps/ieee754/float128/s_isnanf128.c b/sysdeps/ieee754/flo= at128/s_isnanf128.c > index 59f71533ce..b73a4e80d7 100644 > --- a/sysdeps/ieee754/float128/s_isnanf128.c > +++ b/sysdeps/ieee754/float128/s_isnanf128.c > @@ -11,7 +11,11 @@ > #include "../ldbl-128/s_isnanl.c" > #if !IS_IN (libm) > #include > +#ifdef SHARED > hidden_ver (__isnanf128_impl, __isnanf128) > +#else > +strong_alias (__isnanf128_impl, __isnanf128) > +#endif > _weak_alias (__isnanf128_impl, isnanl) > versioned_symbol (libc, __isnanf128_impl, __isnanf128, GLIBC_2_34); > #if (SHLIB_COMPAT (libc, FLOAT128_VERSION_M, GLIBC_2_34)) > -- > 2.34.1 > --=20 H.J.