From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id D2AC8385380B for ; Sun, 23 May 2021 18:41:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D2AC8385380B Received: by mail-ot1-x32c.google.com with SMTP id n32-20020a9d1ea30000b02902a53d6ad4bdso23079766otn.3 for ; Sun, 23 May 2021 11:41:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FzJkao1caBpswALlhtxjnYVIhCvFDloZjmPB8Zsk5yw=; b=tRr7hCC/yn5L3bBUItLA9Woq9zO+1qciTDxFc0j4oQdqrfzsNMPc/oM+qMxUlH6rbc cCjdztz/PJuzkQjzjXKZye1uy7GktTtSpUKeC8xd5x3Jd+hnZy/YAN1ORjXzCd2VpOCz yMgzFxD50Px4DCqB1WOb08GxsLJI2yXQHF20oIedlC4Ay3IWBscL1cMaWwS2wqerFnDS w4+M+1YQNZsKs9cH1koaGkVsZGCY5/76B8sbxg5JsyawFsKTAWqrWxqDxcqsSkvEzdLg POoiHmg7T5Hmbmk3kC2KGwutN7TteTyfI5FdedHNZ9FxjN/TDJq40di3s4dk29YQyYua d1CA== X-Gm-Message-State: AOAM531MemkR/qckYtEp/YNCll2IKfM9hvQTNaW0ddBlZ2NughyXz0Cv 2ODXWpHCAvziKA0Cv2eUwk7cWgH0QL9SMOpb0Q6YcqlE X-Google-Smtp-Source: ABdhPJx3D3R5MdnltLeI//VPlrOOhnKF6dbaiMzIQ8KecycW8UJIAzMhjFrLxZhNkGPVv7thUY8V6ea3EJjcw7GxOH8= X-Received: by 2002:a9d:66d4:: with SMTP id t20mr16414147otm.125.1621795286275; Sun, 23 May 2021 11:41:26 -0700 (PDT) MIME-Version: 1.0 References: <20210523172942.3047571-1-hjl.tools@gmail.com> <87tumtmixn.fsf@igel.home> In-Reply-To: <87tumtmixn.fsf@igel.home> From: "H.J. Lu" Date: Sun, 23 May 2021 11:40:50 -0700 Message-ID: Subject: [PATCH v2] x86-64: Align child stack to 16 bytes [BZ #27902] To: Andreas Schwab Cc: "H.J. Lu via Libc-alpha" Content-Type: multipart/mixed; boundary="000000000000eff47f05c303a343" X-Spam-Status: No, score=-3033.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 May 2021 18:41:28 -0000 --000000000000eff47f05c303a343 Content-Type: text/plain; charset="UTF-8" On Sun, May 23, 2021 at 10:57 AM Andreas Schwab wrote: > > On Mai 23 2021, H.J. Lu via Libc-alpha wrote: > > > + /* NB: Try to force misaligned child stack. */ > > + char st[STACK_SIZE + 4] __attribute__ ((aligned (1))); > > If you want a misaligned pointer, you need to start with a known > alignment. > Fixed. Here is the v2 patch. OK for master? Thanks. -- H.J. --000000000000eff47f05c303a343 Content-Type: text/x-patch; charset="US-ASCII"; name="v2-0001-x86-64-Align-child-stack-to-16-bytes-BZ-27902.patch" Content-Disposition: attachment; filename="v2-0001-x86-64-Align-child-stack-to-16-bytes-BZ-27902.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kp1j07gm0 RnJvbSBhZTJkYzBmZTMxN2I5M2QzYWMxZDYyYjJkMTkxZDQ1ZTliZWUwY2VhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IFN1biwgMjMgTWF5IDIwMjEgMTA6MjU6MTAgLTA3MDAKU3ViamVjdDogW1BBVENIIHYyXSB4ODYt NjQ6IEFsaWduIGNoaWxkIHN0YWNrIHRvIDE2IGJ5dGVzIFtCWiAjMjc5MDJdCgpJbiB0aGUgeDg2 LTY0IGNsb25lIHdyYXBwZXIsIGFsaWduIGNoaWxkIHN0YWNrIHRvIDE2IGJ5dGVzIHBlciB0aGUK eDg2LTY0IHBzQUJJLgotLS0KIHN5c2RlcHMvdW5peC9zeXN2L2xpbnV4L01ha2VmaWxlICAgICAg ICAgICAgIHwgIDIgKy0KIHN5c2RlcHMvdW5peC9zeXN2L2xpbnV4L3RzdC1taXNhbGlnbi1jbG9u ZS5jIHwgOTkgKysrKysrKysrKysrKysrKysrKysKIHN5c2RlcHMvdW5peC9zeXN2L2xpbnV4L3g4 Nl82NC9jbG9uZS5TICAgICAgIHwgIDMgKwogMyBmaWxlcyBjaGFuZ2VkLCAxMDMgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHN5c2RlcHMvdW5peC9zeXN2 L2xpbnV4L3RzdC1taXNhbGlnbi1jbG9uZS5jCgpkaWZmIC0tZ2l0IGEvc3lzZGVwcy91bml4L3N5 c3YvbGludXgvTWFrZWZpbGUgYi9zeXNkZXBzL3VuaXgvc3lzdi9saW51eC9NYWtlZmlsZQppbmRl eCA3MGMzYjNmOGEzLi5kMzU1YjQ5MDMzIDEwMDY0NAotLS0gYS9zeXNkZXBzL3VuaXgvc3lzdi9s aW51eC9NYWtlZmlsZQorKysgYi9zeXNkZXBzL3VuaXgvc3lzdi9saW51eC9NYWtlZmlsZQpAQCAt MTA5LDcgKzEwOSw3IEBAIHRlc3RzICs9IHRzdC1jbG9uZSB0c3QtY2xvbmUyIHRzdC1jbG9uZTMg dHN0LWZhbm90aWZ5IHRzdC1wZXJzb25hbGl0eSBcCiAJIHRzdC10Z2tpbGwgdHN0LXN5c3ZzZW0t bGludXggdHN0LXN5c3Ztc2ctbGludXggdHN0LXN5c3ZzaG0tbGludXggXAogCSB0c3QtdGltZXJm ZCB0c3QtcHBvbGwgXAogCSB0c3QtY2xvY2tfYWRqdGltZSB0c3QtYWRqdGltZXggdHN0LW50cF9h ZGp0aW1lIHRzdC1udHBfZ2V0dGltZSBcCi0JIHRzdC1udHBfZ2V0dGltZXggdHN0LXNpZ3RpbWVk d2FpdAorCSB0c3QtbnRwX2dldHRpbWV4IHRzdC1zaWd0aW1lZHdhaXQgdHN0LW1pc2FsaWduLWNs b25lCiAKICMgVGVzdCBmb3IgdGhlIHN5bWJvbCB2ZXJzaW9uIG9mIGZjbnRsIHRoYXQgd2FzIHJl cGxhY2VkIGluIGdsaWJjIDIuMjguCiBpZmVxICgkKGhhdmUtR0xJQkNfMi4yNykkKGJ1aWxkLXNo YXJlZCkseWVzeWVzKQpkaWZmIC0tZ2l0IGEvc3lzZGVwcy91bml4L3N5c3YvbGludXgvdHN0LW1p c2FsaWduLWNsb25lLmMgYi9zeXNkZXBzL3VuaXgvc3lzdi9saW51eC90c3QtbWlzYWxpZ24tY2xv bmUuYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi4wNzBhNDU3ZDY0Ci0t LSAvZGV2L251bGwKKysrIGIvc3lzZGVwcy91bml4L3N5c3YvbGludXgvdHN0LW1pc2FsaWduLWNs b25lLmMKQEAgLTAsMCArMSw5OSBAQAorLyogQ29weXJpZ2h0IChDKSAyMDIxIEZyZWUgU29mdHdh cmUgRm91bmRhdGlvbiwgSW5jLgorICAgVGhpcyBmaWxlIGlzIHBhcnQgb2YgdGhlIEdOVSBDIExp YnJhcnkuCisKKyAgIFRoZSBHTlUgQyBMaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4g cmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0 aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYworICAgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkg dGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCisgICB2ZXJzaW9uIDIuMSBvZiB0 aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKworICAg VGhlIEdOVSBDIExpYnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxs IGJlIHVzZWZ1bCwKKyAgIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRo ZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisgICBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1Ig QSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICAgTGVzc2VyIEdlbmVyYWwgUHVi bGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworICAgWW91IHNob3VsZCBoYXZlIHJlY2Vp dmVkIGEgY29weSBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYworICAgTGljZW5zZSBh bG9uZyB3aXRoIHRoZSBHTlUgQyBMaWJyYXJ5OyBpZiBub3QsIHNlZQorICAgPGh0dHBzOi8vd3d3 LmdudS5vcmcvbGljZW5zZXMvPi4gICovCisKKyNpbmNsdWRlIDxzY2hlZC5oPgorI2luY2x1ZGUg PHN0ZGJvb2wuaD4KKyNpbmNsdWRlIDxzdGRpbnQuaD4KKyNpbmNsdWRlIDxzdGRpby5oPgorI2lu Y2x1ZGUgPHN0cmluZy5oPgorI2luY2x1ZGUgPHN5cy93YWl0Lmg+CisjaW5jbHVkZSA8dW5pc3Rk Lmg+CisjaW5jbHVkZSA8bGliYy1wb2ludGVyLWFyaXRoLmg+CisjaW5jbHVkZSA8dHN0LXN0YWNr LWFsaWduLmg+CisjaW5jbHVkZSA8c3RhY2tpbmZvLmg+CisjaW5jbHVkZSA8c3VwcG9ydC94dW5p c3RkLmg+CisKK3N0YXRpYyBpbnQKK2YgKHZvaWQgKmFyZykKK3sKKyAgYm9vbCBvayA9IHRydWU7 CisKKyAgcHV0cyAoImluIGYiKTsKKworICBpZiAoVEVTVF9TVEFDS19BTElHTiAoKSkKKyAgICBv ayA9IGZhbHNlOworCisgIHJldHVybiBvayA/IDAgOiAxOworfQorCitzdGF0aWMgaW50Citkb190 ZXN0ICh2b2lkKQoreworICBib29sIG9rID0gdHJ1ZTsKKworICBwdXRzICgiaW4gbWFpbiIpOwor CisgIGlmIChURVNUX1NUQUNLX0FMSUdOICgpKQorICAgIG9rID0gZmFsc2U7CisKKyNpZmRlZiBf X2lhNjRfXworIyBkZWZpbmUgU1RBQ0tfU0laRSAoMjU2ICogMTAyNCkKKyNlbHNlCisjIGRlZmlu ZSBTVEFDS19TSVpFICgxMjggKiAxMDI0KQorI2VuZGlmCisKKyAgY2hhciBzdFtTVEFDS19TSVpF ICsgMV07CisgIC8qIE5COiBBbGlnbiBjaGlsZCBzdGFjayB0byAxIGJ5dGUuICAqLworICBjaGFy ICpzdGFjayA9IFBUUl9BTElHTl9VUCAoJnN0WzBdLCAyKSArIDE7CisKKyNpZmRlZiBfX2lhNjRf XworICBleHRlcm4gaW50IF9fY2xvbmUyIChpbnQgKCpfX2ZuKSAodm9pZCAqX19hcmcpLCB2b2lk ICpfX2NoaWxkX3N0YWNrX2Jhc2UsCisJCSAgICAgICBzaXplX3QgX19jaGlsZF9zdGFja19zaXpl LCBpbnQgX19mbGFncywKKwkJICAgICAgIHZvaWQgKl9fYXJnLCAuLi4pOworICBwaWRfdCBwID0g X19jbG9uZTIgKGYsIHN0YWNrLCBTVEFDS19TSVpFLCAwLCAwKTsKKyNlbHNlCisjIGlmIF9TVEFD S19HUk9XU19ET1dOCisgIHBpZF90IHAgPSBjbG9uZSAoZiwgc3RhY2sgKyBTVEFDS19TSVpFLCAw LCAwKTsKKyMgZWxpZiBfU1RBQ0tfR1JPV1NfVVAKKyAgcGlkX3QgcCA9IGNsb25lIChmLCBzdGFj aywgMCwgMCk7CisjIGVsc2UKKyMgIGVycm9yICJEZWZpbmUgZWl0aGVyIF9TVEFDS19HUk9XU19E T1dOIG9yIF9TVEFDS19HUk9XU19VUCIKKyMgZW5kaWYKKyNlbmRpZgorICBpZiAocCA9PSAtMSkK KyAgICB7CisgICAgICBwcmludGYoImNsb25lIGZhaWxlZDogJW1cbiIpOworICAgICAgcmV0dXJu IDE7CisgICAgfQorCisgIGludCBlOworICB4d2FpdHBpZCAocCwgJmUsIF9fV0NMT05FKTsKKyAg aWYgKCFXSUZFWElURUQgKGUpKQorICAgIHsKKyAgICAgIGlmIChXSUZTSUdOQUxFRCAoZSkpCisJ cHJpbnRmICgiZGllZCBmcm9tIHNpZ25hbCAlc1xuIiwgc3Ryc2lnbmFsIChXVEVSTVNJRyAoZSkp KTsKKyAgICAgIGVsc2UKKwlwdXRzICgiZGlkIG5vdCB0ZXJtaW5hdGUgY29ycmVjdGx5Iik7Cisg ICAgICByZXR1cm4gMTsKKyAgICB9CisgIGlmIChXRVhJVFNUQVRVUyAoZSkgIT0gMCkKKyAgICBv ayA9IGZhbHNlOworCisgIHJldHVybiBvayA/IDAgOiAxOworfQorCisjaW5jbHVkZSA8c3VwcG9y dC90ZXN0LWRyaXZlci5jPgpkaWZmIC0tZ2l0IGEvc3lzZGVwcy91bml4L3N5c3YvbGludXgveDg2 XzY0L2Nsb25lLlMgYi9zeXNkZXBzL3VuaXgvc3lzdi9saW51eC94ODZfNjQvY2xvbmUuUwppbmRl eCAzMWFjMTJkYTBjLi41ZjUyY2U3ODEzIDEwMDY0NAotLS0gYS9zeXNkZXBzL3VuaXgvc3lzdi9s aW51eC94ODZfNjQvY2xvbmUuUworKysgYi9zeXNkZXBzL3VuaXgvc3lzdi9saW51eC94ODZfNjQv Y2xvbmUuUwpAQCAtNTcsNiArNTcsOSBAQCBFTlRSWSAoX19jbG9uZSkKIAl0ZXN0cQklcnNpLCVy c2kJCS8qIG5vIE5VTEwgc3RhY2sgcG9pbnRlcnMgKi8KIAlqeglTWVNDQUxMX0VSUk9SX0xBQkVM CiAKKwkvKiBBbGlnbiBzdGFjayB0byAxNiBieXRlcyBwZXIgdGhlIHg4Ni02NCBwc0FCSS4gICov CisJYW5kcQkkLTE2LCAlcnNpCisKIAkvKiBJbnNlcnQgdGhlIGFyZ3VtZW50IG9udG8gdGhlIG5l dyBzdGFjay4gICovCiAJc3VicQkkMTYsJXJzaQogCW1vdnEJJXJjeCw4KCVyc2kpCi0tIAoyLjMx LjEKCg== --000000000000eff47f05c303a343--