From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by sourceware.org (Postfix) with ESMTPS id DD5C13857000 for ; Tue, 9 Aug 2022 19:35:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD5C13857000 Received: by mail-qv1-xf36.google.com with SMTP id d1so9376598qvs.0 for ; Tue, 09 Aug 2022 12:35:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=2RRSqRZTtuPUa5Ijy3xCIs4p04NxVesF9c80ljDaSvo=; b=4h/CpXDCq35XXjnxmGiel8CAAKIg3s3822fIQ3WD6M2RNKy1bEFEtNt1KelvhOS691 1+HguOLGh4uo8gfmTgkZJIO9e8O+4F+47myqXVy85pdo+b5U21Z5Jwn9SjN3QmHPWRHn mS7nBIRQTWiDpAb0ZR4+ggfKWpp+e32eoqtujAhV1+ScwcQexpx+5rnm1VdEUCXoGPrc FJyTrnusUHshDaxlJz72VceRKv8d6AQxcflL16JW3YMMVAfbS9kFvI1rbH4Ju2auza1e ixqJNdEx/2HHq9zPLw73j6mEmc93qGmQAxKQ+pLKBxaOxpxXVOjnu0LyInDXBEN8AqAj 4ykQ== X-Gm-Message-State: ACgBeo0I1bUIsyDOiHpasdp/XqkkoPm8aMEWq8kESFpGunbVOd51+E4k mys57zzxwWq3vbmPtYSRX7c0WT2a29PcaqXOR72LnZe6 X-Google-Smtp-Source: AA6agR74JKs7SGMktaZxsEK/JBhc2teAjubIaDz7SVgibnSWkLUTo8lxH9KFsxu2gxSTdtMoAJKdUW7YDG5BJUCJzvs= X-Received: by 2002:ad4:594d:0:b0:476:b36b:e52c with SMTP id eo13-20020ad4594d000000b00476b36be52cmr21187810qvb.6.1660073723284; Tue, 09 Aug 2022 12:35:23 -0700 (PDT) MIME-Version: 1.0 References: <20220808200021.763123-1-adhemerval.zanella@linaro.org> <8edb1934-df86-6956-b90c-16032ff67df9@linaro.org> <9e01cc4b-7acd-5719-6615-8fb3cb6bf80b@linaro.org> In-Reply-To: From: "H.J. Lu" Date: Tue, 9 Aug 2022 12:34:47 -0700 Message-ID: Subject: Re: [PATCH] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support To: Adhemerval Zanella Netto Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2022 19:35:25 -0000 On Tue, Aug 9, 2022 at 12:32 PM Adhemerval Zanella Netto wrote: > > > > On 09/08/22 16:06, H.J. Lu wrote: > > On Tue, Aug 9, 2022 at 11:48 AM Adhemerval Zanella Netto > > wrote: > >> > >> > >> > >> On 09/08/22 15:31, H.J. Lu wrote: > >>> On Tue, Aug 9, 2022 at 5:11 AM Adhemerval Zanella Netto > >>> wrote: > >>>> > >>>> > >>>> > >>>> On 08/08/22 19:16, H.J. Lu wrote: > >>>> > >>>>>> --- a/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S > >>>>>> +++ b/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S > >>>>>> @@ -44,4 +44,7 @@ > >>>>>> > >>>>>> # define USE_LESS_VEC_MASK_STORE 1 > >>>>>> # include "memset-vec-unaligned-erms.S" > >>>>>> +# if !defined NO_MULTIARCH && MINIMUM_X86_ISA_LEVEL >= 4 > >>>>>> +strong_alias (__memset_evex_unaligned, __memset_generic) > >>>>>> +# endif > >>>>>> #endif > >>>>> > >>>>> This will define 2 __memset_generic for -march=x86-64-v4. > >>>> > >>>> Are you sure? Check with a x86_64 build with -march=x86-64-v4 I am seeing: > >>>> > >>>> $ readelf -Ws string/memset*.os | grep -w __memset_generic | wc -l > >>>> 1 > >>>> > >>>> And it is indeed provided only by string/memset-evex-unaligned-erms.os. > >>> > >>> You are right. Since dl-symbol-hacks.h defines memset to an alias, > >>> should it be moved to sysdes/generic and each arch can provide a > >>> suitable alias? > >> > >> The dl-symbol-hacks.h is meant to be used solely by loader code (that's > >> why I have added to elf/), but I don't have a strong preference. > > > > The default should be no alias. Only IFUNC targets need to define a > > proper alias. > > Alright, although I added the alias on all targets to avoid adding another > hook to specify whether memset is implemented by IFUNC (to enable the > symbol redirection instead of use the default symbol name). I am not sure > if making arch-specific will simplify the required code here. But your patch adds alias to all targets. -- H.J.