From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com
 [IPv6:2607:f8b0:4864:20::630])
 by sourceware.org (Postfix) with ESMTPS id 8BFB7385800F
 for <libc-alpha@sourceware.org>; Sat,  5 Feb 2022 17:29:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8BFB7385800F
Received: by mail-pl1-x630.google.com with SMTP id c9so7842744plg.11
 for <libc-alpha@sourceware.org>; Sat, 05 Feb 2022 09:29:45 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=op2Wt5jc9y3lmeqaSp81PMf2t6aqhwXimo0eX23OVh8=;
 b=mNSzcZHVHnNUEd74oxf3vJ69jCnfUnVMa7OLmgZtdbzwo0Soi6R9I1aQNOYs1JynU9
 +dwxf4whnEvwtPBykV6k3hj+ib83fYNrs2pLcArtcXIMeWz18P6idJ/22xblBopL7Ys5
 aRUNOP2SMMRKpUqdAcHp8KPue+fHJ0ChTEmI4O4tinMuGgi/viCkA0ZtF1/9EJmYLEn+
 sCGIyB1fsUNaS3UVsSI5HCbi2JT/AA6Il7tahFc+K0Y+LRhWpqmqunmbwqXHQVwUluZe
 T6ZnygHGSp4B9NQyMZwJpEPdWNyeW+7GqLX7Y6ytVlIhvnVqRVtVZ9DSOHVJxXFS0oG7
 sjJA==
X-Gm-Message-State: AOAM530EHQrujq1MqGhBSvFTcva7ywQSnEUJLwHOMkGAv9l9F6OZGXMF
 vxLdRQ/Iqg1M+mDuH+EvqSATx1/TPujaBJBPvlU=
X-Google-Smtp-Source: ABdhPJx7J+M/gfy3W6MiUFESoWKkp7Yr93HzzEeO2FzIdeLhV9o8jAOJy+HGsigpobqLDolOJJ0rm0hg7MG6E0Q1//4=
X-Received: by 2002:a17:903:2350:: with SMTP id
 c16mr9144327plh.4.1644082184646; 
 Sat, 05 Feb 2022 09:29:44 -0800 (PST)
MIME-Version: 1.0
References: <20220205091044.2014455-1-goldstein.w.n@gmail.com>
In-Reply-To: <20220205091044.2014455-1-goldstein.w.n@gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Sat, 5 Feb 2022 09:29:08 -0800
Message-ID: <CAMe9rOotFu3YsRgkbHw=wDJwF7owyis-ETD8bd8CDbY3zSf-fQ@mail.gmail.com>
Subject: Re: [PATCH v1] Benchtests: move 'alloc_bufs' from loop in
 bench-memset.c
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 "Carlos O'Donell" <carlos@systemhalted.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Feb 2022 17:29:47 -0000

On Sat, Feb 5, 2022 at 1:10 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> One buf allocation is sufficient. Calling `alloc_bufs' in the loop
> just adds unnecessary syscall overhead.
> ---
>  benchtests/bench-memset.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
> index beba3fbe46..e1e2d5f176 100644
> --- a/benchtests/bench-memset.c
> +++ b/benchtests/bench-memset.c
> @@ -74,7 +74,6 @@ do_test (json_ctx_t *json_ctx, size_t align, int c, size_t len)
>    FOR_EACH_IMPL (impl, 0)
>      {
>        do_one_test (json_ctx, impl, (CHAR *) (buf1) + align, c, len);
> -      alloc_bufs ();
>      }
>
>    json_array_end (json_ctx);
> @@ -88,8 +87,9 @@ test_main (void)
>    size_t i;
>    int c = 0;
>
> -  test_init ();
>
> +  test_init ();
> +  alloc_bufs ();
>    json_init (&json_ctx, 0, stdout);
>
>    json_document_begin (&json_ctx);
> --
> 2.25.1
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.