From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 079ED385840F for ; Thu, 24 Mar 2022 19:03:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 079ED385840F Received: by mail-pl1-x629.google.com with SMTP id x2so5729902plm.7 for ; Thu, 24 Mar 2022 12:03:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1y8uCMwCtRIH4iDsmIxvdN/f2IMDk2iLjL3Qha8jLrU=; b=3O0z4mubFDtRxKVCS9hGtJxv+IsiafiZIojiak8uINeKnbfJWdxm64y6RP3ODsvEcc 6Kx0wx92q3J9jqiA382HZ5GbEmvX66VWPTbsiHVy+gDTH+mPJW9zZ0dIjqjiQ72K4FtL QqZttTFhc9P9typNj3Okp5EAYVxF9w4xw7gvDETTLKjuEdsUnHaZfrqOwrjL25EVzpuM VPG4i+2Pz52sRn5p9UchevY7i5fSmTgVnikH9HDXpoYlLANBQrYqp3EbamWdfN/bnox3 i8okHoaRYxK1S23iUTRcLOe694LHlK0mGk8uljWq1gj8Wgr86rnL/7KWsV0PafageQv5 gCUA== X-Gm-Message-State: AOAM530Q/HAe1oBXnkclwjI8xmEmQPvEDr2UB2SuX3S1AYIixSpMWZMQ 9lQ8Jg43OXYzslEasXwKyTR1GwJMpmQ9UztMAC7lr+br5DI= X-Google-Smtp-Source: ABdhPJyF7JK4X7n6gbKNKb8s9r9AGI84OM+J3dYE0iy7a55CV67IqUR7Lb7nZn6RB1oDwGsM3ir4Moj0PYsSk4vbYaY= X-Received: by 2002:a17:902:b410:b0:14b:e53:7aa0 with SMTP id x16-20020a170902b41000b0014b0e537aa0mr7257031plr.101.1648148615001; Thu, 24 Mar 2022 12:03:35 -0700 (PDT) MIME-Version: 1.0 References: <20220323215734.3927131-1-goldstein.w.n@gmail.com> <20220323215734.3927131-20-goldstein.w.n@gmail.com> In-Reply-To: <20220323215734.3927131-20-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Thu, 24 Mar 2022 12:02:59 -0700 Message-ID: Subject: Re: [PATCH v1 20/23] string: Expand page cross test cases in test-strncmp.c To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3026.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 19:03:37 -0000 On Wed, Mar 23, 2022 at 3:02 PM Noah Goldstein wrote: > > Test cases for when both `s1` and `s2` are near the end of a page > where previously missing. > --- > string/test-strncmp.c | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/string/test-strncmp.c b/string/test-strncmp.c > index 1a87f0e73e..bba9e3d2dc 100644 > --- a/string/test-strncmp.c > +++ b/string/test-strncmp.c > @@ -573,7 +573,7 @@ check_overflow (void) > int > test_main (void) > { > - size_t i, j; > + size_t i, j, k; > const size_t test_len = MIN(TEST_LEN, 3 * 4096); > test_init (); > > @@ -705,6 +705,31 @@ test_main (void) > do_test_n (j, getpagesize () - j - 1, i, ULONG_MAX - i, 0, 127, 0); > do_test_n (j, getpagesize () - j - 1, i, ULONG_MAX - i, 0, 127, 1); > do_test_n (j, getpagesize () - j - 1, i, ULONG_MAX - i, 0, 127, -1); > + > + for (k = 2; k <= 128; k += k) > + { > + do_test (getpagesize () - k, getpagesize () - j - 1, i - 1, i, > + 127, 0); > + do_test (getpagesize () - k - 1, getpagesize () - j - 1, i - 1, > + i, 127, 0); > + do_test (getpagesize () - k, getpagesize () - j - 1, i + 1, i, > + 127, 0); > + do_test (getpagesize () - k - 1, getpagesize () - j - 1, i + 1, > + i, 127, 0); > + do_test (getpagesize () - k, getpagesize () - j - 1, i, i, 127, > + 0); > + do_test (getpagesize () - k - 1, getpagesize () - j - 1, i, i, > + 127, 0); > + do_test (getpagesize () - k, getpagesize () - j - 1, i + 1, i, > + 127, -1); > + do_test (getpagesize () - k - 1, getpagesize () - j - 1, i + 1, > + i, 127, -1); > + do_test (getpagesize () - k, getpagesize () - j - 1, i + 1, i, > + 127, 1); > + do_test (getpagesize () - k - 1, getpagesize () - j - 1, i + 1, > + i, 127, 1); > + } > + > if (i < 32) > { > i += 1; > -- > 2.25.1 > LGTM. Reviewed-by: H.J. Lu Thanks. -- H.J.