From: "H.J. Lu" <hjl.tools@gmail.com>
To: Andrew Senkevich <andrew.n.senkevich@gmail.com>
Cc: libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Install libm.a as linker script [BZ #20539]
Date: Mon, 14 Nov 2016 19:22:00 -0000 [thread overview]
Message-ID: <CAMe9rOp-Q9jaq+U6o+3DA97pZV2N+MVBrkodBQKVSQNdp7SFXw@mail.gmail.com> (raw)
In-Reply-To: <CAMXFM3vFaa8oxD6Ep8Ou_ROO8ZW0oLPORwT5QtgxWL1QB+BmHQ@mail.gmail.com>
On Mon, Nov 14, 2016 at 11:15 AM, Andrew Senkevich
<andrew.n.senkevich@gmail.com> wrote:
> 2016-10-25 1:02 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
>>> diff --git a/Makerules b/Makerules
>>> index e865782..290f927 100644
>>> --- a/Makerules
>>> +++ b/Makerules
>>> @@ -1190,7 +1190,9 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \
>>> $(do-install-program)
>>> endif
>>> ifdef install-lib
>>> -install-lib.a := $(filter lib%.a,$(install-lib))
>>> +ifeq ($(build-mathvec),yes)
>>> +install-lib.a := $(filter-out libm.a,$(filter lib%.a,$(install-lib)))
>>> +endif
>>
>> Should we use $(install-lib-ldscripts) instead of libm.a here?
>
> I had tried but haven't rich a success.
Did you add libm.a to install-lib-ldscripts?
>>> # Rules for the test suite.
>>>
>>
>> Do you need to update rules for building static math tests with
>> libmvec.a?
>
> I haven't added -lmvec explicitly for any static math test so I think no.
Static math test in glibc may fail if the same bug is triggered
with ether new GCC or new test.
> Attached corrected version.
>
echo 'GROUP ( $(inst_libdir)/libm-$(lib-version).a $(inst_libdir)/libmvec.a )' \
^^^^^^^^^^^^ Please use libdir here.
--
H.J.
next prev parent reply other threads:[~2016-11-14 19:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 19:21 Andrew Senkevich
2016-10-24 22:02 ` H.J. Lu
2016-11-14 19:16 ` Andrew Senkevich
2016-11-14 19:22 ` H.J. Lu [this message]
2016-12-05 19:40 ` Andrew Senkevich
2016-12-05 20:01 ` H.J. Lu
2016-12-06 12:17 ` Andrew Senkevich
2016-12-06 14:17 ` Andreas Schwab
2016-12-06 14:49 ` Andrew Senkevich
2016-12-06 15:21 ` Andreas Schwab
2016-12-06 15:50 ` Andrew Senkevich
2016-12-06 21:49 ` H.J. Lu
2016-12-07 10:34 ` Andrew Senkevich
2016-12-07 16:22 ` H.J. Lu
2016-12-07 20:04 ` Andrew Senkevich
2016-12-07 21:50 ` H.J. Lu
2016-12-09 15:39 ` Andreas Schwab
2016-12-09 17:42 ` Andrew Senkevich
2016-12-09 18:23 ` Andreas Schwab
2016-12-12 15:45 ` Andrew Senkevich
2016-12-12 16:18 ` Andreas Schwab
2016-12-12 16:29 ` Andrew Senkevich
2016-12-12 16:42 ` Andreas Schwab
2016-12-12 17:58 ` Andrew Senkevich
2016-12-13 8:41 ` Andreas Schwab
2016-12-13 14:58 ` Andrew Senkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOp-Q9jaq+U6o+3DA97pZV2N+MVBrkodBQKVSQNdp7SFXw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=andrew.n.senkevich@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).