From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 155B13858400 for ; Fri, 8 Oct 2021 19:39:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 155B13858400 Received: by mail-pj1-x1031.google.com with SMTP id oa4so7641220pjb.2 for ; Fri, 08 Oct 2021 12:39:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O42TEjUpE9CCq/TSURT7oaK7b6lOrKJBNVqt/mv+978=; b=DuxsPG3rdz0RZW+Bvz1M6LhWy3Hei89ipNJXc3ueBQxPDjZZLWtHkOr34LrQL536eq ZZSZW3gXRlqZwx3gpjOPEPSUdivpuTlNtlkNrVfnw6cLweBprpTLauhNNw1r4TBfm4qu 9UdMBh24u4P8T5x6cQmQ8T3Q82u93qm0A57RNFJwHtNre473HKtcd1Wy7XZJwHubS6rO LZZGIU1EmEzQnkQYai9MUaIgGVclCK/1Rern4Omn6Rh3EK9eGZXF3WdPPhh/bItlHw4A RwHc+LCCBnun4g+eciSl/UHVVahd4pvfJq48leoXUgrD1b7u7csCYhi2wAsHkTM+9xr1 xU/g== X-Gm-Message-State: AOAM532Mbh1f0UvZPYQid46dYNz8Xa1L9g6at13S7r/obZdtLSJmsaRF x57/vOoxnbf/GugxlLnb8Gcerp4CFrM22WsvAcISGKA/GuA= X-Google-Smtp-Source: ABdhPJyI7P+LeEufsbZa5YLG3U2ounyCap/p4DQDDHr2IeAxRSeXEg58khhjKvQb8fx/cndjlaBBaB+9PCn4y6BLdto= X-Received: by 2002:a17:903:1103:b0:13e:ec6d:524a with SMTP id n3-20020a170903110300b0013eec6d524amr10949101plh.85.1633721992062; Fri, 08 Oct 2021 12:39:52 -0700 (PDT) MIME-Version: 1.0 References: <20210926205306.900081-1-goldstein.w.n@gmail.com> In-Reply-To: <20210926205306.900081-1-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Fri, 8 Oct 2021 12:39:16 -0700 Message-ID: Subject: Re: [PATCH v1 1/3] benchtests: Add medium cases and increase iters in bench-memset.c To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3030.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Oct 2021 19:39:54 -0000 On Sun, Sep 26, 2021 at 1:53 PM Noah Goldstein wrote: > > No bug. > > This commit adds new medium size cases for lengths in [512, 1024). As > well it increase the iters to INNER_LOOP_ITERS_LARGE for more reliable > results. > > Signed-off-by: Noah Goldstein > --- > benchtests/bench-memset.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c > index d6619b4836..4284cb1724 100644 > --- a/benchtests/bench-memset.c > +++ b/benchtests/bench-memset.c > @@ -43,7 +43,7 @@ static void > do_one_test (json_ctx_t *json_ctx, impl_t *impl, CHAR *s, > int c __attribute ((unused)), size_t n) > { > - size_t i, iters = INNER_LOOP_ITERS; > + size_t i, iters = INNER_LOOP_ITERS_LARGE; > timing_t start, stop, cur; > > TIMING_NOW (start); > @@ -118,7 +118,7 @@ test_main (void) > if (i & (i - 1)) > do_test (&json_ctx, 0, c, i); > } > - for (i = 32; i < 512; i+=32) > + for (i = 32; i < 1024; i+=32) > { > do_test (&json_ctx, 0, c, i); > do_test (&json_ctx, i, c, i); > -- > 2.25.1 > LGTM. Reviewed-by: H.J. Lu Thanks. -- H.J.